| Message ID | 20201008125659.49857-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | tcg patch queue | expand |
Patchew URL: https://patchew.org/QEMU/20201008125659.49857-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201008125659.49857-1-richard.henderson@linaro.org
Subject: [PULL 00/11] tcg patch queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200930121105.667049-1-eblake@redhat.com -> patchew/20200930121105.667049-1-eblake@redhat.com
- [tag update] patchew/20201001170752.82063-1-richard.henderson@linaro.org -> patchew/20201001170752.82063-1-richard.henderson@linaro.org
- [tag update] patchew/20201002215955.254866-1-richard.henderson@linaro.org -> patchew/20201002215955.254866-1-richard.henderson@linaro.org
- [tag update] patchew/20201004180443.2035359-1-f4bug@amsat.org -> patchew/20201004180443.2035359-1-f4bug@amsat.org
- [tag update] patchew/20201007160038.26953-1-alex.bennee@linaro.org -> patchew/20201007160038.26953-1-alex.bennee@linaro.org
* [new tag] patchew/20201008125659.49857-1-richard.henderson@linaro.org -> patchew/20201008125659.49857-1-richard.henderson@linaro.org
Switched to a new branch 'test'
9aed6a6 accel/tcg: Fix computing of is_write for MIPS
4d1e622 tcg: Remove TCG_TARGET_HAS_cmp_vec
c4897cd tcg/optimize: Fold dup2_vec
2e58dc0 tcg: Fix generation of dupi_vec for 32-bit host
96f7941 tcg/i386: Fix dupi for avx2 32-bit hosts
0b5bcbb tcg: Remove TCGOpDef.used
40cea0e tcg: Move some TCG_CT_* bits to TCGArgConstraint bitfields
7c62277 tcg: Remove TCG_CT_REG
42d330b tcg: Move sorted_args into TCGArgConstraint.sort_index
1eff219 tcg: Drop union from TCGArgConstraint
2c84345 tcg: Adjust simd_desc size encoding
=== OUTPUT BEGIN ===
1/11 Checking commit 2c84345198c1 (tcg: Adjust simd_desc size encoding)
2/11 Checking commit 1eff219a2edb (tcg: Drop union from TCGArgConstraint)
ERROR: braces {} are necessary for all arms of this statement
#407: FILE: tcg/tcg.c:2213:
+ if (tcg_regset_test_reg(arg_ct->regs, i))
[...]
total: 1 errors, 0 warnings, 420 lines checked
Patch 2/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 42d330b3f312 (tcg: Move sorted_args into TCGArgConstraint.sort_index)
4/11 Checking commit 7c62277f9d05 (tcg: Remove TCG_CT_REG)
5/11 Checking commit 40cea0e3c162 (tcg: Move some TCG_CT_* bits to TCGArgConstraint bitfields)
ERROR: spaces prohibited around that ':' (ctx:WxW)
#36: FILE: include/tcg/tcg.h:982:
+ unsigned ct : 16;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#37: FILE: include/tcg/tcg.h:983:
+ unsigned alias_index : 4;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#38: FILE: include/tcg/tcg.h:984:
+ unsigned sort_index : 4;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#39: FILE: include/tcg/tcg.h:985:
+ bool oalias : 1;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#40: FILE: include/tcg/tcg.h:986:
+ bool ialias : 1;
^
ERROR: spaces prohibited around that ':' (ctx:WxW)
#41: FILE: include/tcg/tcg.h:987:
+ bool newreg : 1;
^
total: 6 errors, 0 warnings, 106 lines checked
Patch 5/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit 0b5bcbbf91ca (tcg: Remove TCGOpDef.used)
7/11 Checking commit 96f79419c763 (tcg/i386: Fix dupi for avx2 32-bit hosts)
8/11 Checking commit 2e58dc08335c (tcg: Fix generation of dupi_vec for 32-bit host)
9/11 Checking commit c4897cd9e9b1 (tcg/optimize: Fold dup2_vec)
10/11 Checking commit 4d1e62279de6 (tcg: Remove TCG_TARGET_HAS_cmp_vec)
11/11 Checking commit 9aed6a69f26e (accel/tcg: Fix computing of is_write for MIPS)
WARNING: architecture specific defines should be avoided
#28: FILE: accel/tcg/user-exec.c:705:
+#if defined(__misp16) || defined(__mips_micromips)
ERROR: space required before the open parenthesis '('
#44: FILE: accel/tcg/user-exec.c:719:
+ switch((insn >> 26) & 077) {
WARNING: architecture specific defines should be avoided
#57: FILE: accel/tcg/user-exec.c:732:
+#if !defined(__mips_isa_rev) || __mips_isa_rev < 6
WARNING: Block comments use a leading /* on a separate line
#64: FILE: accel/tcg/user-exec.c:739:
+ /* Required in all versions of MIPS64 since
WARNING: Block comments use * on subsequent lines
#65: FILE: accel/tcg/user-exec.c:740:
+ /* Required in all versions of MIPS64 since
+ MIPS64r1 and subsequent versions of MIPS32r2. */
WARNING: Block comments use a trailing */ on a separate line
#65: FILE: accel/tcg/user-exec.c:740:
+ MIPS64r1 and subsequent versions of MIPS32r2. */
total: 1 errors, 5 warnings, 55 lines checked
Patch 11/11 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201008125659.49857-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Thu, 8 Oct 2020 at 13:57, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit 6eeea6725a70e6fcb5abba0764496bdab07ddfb3: > > Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-10-06' into staging (2020-10-06 21:13:34 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20201008 > > for you to fetch changes up to 62475e9d007d83db4d0a6ccebcda8914f392e9c9: > > accel/tcg: Fix computing of is_write for MIPS (2020-10-08 05:57:32 -0500) > > ---------------------------------------------------------------- > Extend maximum gvec vector size > Fix i386 avx2 dupi > Fix mips host user-only write detection > Misc cleanups. > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM
The following changes since commit 6eeea6725a70e6fcb5abba0764496bdab07ddfb3: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-10-06' into staging (2020-10-06 21:13:34 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20201008 for you to fetch changes up to 62475e9d007d83db4d0a6ccebcda8914f392e9c9: accel/tcg: Fix computing of is_write for MIPS (2020-10-08 05:57:32 -0500) ---------------------------------------------------------------- Extend maximum gvec vector size Fix i386 avx2 dupi Fix mips host user-only write detection Misc cleanups. ---------------------------------------------------------------- Kele Huang (1): accel/tcg: Fix computing of is_write for MIPS Richard Henderson (10): tcg: Adjust simd_desc size encoding tcg: Drop union from TCGArgConstraint tcg: Move sorted_args into TCGArgConstraint.sort_index tcg: Remove TCG_CT_REG tcg: Move some TCG_CT_* bits to TCGArgConstraint bitfields tcg: Remove TCGOpDef.used tcg/i386: Fix dupi for avx2 32-bit hosts tcg: Fix generation of dupi_vec for 32-bit host tcg/optimize: Fold dup2_vec tcg: Remove TCG_TARGET_HAS_cmp_vec include/tcg/tcg-gvec-desc.h | 38 ++++++++++++------ include/tcg/tcg.h | 22 ++++------ tcg/aarch64/tcg-target.h | 1 - tcg/i386/tcg-target.h | 1 - tcg/ppc/tcg-target.h | 1 - accel/tcg/user-exec.c | 43 ++++++++++++++++++-- tcg/optimize.c | 15 +++++++ tcg/tcg-op-gvec.c | 35 ++++++++++++---- tcg/tcg-op-vec.c | 12 ++++-- tcg/tcg.c | 96 +++++++++++++++++++------------------------- tcg/aarch64/tcg-target.c.inc | 17 ++++---- tcg/arm/tcg-target.c.inc | 29 ++++++------- tcg/i386/tcg-target.c.inc | 39 +++++++----------- tcg/mips/tcg-target.c.inc | 21 +++++----- tcg/ppc/tcg-target.c.inc | 29 ++++++------- tcg/riscv/tcg-target.c.inc | 16 ++++---- tcg/s390/tcg-target.c.inc | 22 +++++----- tcg/sparc/tcg-target.c.inc | 21 ++++------ tcg/tci/tcg-target.c.inc | 3 +- 19 files changed, 244 insertions(+), 217 deletions(-)