| Message ID | 20201015201035.1964-3-luoyonggang@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fixes docs building on msys2/mingw | expand |
Why? Paolo Il gio 15 ott 2020, 22:11 Yonggang Luo <luoyonggang@gmail.com> ha scritto: > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> > --- > configure | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configure b/configure > index f839c2a557..1ce31f97b4 100755 > --- a/configure > +++ b/configure > @@ -971,7 +971,7 @@ for opt do > ;; > --with-suffix=*) qemu_suffix="$optarg" > ;; > - --docdir=*) qemu_docdir="$optarg" > + --docdir=*) docdir="$optarg" > ;; > --sysconfdir=*) sysconfdir="$optarg" > ;; > @@ -5770,7 +5770,6 @@ fi > qemu_confdir="$sysconfdir/$qemu_suffix" > qemu_moddir="$libdir/$qemu_suffix" > qemu_datadir="$datadir/$qemu_suffix" > -qemu_docdir="$docdir/$qemu_suffix" > qemu_localedir="$datadir/locale" > qemu_icondir="$datadir/icons" > qemu_desktopdir="$datadir/applications" > -- > 2.28.0.windows.1 > > <div dir="auto"><div>Why?</div><div dir="auto"><br></div><div dir="auto">Paolo<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">Il gio 15 ott 2020, 22:11 Yonggang Luo <<a href="mailto:luoyonggang@gmail.com">luoyonggang@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Yonggang Luo <<a href="mailto:luoyonggang@gmail.com" target="_blank" rel="noreferrer">luoyonggang@gmail.com</a>><br> ---<br> configure | 3 +--<br> 1 file changed, 1 insertion(+), 2 deletions(-)<br> <br> diff --git a/configure b/configure<br> index f839c2a557..1ce31f97b4 100755<br> --- a/configure<br> +++ b/configure<br> @@ -971,7 +971,7 @@ for opt do<br> ;;<br> --with-suffix=*) qemu_suffix="$optarg"<br> ;;<br> - --docdir=*) qemu_docdir="$optarg"<br> + --docdir=*) docdir="$optarg"<br> ;;<br> --sysconfdir=*) sysconfdir="$optarg"<br> ;;<br> @@ -5770,7 +5770,6 @@ fi<br> qemu_confdir="$sysconfdir/$qemu_suffix"<br> qemu_moddir="$libdir/$qemu_suffix"<br> qemu_datadir="$datadir/$qemu_suffix"<br> -qemu_docdir="$docdir/$qemu_suffix"<br> qemu_localedir="$datadir/locale"<br> qemu_icondir="$datadir/icons"<br> qemu_desktopdir="$datadir/applications"<br> -- <br> 2.28.0.windows.1<br> <br> </blockquote></div></div></div>
Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir not used at all in configure, On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini <pbonzini@redhat.com> wrote: > > Why? > > Paolo > > Il gio 15 ott 2020, 22:11 Yonggang Luo <luoyonggang@gmail.com> ha scritto: >> >> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> >> --- >> configure | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index f839c2a557..1ce31f97b4 100755 >> --- a/configure >> +++ b/configure >> @@ -971,7 +971,7 @@ for opt do >> ;; >> --with-suffix=*) qemu_suffix="$optarg" >> ;; >> - --docdir=*) qemu_docdir="$optarg" >> + --docdir=*) docdir="$optarg" >> ;; >> --sysconfdir=*) sysconfdir="$optarg" >> ;; >> @@ -5770,7 +5770,6 @@ fi >> qemu_confdir="$sysconfdir/$qemu_suffix" >> qemu_moddir="$libdir/$qemu_suffix" >> qemu_datadir="$datadir/$qemu_suffix" >> -qemu_docdir="$docdir/$qemu_suffix" >> qemu_localedir="$datadir/locale" >> qemu_icondir="$datadir/icons" >> qemu_desktopdir="$datadir/applications" >> -- >> 2.28.0.windows.1 >> -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo <div dir="ltr">Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir not used at all in configure,<div><br>On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini <<a href="mailto:pbonzini@redhat.com">pbonzini@redhat.com</a>> wrote:<br>><br>> Why?<br>><br>> Paolo<br>><br>> Il gio 15 ott 2020, 22:11 Yonggang Luo <<a href="mailto:luoyonggang@gmail.com">luoyonggang@gmail.com</a>> ha scritto:<br>>><br>>> Signed-off-by: Yonggang Luo <<a href="mailto:luoyonggang@gmail.com">luoyonggang@gmail.com</a>><br>>> ---<br>>> configure | 3 +--<br>>> 1 file changed, 1 insertion(+), 2 deletions(-)<br>>><br>>> diff --git a/configure b/configure<br>>> index f839c2a557..1ce31f97b4 100755<br>>> --- a/configure<br>>> +++ b/configure<br>>> @@ -971,7 +971,7 @@ for opt do<br>>> ;;<br>>> --with-suffix=*) qemu_suffix="$optarg"<br>>> ;;<br>>> - --docdir=*) qemu_docdir="$optarg"<br>>> + --docdir=*) docdir="$optarg"<br>>> ;;<br>>> --sysconfdir=*) sysconfdir="$optarg"<br>>> ;;<br>>> @@ -5770,7 +5770,6 @@ fi<br>>> qemu_confdir="$sysconfdir/$qemu_suffix"<br>>> qemu_moddir="$libdir/$qemu_suffix"<br>>> qemu_datadir="$datadir/$qemu_suffix"<br>>> -qemu_docdir="$docdir/$qemu_suffix"<br>>> qemu_localedir="$datadir/locale"<br>>> qemu_icondir="$datadir/icons"<br>>> qemu_desktopdir="$datadir/applications"<br>>> --<br>>> 2.28.0.windows.1<br>>><br><br><br>--<br> 此致<br>礼<br>罗勇刚<br>Yours<br> sincerely,<br>Yonggang Luo</div></div>
diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$optarg" ;; - --docdir=*) qemu_docdir="$optarg" + --docdir=*) docdir="$optarg" ;; --sysconfdir=*) sysconfdir="$optarg" ;; @@ -5770,7 +5770,6 @@ fi qemu_confdir="$sysconfdir/$qemu_suffix" qemu_moddir="$libdir/$qemu_suffix" qemu_datadir="$datadir/$qemu_suffix" -qemu_docdir="$docdir/$qemu_suffix" qemu_localedir="$datadir/locale" qemu_icondir="$datadir/icons" qemu_desktopdir="$datadir/applications"
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)