diff mbox series

[v2,5/8] migration: Add braces {} for if statement

Message ID 1602508140-11372-6-git-send-email-yubihong@huawei.com
State Superseded
Headers show
Series Fix some style problems in migration | expand

Commit Message

Bihong Yu Oct. 12, 2020, 1:08 p.m. UTC 
Signed-off-by: Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
---
 migration/ram.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Dr. David Alan Gilbert Oct. 14, 2020, 7:17 p.m. UTC | #1 
* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>

> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


> ---

>  migration/ram.c | 6 ++++--

>  1 file changed, 4 insertions(+), 2 deletions(-)

> 

> diff --git a/migration/ram.c b/migration/ram.c

> index 0aea78f..09178cc 100644

> --- a/migration/ram.c

> +++ b/migration/ram.c

> @@ -101,14 +101,16 @@ static struct {

>  

>  static void XBZRLE_cache_lock(void)

>  {

> -    if (migrate_use_xbzrle())

> +    if (migrate_use_xbzrle()) {

>          qemu_mutex_lock(&XBZRLE.lock);

> +    }

>  }

>  

>  static void XBZRLE_cache_unlock(void)

>  {

> -    if (migrate_use_xbzrle())

> +    if (migrate_use_xbzrle()) {

>          qemu_mutex_unlock(&XBZRLE.lock);

> +    }

>  }

>  

>  /**

> -- 

> 1.8.3.1

> 

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Philippe Mathieu-Daudé Oct. 20, 2020, 6:47 a.m. UTC | #2 
On 10/12/20 3:08 PM, Bihong Yu wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>
> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
> ---
>   migration/ram.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/migration/ram.c b/migration/ram.c
index 0aea78f..09178cc 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -101,14 +101,16 @@  static struct {
 
 static void XBZRLE_cache_lock(void)
 {
-    if (migrate_use_xbzrle())
+    if (migrate_use_xbzrle()) {
         qemu_mutex_lock(&XBZRLE.lock);
+    }
 }
 
 static void XBZRLE_cache_unlock(void)
 {
-    if (migrate_use_xbzrle())
+    if (migrate_use_xbzrle()) {
         qemu_mutex_unlock(&XBZRLE.lock);
+    }
 }
 
 /**