| Message ID | 1603163448-27122-1-git-send-email-yubihong@huawei.com |
|---|---|
| Headers | show |
| Series | Fix some style problems in migration | expand |
Patchew URL: https://patchew.org/QEMU/1603163448-27122-1-git-send-email-yubihong@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1603163448-27122-1-git-send-email-yubihong@huawei.com
Subject: [PATCH v3 0/8] Fix some style problems in migration
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1603163448-27122-1-git-send-email-yubihong@huawei.com -> patchew/1603163448-27122-1-git-send-email-yubihong@huawei.com
- [tag update] patchew/cover.1602634524.git.alistair.francis@wdc.com -> patchew/cover.1602634524.git.alistair.francis@wdc.com
Switched to a new branch 'test'
b33edea migration: Delete redundant spaces
277563d migration: Open brace '{' following function declarations go on the next line
7dd0ad0 migration: Do not initialise statics and globals to 0 or NULL
5540fd1 migration: Add braces {} for if statement
89c1a12 migration: Open brace '{' following struct go on the same line
23e7f3f migration: Add spaces around operator
cc9ec99 migration: Don't use '#' flag of printf format
122dc68 migration: Do not use C99 // comments
=== OUTPUT BEGIN ===
1/8 Checking commit 122dc68da3df (migration: Do not use C99 // comments)
2/8 Checking commit cc9ec99c5ac0 (migration: Don't use '#' flag of printf format)
3/8 Checking commit 23e7f3fb51c2 (migration: Add spaces around operator)
ERROR: spaces required around that '*' (ctx:WxV)
#62: FILE: migration/savevm.c:524:
+ .subsections = (const VMStateDescription *[]) {
^
total: 1 errors, 0 warnings, 59 lines checked
Patch 3/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/8 Checking commit 89c1a1215ef0 (migration: Open brace '{' following struct go on the same line)
5/8 Checking commit 5540fd121f19 (migration: Add braces {} for if statement)
6/8 Checking commit 7dd0ad0c5b86 (migration: Do not initialise statics and globals to 0 or NULL)
7/8 Checking commit 277563d27c33 (migration: Open brace '{' following function declarations go on the next line)
8/8 Checking commit b33edea584b4 (migration: Delete redundant spaces)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1603163448-27122-1-git-send-email-yubihong@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Bihong Yu <yubihong@huawei.com> wrote: > Signed-off-by: Bihong Yu <yubihong@huawei.com> > Reviewed-by: Chuan Zheng <zhengchuan@huawei.com> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/block.c | 2 +- > migration/ram.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Juan Quintela <quintela@redhat.com>
Bihong Yu <yubihong@huawei.com> wrote: > Signed-off-by: Bihong Yu <yubihong@huawei.com> > Reviewed-by: Chuan Zheng <zhengchuan@huawei.com> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/migration.c | 4 ++-- > migration/postcopy-ram.c | 2 +- > migration/ram.c | 2 +- > migration/savevm.c | 2 +- > migration/vmstate.c | 10 +++++----- > 5 files changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Juan Quintela <quintela@redhat.com>
Bihong Yu <yubihong@huawei.com> wrote: > Signed-off-by: Bihong Yu <yubihong@huawei.com> > Reviewed-by: Chuan Zheng <zhengchuan@huawei.com> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
* Bihong Yu (yubihong@huawei.com) wrote: > Recently I am reading migration related code, find some style problems in > migration directory while using checkpatch.pl to check migration code. Fix the > error style problems. > Queued > v2: > - fix Signed-off-by error > - fix printf format error: "%0x" -> "0x%x" > > v3: > - change "VMStateDescription * []" to "VMStateDescription *[]" > > Bihong Yu (8): > migration: Do not use C99 // comments > migration: Don't use '#' flag of printf format > migration: Add spaces around operator > migration: Open brace '{' following struct go on the same line > migration: Add braces {} for if statement > migration: Do not initialise statics and globals to 0 or NULL > migration: Open brace '{' following function declarations go on the > next line > migration: Delete redundant spaces > > migration/block.c | 4 ++-- > migration/migration.c | 4 ++-- > migration/migration.h | 3 +-- > migration/postcopy-ram.c | 2 +- > migration/ram.c | 14 ++++++++------ > migration/rdma.c | 7 ++++--- > migration/savevm.c | 4 ++-- > migration/vmstate.c | 10 +++++----- > 8 files changed, 25 insertions(+), 23 deletions(-) > > -- > 1.8.3.1 > >
Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. v2: - fix Signed-off-by error - fix printf format error: "%0x" -> "0x%x" v3: - change "VMStateDescription * []" to "VMStateDescription *[]" Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format migration: Add spaces around operator migration: Open brace '{' following struct go on the same line migration: Add braces {} for if statement migration: Do not initialise statics and globals to 0 or NULL migration: Open brace '{' following function declarations go on the next line migration: Delete redundant spaces migration/block.c | 4 ++-- migration/migration.c | 4 ++-- migration/migration.h | 3 +-- migration/postcopy-ram.c | 2 +- migration/ram.c | 14 ++++++++------ migration/rdma.c | 7 ++++--- migration/savevm.c | 4 ++-- migration/vmstate.c | 10 +++++----- 8 files changed, 25 insertions(+), 23 deletions(-)