| Message ID | 20201020155402.30318-1-qiangqing.zhang@nxp.com |
|---|---|
| Headers | show |
| Series | can: flexcan: add stop mode support for i.MX8QM | expand |
On 10/20/20 5:53 PM, Joakim Zhang wrote: > The first patch from Liu Ying aims to export SCU symbols for SoCs w/wo SCU, > so that no need to check CONFIG_IMX_SCU in the specific driver. > > The following patches are flexcan fixes and add stop mode support for i.MX8QM. I've applied 3,4,5 to linux-can/testing. I'll take 6 to linux-can, too as soon as it has a better description. Who will take care of 1, 9? The dt-bindings changes have to wait until the conversion to yaml is finished. This and the rest will go via can-next to net-next. regards, Marc
Hi Marc, > -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 2020年10月20日 17:31 > To: Joakim Zhang <qiangqing.zhang@nxp.com>; robh+dt@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de > Cc: kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; Ying Liu > <victor.liu@nxp.com>; linux-can@vger.kernel.org; Pankaj Bansal > <pankaj.bansal@nxp.com>; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove() > > On 10/20/20 5:53 PM, Joakim Zhang wrote: > > Disable wakeup in flexcan_remove(). > > The patch looks good, please explain why this is needed. Okay, Can I resend this patch individually? Joakim > Marc > > > > > Fixes: de3578c198c6 ("can: flexcan: add self wakeup support") > > Fixes: 915f9666421c ("can: flexcan: add support for DT property > > 'wakeup-source'") > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > --- > > drivers/net/can/flexcan.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > > index 06f94b6f0ebe..881799bd9c5e 100644 > > --- a/drivers/net/can/flexcan.c > > +++ b/drivers/net/can/flexcan.c > > @@ -2062,6 +2062,8 @@ static int flexcan_remove(struct platform_device > > *pdev) { > > struct net_device *dev = platform_get_drvdata(pdev); > > > > + device_set_wakeup_enable(&pdev->dev, false); > > + device_set_wakeup_capable(&pdev->dev, false); > > unregister_flexcandev(dev); > > pm_runtime_disable(&pdev->dev); > > free_candev(dev); > > > > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
On 10/20/20 12:29 PM, Joakim Zhang wrote: >> On 10/20/20 5:53 PM, Joakim Zhang wrote: >>> Disable wakeup in flexcan_remove(). >> >> The patch looks good, please explain why this is needed. > > Okay, Can I resend this patch individually? sure. Marc
The first patch from Liu Ying aims to export SCU symbols for SoCs w/wo SCU, so that no need to check CONFIG_IMX_SCU in the specific driver. The following patches are flexcan fixes and add stop mode support for i.MX8QM. ChangeLogs: V2->V3: * define IMX_SC_R_CAN(x) in rsrc.h * remove error message on -EPROBE_DEFER. * split disable wakeup patch into separate one. V1->V2: * split ECC fix patches into separate patches. * free can dev if failed to setup stop mode. * disable wakeup on flexcan_remove. * add FLEXCAN_IMX_SC_R_CAN macro helper. * fsl,can-index->fsl,scu-index. * move fsl,scu-index and priv->can_idx into * flexcan_setup_stop_mode_scfw() * prove failed if failed to setup stop mode. Joakim Zhang (9): dt-bindings: can: flexcan: fix fsl,clk-source property can: flexcan: remove FLEXCAN_QUIRK_DISABLE_MECR quirk for LS1021A can: flexcan: add ECC initialization for LX2160A can: flexcan: add ECC initialization for VF610 can: flexcan: disable wakeup in flexcan_remove() dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN can: flexcan: add CAN wakeup function for i.MX8QM Liu Ying (1): firmware: imx: always export SCU symbols .../bindings/net/can/fsl-flexcan.txt | 8 +- drivers/net/can/flexcan.c | 147 ++++++++++++++---- include/dt-bindings/firmware/imx/rsrc.h | 1 + include/linux/firmware/imx/ipc.h | 15 ++ include/linux/firmware/imx/svc/misc.h | 23 +++ 5 files changed, 167 insertions(+), 27 deletions(-)