| Message ID | 20200901075417.22481-1-krzk@kernel.org |
|---|---|
| Headers | show |
| Series | ARM: dts: exynos: dtschema cleanups for Exynos5 | expand |
On Tue, 1 Sep 2020 at 09:54, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Hi, > > This is continuation of my series of dtschema cleanup for Exynos SoCs. > > The previous series are here: > https://lore.kernel.org/linux-samsung-soc/20200830135200.24304-1-krzk@kernel.org/T/#t Except the first one, other links are wrong. Here are correct: https://lore.kernel.org/linux-samsung-soc/20200829142948.32365-1-krzk@kernel.org/T/#t https://lore.kernel.org/linux-samsung-soc/ec9deeb1-8599-d755-cbfa-5db9787368e1@samsung.com/T/#t https://lore.kernel.org/linux-samsung-soc/20200829210652.GD796939@ravnborg.org/T/#t Best regards, Krzysztof
On Tue, 1 Sep 2020 at 10:13, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Krzysztof, > > On 01.09.2020 09:54, Krzysztof Kozlowski wrote: > > The SATA PHY in Exynos5250 SoCs has two interfaces and two device nodes: > > 1. sata-phy@12170000 > > 2. i2c-9/i2c@38 > > > > The first node represents the actual SATA PHY device with phy-cells. > > The second represents additional I2C interface, needed by the driver > > to communicate with the SATA PHY device. It is not a PHY-provider in > > the terms of dtschema so rename it to silence dtbs_check warning: > > > > arch/arm/boot/dts/exynos5250-arndale.dt.yaml: sata-phy@38: '#phy-cells' is a required property > > From schema: lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > arch/arm/boot/dts/exynos5250-arndale.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts > > index f2bcce167b2d..3c401c82905c 100644 > > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > > @@ -544,7 +544,7 @@ > > samsung,i2c-max-bus-freq = <40000>; > > samsung,i2c-slave-addr = <0x38>; > > > > - sata_phy_i2c: sata-phy@38 { > > + sata_phy_i2c: sata-phy-i2c@38 { > > compatible = "samsung,exynos-sataphy-i2c"; > > reg = <0x38>; > > }; > > I'm not against the rename, but frankly, the above node and all i2c > parameters should be moved to exynos5250.dtsi. This is a SoC internal > things (the same way as hdmiphy in exynos4.dtsi), so the board dts > should only contain information like status = "enabled" for i2c_8 and > hdmi_i2c_phy nodes. No need to duplicate it here and in smdk5250.dts. Good point, the I2C bus used here is an internal part of SoC. I will squash these two changes into a new one. Thanks for the review! Best regards, Krzysztof
On 01.09.2020 10:19, Krzysztof Kozlowski wrote: > On Tue, 1 Sep 2020 at 10:17, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On Tue, 1 Sep 2020 at 10:13, Marek Szyprowski <m.szyprowski@samsung.com> wrote: >>> On 01.09.2020 09:54, Krzysztof Kozlowski wrote: >>>> The SATA PHY in Exynos5250 SoCs has two interfaces and two device nodes: >>>> 1. sata-phy@12170000 >>>> 2. i2c-9/i2c@38 >>>> >>>> The first node represents the actual SATA PHY device with phy-cells. >>>> The second represents additional I2C interface, needed by the driver >>>> to communicate with the SATA PHY device. It is not a PHY-provider in >>>> the terms of dtschema so rename it to silence dtbs_check warning: >>>> >>>> arch/arm/boot/dts/exynos5250-arndale.dt.yaml: sata-phy@38: '#phy-cells' is a required property >>>> From schema: lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>>> --- >>>> arch/arm/boot/dts/exynos5250-arndale.dts | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts >>>> index f2bcce167b2d..3c401c82905c 100644 >>>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts >>>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts >>>> @@ -544,7 +544,7 @@ >>>> samsung,i2c-max-bus-freq = <40000>; >>>> samsung,i2c-slave-addr = <0x38>; >>>> >>>> - sata_phy_i2c: sata-phy@38 { >>>> + sata_phy_i2c: sata-phy-i2c@38 { >>>> compatible = "samsung,exynos-sataphy-i2c"; >>>> reg = <0x38>; >>>> }; >>> I'm not against the rename, but frankly, the above node and all i2c >>> parameters should be moved to exynos5250.dtsi. This is a SoC internal >>> things (the same way as hdmiphy in exynos4.dtsi), so the board dts >>> should only contain information like status = "enabled" for i2c_8 and >>> hdmi_i2c_phy nodes. No need to duplicate it here and in smdk5250.dts. >> Good point, the I2C bus used here is an internal part of SoC. >> >> I will squash these two changes into a new one. Thanks for the review! > While at it, I wonder about the samsung,i2c-slave-addr property. Is it > really needed? Are there multiple masters on this bus? This might be some cargo-cult, probably copied from HDMI DDC (I'm not sure if it is needed there). I've removed it and SATA still works fine on Exynos5250 Arndale board. Best regards
On Tue, Sep 01, 2020 at 09:54:17AM +0200, Krzysztof Kozlowski wrote: > Use the 32 kHz clock from S2MPS11 PMIC in the S3C RTC node. Except > making the S3C RTC working, this also fixes dtbs_check warnings: > > arch/arm/boot/dts/exynos5420-smdk5420.dt.yaml: rtc@101e0000: clocks: [[2, 317]] is too short > arch/arm/boot/dts/exynos5420-smdk5420.dt.yaml: rtc@101e0000: clock-names: ['rtc'] is too short > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 3 +++ Applied. Best regards, Krzysztof
Hi, This is continuation of my series of dtschema cleanup for Exynos SoCs. The previous series are here: https://lore.kernel.org/linux-samsung-soc/20200830135200.24304-1-krzk@kernel.org/T/#t https://lore.kernel.org/linux-samsung-soc/20200830135200.24304-1-krzk@kernel.org/T/#t https://lore.kernel.org/linux-samsung-soc/20200830135200.24304-1-krzk@kernel.org/T/#t https://lore.kernel.org/linux-samsung-soc/20200830135200.24304-1-krzk@kernel.org/T/#t TODO - remaining: S3C, S5Pv210. Best regards, Krzysztof Krzysztof Kozlowski (13): ARM: dts: exynos: Correct compatible for Exynos5 GIC ARM: dts: exynos: Correct compatible for Exynos5260 GIC ARM: dts: exynos: Remove unneeded address/size cells in Exynos5260 GIC ARM: dts: exynos: Correct S3C RTC bindings in SMDK5410 ARM: dts: exynos: Silence i2c-gpio dtschema warning in Exynos5250 Arndale ARM: dts: exynos: Correct whitespace and indentation issues in Exynos5 ARM: dts: exynos: Override thermal by label in Exynos5250 ARM: dts: exynos: Add max77686 clocks for S3C RTC in SMDK5250 ARM: dts: exynos: Use S5M8767 clock in S3C RTC in Exynos5250 Spring ARM: dts: exynos: Silence DP HPD pinctrl dtschema warning in Exynos5250 Spring ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale ARM: dts: exynos: Silence SATA PHY warning in SMDK5250 ARM: dts: exynos: Use S2MPS11 clock in S3C RTC in SMDK5420 arch/arm/boot/dts/exynos5.dtsi | 10 ++-- arch/arm/boot/dts/exynos5250-arndale.dts | 12 ++--- arch/arm/boot/dts/exynos5250-smdk5250.dts | 8 +++- arch/arm/boot/dts/exynos5250-spring.dts | 41 ++++++++++------- arch/arm/boot/dts/exynos5250.dtsi | 46 +++++++++---------- arch/arm/boot/dts/exynos5260.dtsi | 4 +- arch/arm/boot/dts/exynos5410-odroidxu.dts | 8 ++-- arch/arm/boot/dts/exynos5410-smdk5410.dts | 12 +++++ arch/arm/boot/dts/exynos5410.dtsi | 12 ++--- arch/arm/boot/dts/exynos5420-smdk5420.dts | 3 ++ arch/arm/boot/dts/exynos5420.dtsi | 16 +++---- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 4 +- 12 files changed, 99 insertions(+), 77 deletions(-)