| Message ID | 20200910161933.9156-1-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen | expand |
On Thu, 10 Sep 2020 18:19:32 +0200, Krzysztof Kozlowski wrote: > The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch > screen. In such case the second interrupt is required. This second > interrupt can be anyway provided, even without touch screens. This > fixes dtbs_check warnings like: > > arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com> > > --- > > Changes since v1: > 1. Fix if:has-touchscreen, as pointed by Rob. > 2. Add Ack. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 10 Sep 2020 18:19:33 +0200, Krzysztof Kozlowski wrote: > The ADC in S5Pv210 does not have ADC phy registers in separate block for > which syscon would be needed. Remove this requirement to fix dtbs_check > warnings like: > > arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com> > > --- > > Changes since v1: > 1. Add Ack. > --- > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, Sep 15, 2020 at 01:44:44PM -0600, Rob Herring wrote: > On Thu, 10 Sep 2020 18:19:32 +0200, Krzysztof Kozlowski wrote: > > The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch > > screen. In such case the second interrupt is required. This second > > interrupt can be anyway provided, even without touch screens. This > > fixes dtbs_check warnings like: > > > > arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com> > > > > --- > > > > Changes since v1: > > 1. Fix if:has-touchscreen, as pointed by Rob. > > 2. Add Ack. > > --- > > .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Jonathan, Could you pick up these two? Best regards, Krzysztof
On Wed, 16 Sep 2020 08:17:47 +0200 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Tue, Sep 15, 2020 at 01:44:44PM -0600, Rob Herring wrote: > > On Thu, 10 Sep 2020 18:19:32 +0200, Krzysztof Kozlowski wrote: > > > The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch > > > screen. In such case the second interrupt is required. This second > > > interrupt can be anyway provided, even without touch screens. This > > > fixes dtbs_check warnings like: > > > > > > arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long > > > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > > Acked-by: Jonathan Cameron <Jonathan.Cameron@huwei.com> > > > > > > --- > > > > > > Changes since v1: > > > 1. Fix if:has-touchscreen, as pointed by Rob. > > > 2. Add Ack. > > > --- > > > .../bindings/iio/adc/samsung,exynos-adc.yaml | 14 +++++++++++++- > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Jonathan, > > Could you pick up these two? Done. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to possibly poke them. Thanks, Jonathan > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index cc3c8ea6a894..17a08be3fe85 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml @@ -41,7 +41,10 @@ properties: maxItems: 2 interrupts: - maxItems: 1 + description: + ADC interrupt followed by optional touchscreen interrupt. + minItems: 1 + maxItems: 2 "#io-channel-cells": const: 1 @@ -107,6 +110,15 @@ allOf: items: - const: adc + - if: + required: + - has-touchscreen + then: + properties: + interrupts: + minItems: 2 + maxItems: 2 + examples: - | adc: adc@12d10000 {