| Message ID | 20200830185356.5365-2-digetx@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce Embedded Controller driver for Acer A500 | expand |
On Sun, 30 Aug 2020 21:53:51 +0300, Dmitry Osipenko wrote: > Add binding document for the ENE KB930 Embedded Controller. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../devicetree/bindings/mfd/ene-kb930.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ene-kb930.example.dt.yaml: battery-cell: 'operating-range-celsius' does not match any of the regexes: '^ocv-capacity-table-[0-9]+$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/battery.yaml See https://patchwork.ozlabs.org/patch/1354004 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
03.09.2020 19:10, Rob Herring пишет: > On Sun, 30 Aug 2020 21:53:51 +0300, Dmitry Osipenko wrote: >> Add binding document for the ENE KB930 Embedded Controller. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> .../devicetree/bindings/mfd/ene-kb930.yaml | 66 +++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml >> > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ene-kb930.example.dt.yaml: battery-cell: 'operating-range-celsius' does not match any of the regexes: '^ocv-capacity-table-[0-9]+$', 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/battery.yaml > > > See https://patchwork.ozlabs.org/patch/1354004 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > Apparently bot uses outdated kernel.
04.09.2020 18:40, Rob Herring пишет: > On Fri, Sep 4, 2020 at 6:07 AM Dmitry Osipenko <digetx@gmail.com> wrote: >> >> 03.09.2020 19:10, Rob Herring пишет: >>> On Sun, 30 Aug 2020 21:53:51 +0300, Dmitry Osipenko wrote: >>>> Add binding document for the ENE KB930 Embedded Controller. >>>> >>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >>>> --- >>>> .../devicetree/bindings/mfd/ene-kb930.yaml | 66 +++++++++++++++++++ >>>> 1 file changed, 66 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml >>>> >>> >>> >>> My bot found errors running 'make dt_binding_check' on your patch: >>> >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ene-kb930.example.dt.yaml: battery-cell: 'operating-range-celsius' does not match any of the regexes: '^ocv-capacity-table-[0-9]+$', 'pinctrl-[0-9]+' >>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/supply/battery.yaml >>> >>> >>> See https://patchwork.ozlabs.org/patch/1354004 >>> >>> If you already ran 'make dt_binding_check' and didn't see the above >>> error(s), then make sure dt-schema is up to date: >>> >>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade >>> >>> Please check and re-submit. >>> >> >> Apparently bot uses outdated kernel. > > It's on v5.9-rc2. The scripts don't know your base/dependencies and > neither did I because you didn't mention anything here. I do review > the errors before spamming people. The patches are based on the linux-next, hence nothing special here. My expectation is that the bot should use the linux-next as well in order to prevent such warnings. Is there any reason to why bot not using linux-next?
diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml new file mode 100644 index 000000000000..635c8966ca22 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ene-kb930.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ENE KB930 Embedded Controller bindings + +description: | + This binding describes the ENE KB930 Embedded Controller attached to an + I2C bus. + +maintainers: + - Dmitry Osipenko <digetx@gmail.com> + +properties: + compatible: + items: + - enum: + - acer,a500-iconia-ec # Acer A500 Iconia tablet device + - enum: + - ene,kb930 + reg: + maxItems: 1 + + monitored-battery: true + power-supplies: true + system-power-controller: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + battery: battery-cell { + compatible = "simple-battery"; + charge-full-design-microamp-hours = <3260000>; + energy-full-design-microwatt-hours = <24000000>; + operating-range-celsius = <0 40>; + }; + + mains: ac-adapter { + compatible = "gpio-charger"; + charger-type = "mains"; + gpios = <&gpio 125 0>; + }; + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + embedded-controller@58 { + compatible = "acer,a500-iconia-ec", "ene,kb930"; + reg = <0x58>; + + system-power-controller; + + monitored-battery = <&battery>; + power-supplies = <&mains>; + }; + }; + +...
Add binding document for the ENE KB930 Embedded Controller. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../devicetree/bindings/mfd/ene-kb930.yaml | 66 +++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml