| Message ID | 20201011182254.17776-5-rayagonda.kokatanur@broadcom.com |
|---|---|
| State | Accepted |
| Commit | 514bfc64efa52848fa862010060af666f5e4a74c |
| Headers | show |
| Series | fix iproc driver to handle master read request | expand |
On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote: > Fix typo in bcm_iproc_i2c_slave_isr(). > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") This is merely a fix of typo in code comment and there's no functional impact. Why do we need a Fixes tag on this (which indicates the fix needs to be backported to LTS kernels)? > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > --- > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > index cd687696bf0b..7a235f9f5884 100644 > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, > if (status & BIT(IS_S_START_BUSY_SHIFT)) { > i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value); > /* > - * Enable interrupt for TX FIFO becomes empty and > + * Disable interrupt for TX FIFO becomes empty and > * less than PKT_LENGTH bytes were output on the SMBUS > */ > val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET); >
On Fri, Oct 23, 2020 at 10:51 PM Ray Jui <ray.jui@broadcom.com> wrote: > > > > On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote: > > Fix typo in bcm_iproc_i2c_slave_isr(). > > > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") > > This is merely a fix of typo in code comment and there's no functional > impact. Why do we need a Fixes tag on this (which indicates the fix > needs to be backported to LTS kernels)? Thank you Ray. I will remove Fixes tag and push patch v2. Best regards, Rayagonda > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> > > --- > > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > > index cd687696bf0b..7a235f9f5884 100644 > > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > > @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, > > if (status & BIT(IS_S_START_BUSY_SHIFT)) { > > i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value); > > /* > > - * Enable interrupt for TX FIFO becomes empty and > > + * Disable interrupt for TX FIFO becomes empty and > > * less than PKT_LENGTH bytes were output on the SMBUS > > */ > > val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET); > >
diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index cd687696bf0b..7a235f9f5884 100644 --- a/drivers/i2c/busses/i2c-bcm-iproc.c +++ b/drivers/i2c/busses/i2c-bcm-iproc.c @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, if (status & BIT(IS_S_START_BUSY_SHIFT)) { i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value); /* - * Enable interrupt for TX FIFO becomes empty and + * Disable interrupt for TX FIFO becomes empty and * less than PKT_LENGTH bytes were output on the SMBUS */ val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET);
Fix typo in bcm_iproc_i2c_slave_isr(). Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)