| Message ID | 1600851824-4608-1-git-send-email-ye.li@nxp.com |
|---|---|
| State | Accepted |
| Commit | e43c26e12dd49a41cf5a4cd5c5b59a1eb98ed11e |
| Headers | show |
| Series | gpio: pca953x: Fix uninitialized pending variable | expand |
On Wed, Sep 23, 2020 at 02:03:44AM -0700, Ye Li wrote: > When pca953x_irq_pending returns false, the pending parameter won't > be set. But pca953x_irq_handler continues using this uninitialized > variable as pending irqs and will cause problem. > Fix the issue by initializing pending to 0. Oops, seems you are right. Thanks! Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Fixes: 064c73afe738 ("gpio: pca953x: Synchronize interrupt handler properly") > Signed-off-by: Ye Li <ye.li@nxp.com> > --- > drivers/gpio/gpio-pca953x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index b5c3e566..0a49ab6 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -814,7 +814,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid) > { > struct pca953x_chip *chip = devid; > struct gpio_chip *gc = &chip->gpio_chip; > - DECLARE_BITMAP(pending, MAX_LINE); > + DECLARE_BITMAP(pending, MAX_LINE) = {}; > int level; > bool ret; > > -- > 2.7.4 >
On Wed, Sep 23, 2020 at 11:04 AM Ye Li <ye.li@nxp.com> wrote: > > When pca953x_irq_pending returns false, the pending parameter won't > be set. But pca953x_irq_handler continues using this uninitialized > variable as pending irqs and will cause problem. > Fix the issue by initializing pending to 0. > > Fixes: 064c73afe738 ("gpio: pca953x: Synchronize interrupt handler properly") > Signed-off-by: Ye Li <ye.li@nxp.com> > --- > drivers/gpio/gpio-pca953x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index b5c3e566..0a49ab6 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -814,7 +814,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid) > { > struct pca953x_chip *chip = devid; > struct gpio_chip *gc = &chip->gpio_chip; > - DECLARE_BITMAP(pending, MAX_LINE); > + DECLARE_BITMAP(pending, MAX_LINE) = {}; > int level; > bool ret; > > -- > 2.7.4 > Queued for fixes, thanks! Bartosz
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index b5c3e566..0a49ab6 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -814,7 +814,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid) { struct pca953x_chip *chip = devid; struct gpio_chip *gc = &chip->gpio_chip; - DECLARE_BITMAP(pending, MAX_LINE); + DECLARE_BITMAP(pending, MAX_LINE) = {}; int level; bool ret;
When pca953x_irq_pending returns false, the pending parameter won't be set. But pca953x_irq_handler continues using this uninitialized variable as pending irqs and will cause problem. Fix the issue by initializing pending to 0. Fixes: 064c73afe738 ("gpio: pca953x: Synchronize interrupt handler properly") Signed-off-by: Ye Li <ye.li@nxp.com> --- drivers/gpio/gpio-pca953x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)