| Message ID | 20200928023154.28031-1-f.fainelli@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: vlan: Fixed signedness in vlan_group_prealloc_vid() | expand |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Sun, 27 Sep 2020 19:31:50 -0700 > After commit d0186842ec5f ("net: vlan: Avoid using BUG() in > vlan_proto_idx()"), vlan_proto_idx() was changed to return a signed > integer, however one of its called: vlan_group_prealloc_vid() was still > using an unsigned integer for its return value, fix that. > > Fixes: d0186842ec5f ("net: vlan: Avoid using BUG() in vlan_proto_idx()") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Applied, thanks Florian.
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 6c08de1116c1..f292e0267bb9 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -51,8 +51,9 @@ static int vlan_group_prealloc_vid(struct vlan_group *vg, __be16 vlan_proto, u16 vlan_id) { struct net_device **array; - unsigned int pidx, vidx; + unsigned int vidx; unsigned int size; + int pidx; ASSERT_RTNL();
After commit d0186842ec5f ("net: vlan: Avoid using BUG() in vlan_proto_idx()"), vlan_proto_idx() was changed to return a signed integer, however one of its called: vlan_group_prealloc_vid() was still using an unsigned integer for its return value, fix that. Fixes: d0186842ec5f ("net: vlan: Avoid using BUG() in vlan_proto_idx()") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- net/8021q/vlan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)