| Message ID | 20201013160845.1772-2-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | fix all errors except one reported by dt_binding_check | expand |
Zhen On 10/13/20 11:08 AM, Zhen Lei wrote: > The color value of multi-led is fixed to "const: 8 #LED_COLOR_ID_MULTI", > which is required by leds-class-multicolor.yaml. > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > index 58e974793a7976b..cd877e817ad1a1c 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > @@ -197,7 +197,7 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > reg = <0x2>; > - color = <LED_COLOR_ID_RGB>; > + color = <LED_COLOR_ID_MULTI>; > function = LED_FUNCTION_STANDBY; > linux,default-trigger = "heartbeat"; > This is not correct. ID_RGB is the correct variable here. https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024 Correct fix is to update the leds-class-multicolor.yaml Dan
Hi! > > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml > > @@ -197,7 +197,7 @@ examples: > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <0x2>; > > - color = <LED_COLOR_ID_RGB>; > > + color = <LED_COLOR_ID_MULTI>; > > function = LED_FUNCTION_STANDBY; > > linux,default-trigger = "heartbeat"; > > This is not correct. ID_RGB is the correct variable here. > > https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024 > > Correct fix is to update the leds-class-multicolor.yaml Right. So lets not merge this one. Best regards, Pavel
On 2020/10/14 0:17, Dan Murphy wrote: > Zhen > > On 10/13/20 11:08 AM, Zhen Lei wrote: >> The color value of multi-led is fixed to "const: 8 #LED_COLOR_ID_MULTI", >> which is required by leds-class-multicolor.yaml. >> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >> --- >> Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml >> index 58e974793a7976b..cd877e817ad1a1c 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml >> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml >> @@ -197,7 +197,7 @@ examples: >> #address-cells = <1>; >> #size-cells = <0>; >> reg = <0x2>; >> - color = <LED_COLOR_ID_RGB>; >> + color = <LED_COLOR_ID_MULTI>; >> function = LED_FUNCTION_STANDBY; >> linux,default-trigger = "heartbeat"; >> > > This is not correct. ID_RGB is the correct variable here. > > https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024 > > Correct fix is to update the leds-class-multicolor.yaml OK > > Dan > > > . >
diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml index 58e974793a7976b..cd877e817ad1a1c 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml @@ -197,7 +197,7 @@ examples: #address-cells = <1>; #size-cells = <0>; reg = <0x2>; - color = <LED_COLOR_ID_RGB>; + color = <LED_COLOR_ID_MULTI>; function = LED_FUNCTION_STANDBY; linux,default-trigger = "heartbeat";
The color value of multi-led is fixed to "const: 8 #LED_COLOR_ID_MULTI", which is required by leds-class-multicolor.yaml. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)