| Message ID | cover.1601360391.git.mchehab+huawei@kernel.org |
|---|---|
| Headers | show |
| Series | Some small cleanup/fixes for SPMI driver | expand |
On 29/09/2020 08:22, Mauro Carvalho Chehab wrote: > @@ -487,7 +489,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl) > continue; > > sdev->dev.of_node = node; > - sdev->usid = (u8) reg[0]; > + sdev->usid = (u8)reg[0]; typeof(sdev->usid) is u8. What is the point of this cast? Does GCC warn that u32 is being truncated to u8? Regards.
Quoting Mauro Carvalho Chehab (2020-09-28 23:22:11) > Hi Stephen, > > While double-checking against yesterday's linux-next, I noticed > that those two patches weren't merge yet. > > As you replied to both with your Reviewed-by:, are you expecting > them to be merged via someone's tree, or are you intending > to merge them via your tree? Per the maintainers file I am a reviewer not a maintainer of SPMI. Usually Greg applies patches here. I can collect patches and send them on up if that helps.
On Fri, Oct 02, 2020 at 02:22:17PM -0700, Stephen Boyd wrote: > Quoting Mauro Carvalho Chehab (2020-09-28 23:22:11) > > Hi Stephen, > > > > While double-checking against yesterday's linux-next, I noticed > > that those two patches weren't merge yet. > > > > As you replied to both with your Reviewed-by:, are you expecting > > them to be merged via someone's tree, or are you intending > > to merge them via your tree? > > Per the maintainers file I am a reviewer not a maintainer of SPMI. > Usually Greg applies patches here. I can collect patches and send them > on up if that helps. Who is the maintainer? Having a "reviewer only" is confusing to everyone involved, as you might have someone who can review patches, but no one to actually merge them anywhere? Not a good situation :( greg k-h
Quoting Greg Kroah-Hartman (2020-10-03 03:56:53) > On Fri, Oct 02, 2020 at 02:22:17PM -0700, Stephen Boyd wrote: > > Quoting Mauro Carvalho Chehab (2020-09-28 23:22:11) > > > Hi Stephen, > > > > > > While double-checking against yesterday's linux-next, I noticed > > > that those two patches weren't merge yet. > > > > > > As you replied to both with your Reviewed-by:, are you expecting > > > them to be merged via someone's tree, or are you intending > > > to merge them via your tree? > > > > Per the maintainers file I am a reviewer not a maintainer of SPMI. > > Usually Greg applies patches here. I can collect patches and send them > > on up if that helps. > > Who is the maintainer? Having a "reviewer only" is confusing to > everyone involved, as you might have someone who can review patches, but > no one to actually merge them anywhere? > > Not a good situation :( > Ok. I can spin up an SPMI tree on kernel.org and make this change to the MAINTAINERS file (plus whatever tree path I can make). Do you want me to send you patches in email form as a pull request? I imagine the patch load will be fairly low. ----8<----- diff --git a/MAINTAINERS b/MAINTAINERS index deaafb617361..3e09630455d4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16338,7 +16338,7 @@ F: Documentation/networking/device_drivers/ethernet/toshiba/spider_net.rst F: drivers/net/ethernet/toshiba/spider_net* SPMI SUBSYSTEM -R: Stephen Boyd <sboyd@kernel.org> +M: Stephen Boyd <sboyd@kernel.org> L: linux-arm-msm@vger.kernel.org F: Documentation/devicetree/bindings/spmi/ F: drivers/spmi/
On Wed, Oct 14, 2020 at 02:26:36PM -0700, Stephen Boyd wrote: > Quoting Greg Kroah-Hartman (2020-10-03 03:56:53) > > On Fri, Oct 02, 2020 at 02:22:17PM -0700, Stephen Boyd wrote: > > > Quoting Mauro Carvalho Chehab (2020-09-28 23:22:11) > > > > Hi Stephen, > > > > > > > > While double-checking against yesterday's linux-next, I noticed > > > > that those two patches weren't merge yet. > > > > > > > > As you replied to both with your Reviewed-by:, are you expecting > > > > them to be merged via someone's tree, or are you intending > > > > to merge them via your tree? > > > > > > Per the maintainers file I am a reviewer not a maintainer of SPMI. > > > Usually Greg applies patches here. I can collect patches and send them > > > on up if that helps. > > > > Who is the maintainer? Having a "reviewer only" is confusing to > > everyone involved, as you might have someone who can review patches, but > > no one to actually merge them anywhere? > > > > Not a good situation :( > > > > Ok. I can spin up an SPMI tree on kernel.org and make this change to the > MAINTAINERS file (plus whatever tree path I can make). Do you want me to > send you patches in email form as a pull request? I imagine the patch > load will be fairly low. email form is great, I can handle those easily. IF you really want to create a git tree, I can pull from that too, but for low-volume stuff, it's usually not worth it. thanks, greg k-h
Hello: This series was applied to qcom/linux.git (refs/heads/for-next): On Tue, 29 Sep 2020 08:22:11 +0200 you wrote: > Hi Stephen, > > While double-checking against yesterday's linux-next, I noticed > that those two patches weren't merge yet. > > As you replied to both with your Reviewed-by:, are you expecting > them to be merged via someone's tree, or are you intending > to merge them via your tree? > > [...] Here is the summary with links: - [v2,1/2] spmi: get rid of a warning when built with W=1 https://git.kernel.org/qcom/c/b1f0aeecd25a - [v2,2/2] spmi: fix some coding style issues at the spmi core https://git.kernel.org/qcom/c/0be0a733c9cd You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html