Message ID | 20201008122633.687877-12-tommi.t.rantala@nokia.com |
---|---|
State | Accepted |
Commit | 1d44d0dd61b6121b49f25b731f2f7f605cb3c896 |
Headers | show |
Series | selftests fixes | expand |
On Thu, Oct 08, 2020 at 03:26:31PM +0300, Tommi Rantala wrote: > XFAIL is gone since 9847d24af95c ("selftests/harness: Refactor XFAIL > into SKIP"), use SKIP instead. > > Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") > Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com> Reviewed-by: Kees Cook <keescook@chromium.org>
On Thu, Oct 08, 2020 at 03:26:31PM +0300, Tommi Rantala wrote: > XFAIL is gone since 9847d24af95c ("selftests/harness: Refactor XFAIL > into SKIP"), use SKIP instead. > > Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") > Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com> > --- Thanks! Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c index c99b98b0d461..575b391ddc78 100644 --- a/tools/testing/selftests/core/close_range_test.c +++ b/tools/testing/selftests/core/close_range_test.c @@ -44,7 +44,7 @@ TEST(close_range) fd = open("/dev/null", O_RDONLY | O_CLOEXEC); ASSERT_GE(fd, 0) { if (errno == ENOENT) - XFAIL(return, "Skipping test since /dev/null does not exist"); + SKIP(return, "Skipping test since /dev/null does not exist"); } open_fds[i] = fd; @@ -52,7 +52,7 @@ TEST(close_range) EXPECT_EQ(-1, sys_close_range(open_fds[0], open_fds[100], -1)) { if (errno == ENOSYS) - XFAIL(return, "close_range() syscall not supported"); + SKIP(return, "close_range() syscall not supported"); } EXPECT_EQ(0, sys_close_range(open_fds[0], open_fds[50], 0)); @@ -108,7 +108,7 @@ TEST(close_range_unshare) fd = open("/dev/null", O_RDONLY | O_CLOEXEC); ASSERT_GE(fd, 0) { if (errno == ENOENT) - XFAIL(return, "Skipping test since /dev/null does not exist"); + SKIP(return, "Skipping test since /dev/null does not exist"); } open_fds[i] = fd; @@ -197,7 +197,7 @@ TEST(close_range_unshare_capped) fd = open("/dev/null", O_RDONLY | O_CLOEXEC); ASSERT_GE(fd, 0) { if (errno == ENOENT) - XFAIL(return, "Skipping test since /dev/null does not exist"); + SKIP(return, "Skipping test since /dev/null does not exist"); } open_fds[i] = fd;
XFAIL is gone since 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP"), use SKIP instead. Fixes: 9847d24af95c ("selftests/harness: Refactor XFAIL into SKIP") Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com> --- tools/testing/selftests/core/close_range_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)