| Message ID | 20201005203451.9985-3-post@lespocky.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: pwm: Make automatic labels work | expand |
On Mon 2020-10-05 22:34:41, Alexander Dahl wrote: > The example was adapted in the following ways: > > - make use of the now supported 'function' and 'color' properties > - remove pwm nodes, those are documented elsewhere > - align node names to new dt schema rules and dt recommendations > > License was not explicitly set before. The license set now is > recommended by DT project. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Alexander Dahl <post@lespocky.de> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > Cc: Russell King <linux@armlinux.org.uk> > --- > > Notes: > NOTE: Due to license set/change this needs Acked-by or Signed-off-by from: > * Peter Ujfalusi > * Russell King Russell King authored two lines of the documentation. He can state objections now, but I'll not wait for his Acked-by. > That was discussed already with Peter (original author), still waiting > for Acked-by though … If Peter was okay with license change, I guess we can continue here. Best regards, Pavel
On Wed, 7 Oct 2020 at 12:02, Pavel Machek <pavel@ucw.cz> wrote: > > On Mon 2020-10-05 22:34:41, Alexander Dahl wrote: > > The example was adapted in the following ways: > > > > - make use of the now supported 'function' and 'color' properties > > - remove pwm nodes, those are documented elsewhere > > - align node names to new dt schema rules and dt recommendations > > > > License was not explicitly set before. The license set now is > > recommended by DT project. > > > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Signed-off-by: Alexander Dahl <post@lespocky.de> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Cc: Russell King <linux@armlinux.org.uk> > > --- > > > > Notes: > > NOTE: Due to license set/change this needs Acked-by or Signed-off-by from: > > * Peter Ujfalusi > > * Russell King > > Russell King authored two lines of the documentation. He can state > objections now, but I'll not wait for his Acked-by. > > > That was discussed already with Peter (original author), still waiting > > for Acked-by though … > > If Peter was okay with license change, I guess we can continue here. Having an Ack is not too much to ask to relicense the copyrights. Best regards, Krzysztof
Hello, Peter, Russel, could you please give your Acked-by or Signed-off-by on this patch? Your ack is needed, because the license is now explicitly set (it was not explicit before), and you were the contributors to this binding before the conversion to yaml. Thanks and Greets Alex On Mon, Oct 05, 2020 at 10:34:41PM +0200, Alexander Dahl wrote: > The example was adapted in the following ways: > > - make use of the now supported 'function' and 'color' properties > - remove pwm nodes, those are documented elsewhere > - align node names to new dt schema rules and dt recommendations > > License was not explicitly set before. The license set now is > recommended by DT project. > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Alexander Dahl <post@lespocky.de> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > Cc: Russell King <linux@armlinux.org.uk> > --- > > Notes: > NOTE: Due to license set/change this needs Acked-by or Signed-off-by from: > * Peter Ujfalusi > * Russell King > > That was discussed already with Peter (original author), still waiting > for Acked-by though … > > Changelog > --------- > v6 -> v7: > * added Reviewed-by (Krzysztof Kozlowski) > * reworded commit message (suggested by Krzysztof) > * added Reviewed-by (Rob Herring) > > v5 -> v6: > * removed pwm nodes from example (Rob) > * renamed led-controller node in example (Rob) > > v4 -> v5: > * updated based on feedback by Rob Herring > * removed Acked-by > > v3 -> v4: > * added Cc to original author of the binding > > v2 -> v3: > * changed license identifier to recommended one > * added Acked-by > > v2: > * added this patch to series (Suggested-by: Jacek Anaszewski) > > .../devicetree/bindings/leds/leds-pwm.txt | 50 ------------- > .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 50 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt > create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt > deleted file mode 100644 > index 6c6583c35f2f..000000000000 > --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -LED connected to PWM > - > -Required properties: > -- compatible : should be "pwm-leds". > - > -Each LED is represented as a sub-node of the pwm-leds device. Each > -node's name represents the name of the corresponding LED. > - > -LED sub-node properties: > -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to > - specify the period time to be used: <&phandle id period_ns>; > -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device > - For the pwms and pwm-names property please refer to: > - Documentation/devicetree/bindings/pwm/pwm.txt > -- max-brightness : Maximum brightness possible for the LED > -- active-low : (optional) For PWMs where the LED is wired to supply > - rather than ground. > -- label : (optional) > - see Documentation/devicetree/bindings/leds/common.txt > -- linux,default-trigger : (optional) > - see Documentation/devicetree/bindings/leds/common.txt > - > -Example: > - > -twl_pwm: pwm { > - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */ > - compatible = "ti,twl6030-pwm"; > - #pwm-cells = <2>; > -}; > - > -twl_pwmled: pwmled { > - /* provides one PWM (id 0 for Charing indicator LED) */ > - compatible = "ti,twl6030-pwmled"; > - #pwm-cells = <2>; > -}; > - > -pwmleds { > - compatible = "pwm-leds"; > - kpad { > - label = "omap4::keypad"; > - pwms = <&twl_pwm 0 7812500>; > - max-brightness = <127>; > - }; > - > - charging { > - label = "omap4:green:chrg"; > - pwms = <&twl_pwmled 0 7812500>; > - max-brightness = <255>; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml > new file mode 100644 > index 000000000000..fe4d5fd25913 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LEDs connected to PWM > + > +maintainers: > + - Pavel Machek <pavel@ucw.cz> > + > +description: > + Each LED is represented as a sub-node of the pwm-leds device. Each > + node's name represents the name of the corresponding LED. > + > +properties: > + compatible: > + const: pwm-leds > + > +patternProperties: > + "^led(-[0-9a-f]+)?$": > + type: object > + > + $ref: common.yaml# > + > + properties: > + pwms: > + maxItems: 1 > + > + pwm-names: true > + > + max-brightness: > + description: > + Maximum brightness possible for the LED > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + active-low: > + description: > + For PWMs where the LED is wired to supply rather than ground. > + type: boolean > + > + required: > + - pwms > + - max-brightness > + > +additionalProperties: false > + > +examples: > + - | > + > + #include <dt-bindings/leds/common.h> > + > + led-controller { > + compatible = "pwm-leds"; > + > + led-1 { > + label = "omap4::keypad"; > + pwms = <&twl_pwm 0 7812500>; > + max-brightness = <127>; > + }; > + > + led-2 { > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_CHARGING; > + pwms = <&twl_pwmled 0 7812500>; > + max-brightness = <255>; > + }; > + }; > + > +... > -- > 2.20.1
On Wed, Oct 28, 2020 at 09:39:54PM +0100, Alexander Dahl wrote: > Hello, > > Peter, Russel, could you please give your Acked-by or Signed-off-by on > this patch? Your ack is needed, because the license is now explicitly > set (it was not explicit before), and you were the contributors to > this binding before the conversion to yaml. For the license change only: Acked-by: Russell King <rmk+kernel@armlinux.org.uk> (Please drop the Cc attributation in the commit to linux@armlinux.org.uk thanks.) > > Thanks and Greets > Alex > > On Mon, Oct 05, 2020 at 10:34:41PM +0200, Alexander Dahl wrote: > > The example was adapted in the following ways: > > > > - make use of the now supported 'function' and 'color' properties > > - remove pwm nodes, those are documented elsewhere > > - align node names to new dt schema rules and dt recommendations > > > > License was not explicitly set before. The license set now is > > recommended by DT project. > > > > Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Signed-off-by: Alexander Dahl <post@lespocky.de> > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Cc: Russell King <linux@armlinux.org.uk> > > --- > > > > Notes: > > NOTE: Due to license set/change this needs Acked-by or Signed-off-by from: > > * Peter Ujfalusi > > * Russell King > > > > That was discussed already with Peter (original author), still waiting > > for Acked-by though … > > > > Changelog > > --------- > > v6 -> v7: > > * added Reviewed-by (Krzysztof Kozlowski) > > * reworded commit message (suggested by Krzysztof) > > * added Reviewed-by (Rob Herring) > > > > v5 -> v6: > > * removed pwm nodes from example (Rob) > > * renamed led-controller node in example (Rob) > > > > v4 -> v5: > > * updated based on feedback by Rob Herring > > * removed Acked-by > > > > v3 -> v4: > > * added Cc to original author of the binding > > > > v2 -> v3: > > * changed license identifier to recommended one > > * added Acked-by > > > > v2: > > * added this patch to series (Suggested-by: Jacek Anaszewski) > > > > .../devicetree/bindings/leds/leds-pwm.txt | 50 ------------- > > .../devicetree/bindings/leds/leds-pwm.yaml | 70 +++++++++++++++++++ > > 2 files changed, 70 insertions(+), 50 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.txt > > create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm.yaml > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt > > deleted file mode 100644 > > index 6c6583c35f2f..000000000000 > > --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt > > +++ /dev/null > > @@ -1,50 +0,0 @@ > > -LED connected to PWM > > - > > -Required properties: > > -- compatible : should be "pwm-leds". > > - > > -Each LED is represented as a sub-node of the pwm-leds device. Each > > -node's name represents the name of the corresponding LED. > > - > > -LED sub-node properties: > > -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to > > - specify the period time to be used: <&phandle id period_ns>; > > -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device > > - For the pwms and pwm-names property please refer to: > > - Documentation/devicetree/bindings/pwm/pwm.txt > > -- max-brightness : Maximum brightness possible for the LED > > -- active-low : (optional) For PWMs where the LED is wired to supply > > - rather than ground. > > -- label : (optional) > > - see Documentation/devicetree/bindings/leds/common.txt > > -- linux,default-trigger : (optional) > > - see Documentation/devicetree/bindings/leds/common.txt > > - > > -Example: > > - > > -twl_pwm: pwm { > > - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */ > > - compatible = "ti,twl6030-pwm"; > > - #pwm-cells = <2>; > > -}; > > - > > -twl_pwmled: pwmled { > > - /* provides one PWM (id 0 for Charing indicator LED) */ > > - compatible = "ti,twl6030-pwmled"; > > - #pwm-cells = <2>; > > -}; > > - > > -pwmleds { > > - compatible = "pwm-leds"; > > - kpad { > > - label = "omap4::keypad"; > > - pwms = <&twl_pwm 0 7812500>; > > - max-brightness = <127>; > > - }; > > - > > - charging { > > - label = "omap4:green:chrg"; > > - pwms = <&twl_pwmled 0 7812500>; > > - max-brightness = <255>; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml > > new file mode 100644 > > index 000000000000..fe4d5fd25913 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml > > @@ -0,0 +1,70 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LEDs connected to PWM > > + > > +maintainers: > > + - Pavel Machek <pavel@ucw.cz> > > + > > +description: > > + Each LED is represented as a sub-node of the pwm-leds device. Each > > + node's name represents the name of the corresponding LED. > > + > > +properties: > > + compatible: > > + const: pwm-leds > > + > > +patternProperties: > > + "^led(-[0-9a-f]+)?$": > > + type: object > > + > > + $ref: common.yaml# > > + > > + properties: > > + pwms: > > + maxItems: 1 > > + > > + pwm-names: true > > + > > + max-brightness: > > + description: > > + Maximum brightness possible for the LED > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > + active-low: > > + description: > > + For PWMs where the LED is wired to supply rather than ground. > > + type: boolean > > + > > + required: > > + - pwms > > + - max-brightness > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + > > + #include <dt-bindings/leds/common.h> > > + > > + led-controller { > > + compatible = "pwm-leds"; > > + > > + led-1 { > > + label = "omap4::keypad"; > > + pwms = <&twl_pwm 0 7812500>; > > + max-brightness = <127>; > > + }; > > + > > + led-2 { > > + color = <LED_COLOR_ID_GREEN>; > > + function = LED_FUNCTION_CHARGING; > > + pwms = <&twl_pwmled 0 7812500>; > > + max-brightness = <255>; > > + }; > > + }; > > + > > +... > > -- > > 2.20.1 > > -- > /"\ ASCII RIBBON | »With the first link, the chain is forged. The first > \ / CAMPAIGN | speech censured, the first thought forbidden, the > X AGAINST | first freedom denied, chains us all irrevocably.« > / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
On Mon 2020-10-05 22:34:41, Alexander Dahl wrote: > The example was adapted in the following ways: > > - make use of the now supported 'function' and 'color' properties > - remove pwm nodes, those are documented elsewhere > - align node names to new dt schema rules and dt recommendations > > License was not explicitly set before. The license set now is > recommended by DT project. Thanks, applied.
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.txt b/Documentation/devicetree/bindings/leds/leds-pwm.txt deleted file mode 100644 index 6c6583c35f2f..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-pwm.txt +++ /dev/null @@ -1,50 +0,0 @@ -LED connected to PWM - -Required properties: -- compatible : should be "pwm-leds". - -Each LED is represented as a sub-node of the pwm-leds device. Each -node's name represents the name of the corresponding LED. - -LED sub-node properties: -- pwms : PWM property to point to the PWM device (phandle)/port (id) and to - specify the period time to be used: <&phandle id period_ns>; -- pwm-names : (optional) Name to be used by the PWM subsystem for the PWM device - For the pwms and pwm-names property please refer to: - Documentation/devicetree/bindings/pwm/pwm.txt -- max-brightness : Maximum brightness possible for the LED -- active-low : (optional) For PWMs where the LED is wired to supply - rather than ground. -- label : (optional) - see Documentation/devicetree/bindings/leds/common.txt -- linux,default-trigger : (optional) - see Documentation/devicetree/bindings/leds/common.txt - -Example: - -twl_pwm: pwm { - /* provides two PWMs (id 0, 1 for PWM1 and PWM2) */ - compatible = "ti,twl6030-pwm"; - #pwm-cells = <2>; -}; - -twl_pwmled: pwmled { - /* provides one PWM (id 0 for Charing indicator LED) */ - compatible = "ti,twl6030-pwmled"; - #pwm-cells = <2>; -}; - -pwmleds { - compatible = "pwm-leds"; - kpad { - label = "omap4::keypad"; - pwms = <&twl_pwm 0 7812500>; - max-brightness = <127>; - }; - - charging { - label = "omap4:green:chrg"; - pwms = <&twl_pwmled 0 7812500>; - max-brightness = <255>; - }; -}; diff --git a/Documentation/devicetree/bindings/leds/leds-pwm.yaml b/Documentation/devicetree/bindings/leds/leds-pwm.yaml new file mode 100644 index 000000000000..fe4d5fd25913 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-pwm.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LEDs connected to PWM + +maintainers: + - Pavel Machek <pavel@ucw.cz> + +description: + Each LED is represented as a sub-node of the pwm-leds device. Each + node's name represents the name of the corresponding LED. + +properties: + compatible: + const: pwm-leds + +patternProperties: + "^led(-[0-9a-f]+)?$": + type: object + + $ref: common.yaml# + + properties: + pwms: + maxItems: 1 + + pwm-names: true + + max-brightness: + description: + Maximum brightness possible for the LED + $ref: /schemas/types.yaml#/definitions/uint32 + + active-low: + description: + For PWMs where the LED is wired to supply rather than ground. + type: boolean + + required: + - pwms + - max-brightness + +additionalProperties: false + +examples: + - | + + #include <dt-bindings/leds/common.h> + + led-controller { + compatible = "pwm-leds"; + + led-1 { + label = "omap4::keypad"; + pwms = <&twl_pwm 0 7812500>; + max-brightness = <127>; + }; + + led-2 { + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_CHARGING; + pwms = <&twl_pwmled 0 7812500>; + max-brightness = <255>; + }; + }; + +...