diff mbox series

drm/msm/dp: fix incorrect function prototype of dp_debug_get()

Message ID 20200923232448.24516-1-abhinavk@codeaurora.org
State Superseded
Headers show
Series drm/msm/dp: fix incorrect function prototype of dp_debug_get() | expand

Commit Message

Abhinav Kumar Sept. 23, 2020, 11:24 p.m. UTC 
Fix the incorrect function prototype for dp_debug_get()
in the dp_debug module to address compilation warning.

Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
---
 drivers/gpu/drm/msm/dp/dp_debug.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Sept. 24, 2020, 6:32 a.m. UTC | #1 
Quoting Abhinav Kumar (2020-09-23 16:24:48)
> Fix the incorrect function prototype for dp_debug_get()
> in the dp_debug module to address compilation warning.
> 
> Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Will the compliance testing parts be moved out of debugfs at some point?
Just curious what the plan is there.
Abhinav Kumar Sept. 24, 2020, 6:06 p.m. UTC | #2 
Hi Stephen

Thanks for the review.

On 2020-09-23 23:32, Stephen Boyd wrote:
> Quoting Abhinav Kumar (2020-09-23 16:24:48)
>> Fix the incorrect function prototype for dp_debug_get()
>> in the dp_debug module to address compilation warning.
>> 
>> Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to 
>> /sys/kernel/debug/dri/*/")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
>> ---
> 
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> 
> Will the compliance testing parts be moved out of debugfs at some 
> point?
> Just curious what the plan is there.

No, the video pattern compliance testing parts will remain in debugfs as 
they use
IGT as the userspace entity which is debugfs based for DP compliance 
tests.

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_debug.h b/drivers/gpu/drm/msm/dp/dp_debug.h
index 377e166fd0ea..7eaedfbb149c 100644
--- a/drivers/gpu/drm/msm/dp/dp_debug.h
+++ b/drivers/gpu/drm/msm/dp/dp_debug.h
@@ -60,7 +60,7 @@  void dp_debug_put(struct dp_debug *dp_debug);
 static inline
 struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
 		struct dp_usbpd *usbpd, struct dp_link *link,
-		struct drm_connector **connector)
+		struct drm_connector **connector, struct drm_minor *minor)
 {
 	return ERR_PTR(-EINVAL);
 }