| Message ID | 20200907135740.19941-1-heikki.krogerus@linux.intel.com |
|---|---|
| Headers | show |
| Series | Fixes for the Intel PMC mux driver | expand |
On Mon, Sep 07, 2020 at 04:57:40PM +0300, Heikki Krogerus wrote: > From: Utkarsh Patel <utkarsh.h.patel@intel.com> > > According to the PMC Type C Subsystem (TCSS) Mux programming guide rev > 0.7, bits 4 and 5 are reserved in Alternate modes. > SBU Orientation and HSL Orientation needs to be configured only during > initial cable detection in USB connect flow based on device property of > "sbu-orientation" and "hsl-orientation". > Configuring these reserved bits in the Alternate modes may result in delay > in display link training or some unexpected behaviour. > So do not configure them while issuing Alternate Mode requests. > > Fixes: ff4a30d5e243 ("usb: typec: mux: intel_pmc_mux: Support for static SBU/HSL orientation") > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Shouldn't this also need a cc:stable? And why not cc: the linux-usb list on these patches? thanks, greg k-h
On Mon, Sep 07, 2020 at 04:57:38PM +0300, Heikki Krogerus wrote: > Hi, > > Here are two of fixes from Utkarsh. Both deal with alternate mode > issues. Let me know if you want anything to be changed. > > thanks, > > Utkarsh Patel (2): > usb: typec: intel_pmc_mux: Do not configure Altmode HPD High > usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in > Alternate modes > > drivers/usb/typec/mux/intel_pmc_mux.c | 12 ------------ > 1 file changed, 12 deletions(-) Wrong mailing list :-/ I'll resend these to the correct usb mailing list.
Hi, Here are two of fixes from Utkarsh. Both deal with alternate mode issues. Let me know if you want anything to be changed. thanks, Utkarsh Patel (2): usb: typec: intel_pmc_mux: Do not configure Altmode HPD High usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in Alternate modes drivers/usb/typec/mux/intel_pmc_mux.c | 12 ------------ 1 file changed, 12 deletions(-)