Message ID | 1601267524-20199-1-git-send-email-mkshah@codeaurora.org |
---|---|
Headers | show |
Series | irqchip: qcom: pdc: Introduce irq_set_wake call | expand |
Hi, On Sun, Sep 27, 2020 at 9:32 PM Maulik Shah <mkshah@codeaurora.org> wrote: > > An interrupt that is disabled/masked but set for wakeup still needs to > be able to wake up the system from sleep states like "suspend to RAM". > > This change introduces IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag. If irqchip > have this flag set then irq PM will enable/unmask irqs that are marked > for wakeup but are in disabled state. > > On resume such irqs will be restored back to disabled state. > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > --- > include/linux/irq.h | 49 ++++++++++++++++++++++++++++++------------------- > kernel/irq/debugfs.c | 3 +++ > kernel/irq/pm.c | 34 ++++++++++++++++++++++++++++++---- > 3 files changed, 63 insertions(+), 23 deletions(-) I will freely admit not being an expert on this code / knowing all the subtle edge conditions, but this seems reasonable to me. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, Sep 28 2020 at 10:02, Maulik Shah wrote: > An interrupt that is disabled/masked but set for wakeup still needs to > be able to wake up the system from sleep states like "suspend to RAM". > > This change introduces IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag. If > irqchip s/This change introduces/Introduce/ git grep 'This patch' Documentation/process/ > have this flag set then irq PM will enable/unmask irqs that are marked > for wakeup but are in disabled state. > > On resume such irqs will be restored back to disabled state. > > Suggested-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> I assume Marc will pick that lot up. So: Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Quoting Maulik Shah (2020-09-27 21:31:58) > Changes in v6: > - Update commit message more descriptive in v5 patch 1 > - Symmetrically enable/disable wakeirqs during suspend/resume in v5 patch 3 > - Include Acked-by and Reviewed-by tags from v5 series > Thanks. I tested this series and it is working for me. Tested-by: Stephen Boyd <swboyd@chromium.org>
On Mon, 28 Sep 2020 10:01:58 +0530, Maulik Shah wrote: > Changes in v6: > - Update commit message more descriptive in v5 patch 1 > - Symmetrically enable/disable wakeirqs during suspend/resume in v5 patch 3 > - Include Acked-by and Reviewed-by tags from v5 series > > Changes in v5: > - Update commit subject in v4 patch 1 > - Add more details to commit message in v4 patch 2 > - Add change to enable wake irqs during suspend using new flag in irqchip > - Use this in PDC and qcom pinctrl driver to enable wakeirqs on suspend > - Make for loop more readable and add more details in commit in v4 patch 7 > > [...] Applied to irq/irqchip-next, thanks! [1/6] pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags commit: c5f72aeb659eb2f809b9531d759651514d42aa3a [2/6] pinctrl: qcom: Use return value from irq_set_wake() call commit: f41aaca593377a4fe3984459fd4539481263b4cd [3/6] genirq/PM: Introduce IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag commit: 90428a8eb4947f9c7c905a178f3520dc7e2ee6d2 [4/6] pinctrl: qcom: Set IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag commit: dd87bd09822c294a3c7c4daf11f11a9f81222f80 [5/6] irqchip/qcom-pdc: Set IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag commit: 299d7890792e75065b906f83fcb0ca92e5c8c072 [6/6] irqchip/qcom-pdc: Reset PDC interrupts during init commit: d7bc63fa20b8a3b0d0645bed1887848c65c01529 Cheers, M.