mbox series

[0/2] add support for Hisilicon SD5203 vector interrupt controller

Message ID 20200903120504.2308-1-thunder.leizhen@huawei.com
Headers show
Series add support for Hisilicon SD5203 vector interrupt controller | expand

Message

Leizhen (ThunderTown) Sept. 3, 2020, 12:05 p.m. UTC
The interrupt controller of SD5203 SoC is VIC(vector interrupt controller), it's
based on Synopsys DesignWare APB interrupt controller (dw_apb_ictl) IP, but it
can not directly use dw_apb_ictl driver. The main reason is that VIC is used as
primary interrupt controller and dw_apb_ictl driver worked for secondary
interrupt controller. So add a new driver: "hisilicon,sd5203-vic".

Kefeng Wang (1):
  irqchip: add Hisilicon SD5203 vector interrupt controller

Zhen Lei (1):
  dt-bindings: interrupt-controller: add Hisilicon SD5203 vector
    interrupt controller

 .../hisilicon,sd5203-vic.txt                  |  27 ++++
 drivers/irqchip/Kconfig                       |   5 +
 drivers/irqchip/Makefile                      |   1 +
 drivers/irqchip/irq-sd5203-vic.c              | 128 ++++++++++++++++++
 4 files changed, 161 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/hisilicon,sd5203-vic.txt
 create mode 100644 drivers/irqchip/irq-sd5203-vic.c

-- 
2.26.0.106.g9fadedd

Comments

Marc Zyngier Sept. 3, 2020, 4:46 p.m. UTC | #1
On 2020-09-03 13:05, Zhen Lei wrote:
> The interrupt controller of SD5203 SoC is VIC(vector interrupt 

> controller), it's

> based on Synopsys DesignWare APB interrupt controller (dw_apb_ictl) IP, 

> but it

> can not directly use dw_apb_ictl driver. The main reason is that VIC is 

> used as

> primary interrupt controller and dw_apb_ictl driver worked for 

> secondary

> interrupt controller.


What prevents you from improving the existing driver so that it can act
as a primary interrupt controller? It shouldn't be rocket science, 
really.

There are some examples in the tree of drivers that can be used in
both situations (GIC, VIC

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...
Leizhen (ThunderTown) Sept. 4, 2020, 4:57 a.m. UTC | #2
On 2020/9/4 0:46, Marc Zyngier wrote:
> On 2020-09-03 13:05, Zhen Lei wrote:

>> The interrupt controller of SD5203 SoC is VIC(vector interrupt controller), it's

>> based on Synopsys DesignWare APB interrupt controller (dw_apb_ictl) IP, but it

>> can not directly use dw_apb_ictl driver. The main reason is that VIC is used as

>> primary interrupt controller and dw_apb_ictl driver worked for secondary

>> interrupt controller.

> 

> What prevents you from improving the existing driver so that it can act

> as a primary interrupt controller? It shouldn't be rocket science, really.

> 

> There are some examples in the tree of drivers that can be used in

> both situations (GIC, VIC


OK, thanks for the tip.

> 

> Thanks,

> 

>         M.