| Message ID | 20200707122153.9624-1-patrick.delaunay@st.com |
|---|---|
| State | Accepted |
| Commit | 346034a7a830d974530b94df8cb7d63011955785 |
| Headers | show |
| Series | arm: stm32mp: use correct weak function name spl_board_prepare_for_linux | expand |
On 7/7/20 2:21 PM, Patrick Delaunay wrote: > Replace the function spl_board_prepare_for_boot_linux by the correct > name of the weak function spl_board_prepare_for_linux defined in spl.h. > > This patch avoids warning with W=1 option: > > u-boot/arch/arm/mach-stm32mp/spl.c:150:6: > warning: no previous prototype for ‘spl_board_prepare_for_boot_linux’ > [-Wmissing-prototypes] > > Fixes: dc7e5f190de5 ("arm: stm32mp: activate data cache on DDR in SPL") > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > arch/arm/mach-stm32mp/spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-stm32mp/spl.c b/arch/arm/mach-stm32mp/spl.c > index 39413e9a0e..e84bdad7bf 100644 > --- a/arch/arm/mach-stm32mp/spl.c > +++ b/arch/arm/mach-stm32mp/spl.c > @@ -147,7 +147,7 @@ void spl_board_prepare_for_boot(void) > dcache_disable(); > } > > -void spl_board_prepare_for_boot_linux(void) > +void spl_board_prepare_for_linux(void) > { > dcache_disable(); > } Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks Patrice
On 7/28/20 4:10 PM, Patrice CHOTARD wrote: > On 7/7/20 2:21 PM, Patrick Delaunay wrote: >> Replace the function spl_board_prepare_for_boot_linux by the correct >> name of the weak function spl_board_prepare_for_linux defined in spl.h. >> >> This patch avoids warning with W=1 option: >> >> u-boot/arch/arm/mach-stm32mp/spl.c:150:6: >> warning: no previous prototype for ‘spl_board_prepare_for_boot_linux’ >> [-Wmissing-prototypes] >> >> Fixes: dc7e5f190de5 ("arm: stm32mp: activate data cache on DDR in SPL") >> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> >> --- >> >> arch/arm/mach-stm32mp/spl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-stm32mp/spl.c b/arch/arm/mach-stm32mp/spl.c >> index 39413e9a0e..e84bdad7bf 100644 >> --- a/arch/arm/mach-stm32mp/spl.c >> +++ b/arch/arm/mach-stm32mp/spl.c >> @@ -147,7 +147,7 @@ void spl_board_prepare_for_boot(void) >> dcache_disable(); >> } >> >> -void spl_board_prepare_for_boot_linux(void) >> +void spl_board_prepare_for_linux(void) >> { >> dcache_disable(); >> } > Reviewed-by: Patrice Chotard <patrice.chotard@st.com> > > Thanks > > Patrice > _______________________________________________ > Uboot-stm32 mailing list > Uboot-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32 Applied to u-boot-stm/master Thanks Patrice
diff --git a/arch/arm/mach-stm32mp/spl.c b/arch/arm/mach-stm32mp/spl.c index 39413e9a0e..e84bdad7bf 100644 --- a/arch/arm/mach-stm32mp/spl.c +++ b/arch/arm/mach-stm32mp/spl.c @@ -147,7 +147,7 @@ void spl_board_prepare_for_boot(void) dcache_disable(); } -void spl_board_prepare_for_boot_linux(void) +void spl_board_prepare_for_linux(void) { dcache_disable(); }
Replace the function spl_board_prepare_for_boot_linux by the correct name of the weak function spl_board_prepare_for_linux defined in spl.h. This patch avoids warning with W=1 option: u-boot/arch/arm/mach-stm32mp/spl.c:150:6: warning: no previous prototype for ?spl_board_prepare_for_boot_linux? [-Wmissing-prototypes] Fixes: dc7e5f190de5 ("arm: stm32mp: activate data cache on DDR in SPL") Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com> --- arch/arm/mach-stm32mp/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)