| Message ID | 20200424210329.191367-1-andrius@stikonas.eu |
|---|---|
| State | Accepted |
| Commit | 1266ef105f671b41b7e3e77bf68c7564e355995e |
| Headers | show |
| Series | rockpro64: Enable HDMI output on rockpro64 board | expand |
> From: Andrius ?tikonas <andrius at stikonas.eu> > Date: Fri, 24 Apr 2020 22:03:29 +0100 > > See 9778edae5576e0a43a13387f9081ce11ef633025 for a similar > commit that adds HDMI to other rk3399 boards. > > Signed-off-by: Andrius ?tikonas <andrius at stikonas.eu> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org> > Cc: Jagan Teki <jagan at amarulasolutions.com> > Cc: Kever Yang <kever.yang at rock-chips.com> > --- > configs/rockpro64-rk3399_defconfig | 7 +++++++ > include/configs/rockpro64_rk3399.h | 5 +++++ > 2 files changed, 12 insertions(+) I had exactly the same diff in my tree, so Tested-by: Mark Kettenis <kettenis at openbsd.org> > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig > index 8074e4665a..53abce0057 100644 > --- a/configs/rockpro64-rk3399_defconfig > +++ b/configs/rockpro64-rk3399_defconfig > @@ -58,5 +58,12 @@ CONFIG_USB_ETHER_ASIX88179=y > CONFIG_USB_ETHER_MCS7830=y > CONFIG_USB_ETHER_RTL8152=y > CONFIG_USB_ETHER_SMSC95XX=y > +CONFIG_USB_KEYBOARD=y > CONFIG_SPL_TINY_MEMSET=y > CONFIG_ERRNO_STR=y > +CONFIG_DM_VIDEO=y > +CONFIG_VIDEO_BPP16=y > +CONFIG_VIDEO_BPP32=y > +CONFIG_DISPLAY=y > +CONFIG_VIDEO_ROCKCHIP=y > +CONFIG_DISPLAY_ROCKCHIP_HDMI=y > diff --git a/include/configs/rockpro64_rk3399.h b/include/configs/rockpro64_rk3399.h > index 5f52c1e4f6..c92863e213 100644 > --- a/include/configs/rockpro64_rk3399.h > +++ b/include/configs/rockpro64_rk3399.h > @@ -6,6 +6,11 @@ > #ifndef __ROCKPRO64_RK3399_H > #define __ROCKPRO64_RK3399_H > > +#define ROCKCHIP_DEVICE_SETTINGS \ > + "stdin=serial,usbkbd\0" \ > + "stdout=serial,vidconsole\0" \ > + "stderr=serial,vidconsole\0" > + > #include <configs/rk3399_common.h> > > #define CONFIG_SYS_MMC_ENV_DEV 0 > -- > 2.26.2 > >
On Sat, Apr 25, 2020 at 2:33 AM Andrius ?tikonas <andrius at stikonas.eu> wrote: > > See 9778edae5576e0a43a13387f9081ce11ef633025 for a similar > commit that adds HDMI to other rk3399 boards. > > Signed-off-by: Andrius ?tikonas <andrius at stikonas.eu> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org> > Cc: Jagan Teki <jagan at amarulasolutions.com> > Cc: Kever Yang <kever.yang at rock-chips.com> > --- Reviewed-by: Jagan Teki <jagan at amarulasolutions.com>
On 2020/4/25 ??5:03, Andrius ?tikonas wrote: > See 9778edae5576e0a43a13387f9081ce11ef633025 for a similar > commit that adds HDMI to other rk3399 boards. > > Signed-off-by: Andrius ?tikonas <andrius at stikonas.eu> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org> > Cc: Jagan Teki <jagan at amarulasolutions.com> > Cc: Kever Yang <kever.yang at rock-chips.com> Reviewed-by: Kever Yang <kever.yang at rock-chips.com> Thanks, - Kever > --- > configs/rockpro64-rk3399_defconfig | 7 +++++++ > include/configs/rockpro64_rk3399.h | 5 +++++ > 2 files changed, 12 insertions(+) > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig > index 8074e4665a..53abce0057 100644 > --- a/configs/rockpro64-rk3399_defconfig > +++ b/configs/rockpro64-rk3399_defconfig > @@ -58,5 +58,12 @@ CONFIG_USB_ETHER_ASIX88179=y > CONFIG_USB_ETHER_MCS7830=y > CONFIG_USB_ETHER_RTL8152=y > CONFIG_USB_ETHER_SMSC95XX=y > +CONFIG_USB_KEYBOARD=y > CONFIG_SPL_TINY_MEMSET=y > CONFIG_ERRNO_STR=y > +CONFIG_DM_VIDEO=y > +CONFIG_VIDEO_BPP16=y > +CONFIG_VIDEO_BPP32=y > +CONFIG_DISPLAY=y > +CONFIG_VIDEO_ROCKCHIP=y > +CONFIG_DISPLAY_ROCKCHIP_HDMI=y > diff --git a/include/configs/rockpro64_rk3399.h b/include/configs/rockpro64_rk3399.h > index 5f52c1e4f6..c92863e213 100644 > --- a/include/configs/rockpro64_rk3399.h > +++ b/include/configs/rockpro64_rk3399.h > @@ -6,6 +6,11 @@ > #ifndef __ROCKPRO64_RK3399_H > #define __ROCKPRO64_RK3399_H > > +#define ROCKCHIP_DEVICE_SETTINGS \ > + "stdin=serial,usbkbd\0" \ > + "stdout=serial,vidconsole\0" \ > + "stderr=serial,vidconsole\0" > + > #include <configs/rk3399_common.h> > > #define CONFIG_SYS_MMC_ENV_DEV 0
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 8074e4665a..53abce0057 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -58,5 +58,12 @@ CONFIG_USB_ETHER_ASIX88179=y CONFIG_USB_ETHER_MCS7830=y CONFIG_USB_ETHER_RTL8152=y CONFIG_USB_ETHER_SMSC95XX=y +CONFIG_USB_KEYBOARD=y CONFIG_SPL_TINY_MEMSET=y CONFIG_ERRNO_STR=y +CONFIG_DM_VIDEO=y +CONFIG_VIDEO_BPP16=y +CONFIG_VIDEO_BPP32=y +CONFIG_DISPLAY=y +CONFIG_VIDEO_ROCKCHIP=y +CONFIG_DISPLAY_ROCKCHIP_HDMI=y diff --git a/include/configs/rockpro64_rk3399.h b/include/configs/rockpro64_rk3399.h index 5f52c1e4f6..c92863e213 100644 --- a/include/configs/rockpro64_rk3399.h +++ b/include/configs/rockpro64_rk3399.h @@ -6,6 +6,11 @@ #ifndef __ROCKPRO64_RK3399_H #define __ROCKPRO64_RK3399_H +#define ROCKCHIP_DEVICE_SETTINGS \ + "stdin=serial,usbkbd\0" \ + "stdout=serial,vidconsole\0" \ + "stderr=serial,vidconsole\0" + #include <configs/rk3399_common.h> #define CONFIG_SYS_MMC_ENV_DEV 0
See 9778edae5576e0a43a13387f9081ce11ef633025 for a similar commit that adds HDMI to other rk3399 boards. Signed-off-by: Andrius ?tikonas <andrius at stikonas.eu> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org> Cc: Jagan Teki <jagan at amarulasolutions.com> Cc: Kever Yang <kever.yang at rock-chips.com> --- configs/rockpro64-rk3399_defconfig | 7 +++++++ include/configs/rockpro64_rk3399.h | 5 +++++ 2 files changed, 12 insertions(+)