diff mbox series

[4/5] mtd: sf: Drop plat from sf_probe

Message ID 20200514121145.28737-5-jagan@amarulasolutions.com
State Accepted
Commit c862b91d9381dd5bf7a25fc2f0e73d73b1512a57
Headers show
Series sf: Cleanup | expand

Commit Message

Jagan Teki May 14, 2020, 12:11 p.m. UTC
dm_spi_slave_platdata used in sf_probe for printing
plat->cs value and there is no relevant usage apart
from this.

We have enouch debug messages available in SPI and SF
areas so drop this plat get and associated bug statement.

Cc: Simon Glass <sjg at chromium.org>
Cc: Vignesh R <vigneshr at ti.com>
Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
---
 drivers/mtd/spi/sf_probe.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Pratyush Yadav May 15, 2020, 7:17 a.m. UTC | #1
On 14/05/20 05:41PM, Jagan Teki wrote:
> dm_spi_slave_platdata used in sf_probe for printing
> plat->cs value and there is no relevant usage apart
> from this.
> 
> We have enouch debug messages available in SPI and SF

s/enouch/enough/

> areas so drop this plat get and associated bug statement.
> 
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Vignesh R <vigneshr at ti.com>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
Jagan Teki May 19, 2020, 7:32 p.m. UTC | #2
On Fri, May 15, 2020 at 12:47 PM Pratyush Yadav <p.yadav at ti.com> wrote:
>
> On 14/05/20 05:41PM, Jagan Teki wrote:
> > dm_spi_slave_platdata used in sf_probe for printing
> > plat->cs value and there is no relevant usage apart
> > from this.
> >
> > We have enouch debug messages available in SPI and SF
>
> s/enouch/enough/

Applied to u-boot-spi/master
diff mbox series

Patch

diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
index 72b6ee702d..89e384901c 100644
--- a/drivers/mtd/spi/sf_probe.c
+++ b/drivers/mtd/spi/sf_probe.c
@@ -140,13 +140,11 @@  static int spi_flash_std_get_sw_write_prot(struct udevice *dev)
 int spi_flash_std_probe(struct udevice *dev)
 {
 	struct spi_slave *slave = dev_get_parent_priv(dev);
-	struct dm_spi_slave_platdata *plat = dev_get_parent_platdata(dev);
 	struct spi_flash *flash;
 
 	flash = dev_get_uclass_priv(dev);
 	flash->dev = dev;
 	flash->spi = slave;
-	debug("%s: slave=%p, cs=%d\n", __func__, slave, plat->cs);
 	return spi_flash_probe_slave(flash);
 }