diff mbox series

mmc: stm32_sdmmc2: change the displayed config name

Message ID 20200430095210.1.I4bda9fd7fdf1c7fe42323749ad1977dc690e14db@changeid
State Accepted
Commit d7244e4a1fe72c9fbd63f74489099051887b2e89
Headers show
Series mmc: stm32_sdmmc2: change the displayed config name | expand

Commit Message

Patrick Delaunay April 30, 2020, 7:52 a.m. UTC
Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to
?STM32 SD/MMC?.

This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the
displayed name "STM32 SDMMC2" is confusing for user, between the
instance of SDMMC and the device identifier of MMC.

For example on EV1 board, we have:

STM32MP1> mmc list
 STM32 SDMMC2: 0 (SD)
 STM32 SDMMC2: 1 (eMMC)

Changed to more clear:

STM32MP1> mmc list
 STM32 SD/MMC: 0 (SD)
 STM32 SD/MMC: 1 (eMMC)

Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
---

 drivers/mmc/stm32_sdmmc2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Patrice CHOTARD May 11, 2020, 2 p.m. UTC | #1
On 4/30/20 9:52 AM, Patrick Delaunay wrote:
> Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to
> ?STM32 SD/MMC?.
>
> This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the
> displayed name "STM32 SDMMC2" is confusing for user, between the
> instance of SDMMC and the device identifier of MMC.
>
> For example on EV1 board, we have:
>
> STM32MP1> mmc list
>  STM32 SDMMC2: 0 (SD)
>  STM32 SDMMC2: 1 (eMMC)
>
> Changed to more clear:
>
> STM32MP1> mmc list
>  STM32 SD/MMC: 0 (SD)
>  STM32 SD/MMC: 1 (eMMC)
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
>  drivers/mmc/stm32_sdmmc2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
> index 6f3b2ad653..fa6fc94ad9 100644
> --- a/drivers/mmc/stm32_sdmmc2.c
> +++ b/drivers/mmc/stm32_sdmmc2.c
> @@ -674,7 +674,7 @@ static int stm32_sdmmc2_probe(struct udevice *dev)
>  	cfg->f_max = dev_read_u32_default(dev, "max-frequency", 52000000);
>  	cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
>  	cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
> -	cfg->name = "STM32 SDMMC2";
> +	cfg->name = "STM32 SD/MMC";
>  
>  	cfg->host_caps = 0;
>  	if (cfg->f_max > 25000000)

Reviewed-by: Patrice Chotard <patrice.chotard at st.com>

Thanks

Patrice
Patrick Delaunay May 14, 2020, 9:40 a.m. UTC | #2
Hi,

> From: Patrick DELAUNAY <patrick.delaunay at st.com>
> Sent: jeudi 30 avril 2020 09:52
> 
> Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to
> ?STM32 SD/MMC?.
> 
> This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the
> displayed name "STM32 SDMMC2" is confusing for user, between the instance of
> SDMMC and the device identifier of MMC.
> 
> For example on EV1 board, we have:
> 
> STM32MP1> mmc list
>  STM32 SDMMC2: 0 (SD)
>  STM32 SDMMC2: 1 (eMMC)
> 
> Changed to more clear:
> 
> STM32MP1> mmc list
>  STM32 SD/MMC: 0 (SD)
>  STM32 SD/MMC: 1 (eMMC)
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
> 
>  drivers/mmc/stm32_sdmmc2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-stm/master, thanks!

Regards

Patrick
diff mbox series

Patch

diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
index 6f3b2ad653..fa6fc94ad9 100644
--- a/drivers/mmc/stm32_sdmmc2.c
+++ b/drivers/mmc/stm32_sdmmc2.c
@@ -674,7 +674,7 @@  static int stm32_sdmmc2_probe(struct udevice *dev)
 	cfg->f_max = dev_read_u32_default(dev, "max-frequency", 52000000);
 	cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
-	cfg->name = "STM32 SDMMC2";
+	cfg->name = "STM32 SD/MMC";
 
 	cfg->host_caps = 0;
 	if (cfg->f_max > 25000000)