| Message ID | MWHPR0801MB38195F11C14803791F171FA5ACA50@MWHPR0801MB3819.namprd08.prod.outlook.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi | expand |
Eugen,
Thanks for the speedy reply, I did not know about this script! I must have glossed over it in the uboot patch documentation page.
The commit line is 82 characters which is longer than the preferred max of 75. Oops. Don't think this warning would be stopping the patch going through though...
Here is the output for the patch:
-----
$ ./scripts/checkpatch.pl 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7:
This patch adds support for uart4 to the processor level device tree include file.
total: 0 errors, 1 warnings, 0 checks, 14 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch has style problems, please review.
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
-----
Regards,
Tiaki Rice
-----Original Message-----
From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com>
Sent: Thursday, 7 May 2020 8:19 PM
To: tiakirice at hotmail.com
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi
On 07.05.2020 12:21, Tiaki Rice wrote:
> Hello Eugen,
>
> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction.
>
> What I did:
> - Made the changes on master and locally commited them
> - Created a patch using 'git format-patch' and modified the patch file email body.
> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and
> Cc'd you
>
> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas?
>
Hi Tiaki,
From my perspective you did everything very well. The patch looks sent fine. I would only have one question, did you check your patch with the built-in perl script that automatically checks your patch for formatting ?
./scripts/checkpatch.pl --strict <your patch file>
About patchwork, I think it may be an issue with patchwork.
Eugen
>
> Thanks in advance,
>
> Tiaki Rice
>
> -----Original Message-----
> From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com>
> Sent: Thursday, 7 May 2020 7:12 PM
> To: tiakirice at hotmail.com; u-boot at lists.denx.de
> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to
> sama5d2.dtsi
>
> On 07.05.2020 07:43, Tiaki Rice wrote:
>> This patch adds support for uart4 to the processor level device tree include file.
>>
>>
>> Signed-off-by: Tiaki Rice <tiakirice at hotmail.com>
>> Cc: Eugen Hristev <Eugen.Hristev at microchip.com>
>> ---
>
> Hi,
>
> Thanks for contributing !
>
> I have an issue with this patch missing from patchwork.
> Anyone has any idea why that happened ?
>
> Eugen
>
>> arch/arm/dts/sama5d2.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
>> index 5adc47b906..6fb2cb25f9 100644
>> --- a/arch/arm/dts/sama5d2.dtsi
>> +++ b/arch/arm/dts/sama5d2.dtsi
>> @@ -746,6 +746,14 @@
>> status = "disabled";
>> };
>>
>> +uart4: serial at fc00c000 {
>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>;
>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled";
>> +};
>> +
>> i2c1: i2c at fc028000 {
>> compatible = "atmel,sama5d2-i2c";
>> reg = <0xfc028000 0x100>;
>> --
>> 2.22.0.windows.1
>>
>
On 07.05.2020 14:32, Tiaki Rice wrote: > Eugen, > > Thanks for the speedy reply, I did not know about this script! I must have glossed over it in the uboot patch documentation page. > > The commit line is 82 characters which is longer than the preferred max of 75. Oops. Don't think this warning would be stopping the patch going through though... > Hi, For sure that won't be a problem with patchwork. however , it looks like your patch is windows-generated ? That might be an issue, I do not know. Can you send me your patch as attachment file ? Thanks > > Here is the output for the patch: > ----- > $ ./scripts/checkpatch.pl 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #7: > This patch adds support for uart4 to the processor level device tree include file. > > total: 0 errors, 1 warnings, 0 checks, 14 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch has style problems, please review. > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > ----- > > Regards, > > Tiaki Rice > > -----Original Message----- > From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> > Sent: Thursday, 7 May 2020 8:19 PM > To: tiakirice at hotmail.com > Cc: u-boot at lists.denx.de > Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi > > On 07.05.2020 12:21, Tiaki Rice wrote: > >> Hello Eugen, >> >> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction. >> >> What I did: >> - Made the changes on master and locally commited them >> - Created a patch using 'git format-patch' and modified the patch file email body. >> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and >> Cc'd you >> >> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas? >> > > Hi Tiaki, > > From my perspective you did everything very well. The patch looks sent fine. I would only have one question, did you check your patch with the built-in perl script that automatically checks your patch for formatting ? > ./scripts/checkpatch.pl --strict <your patch file> > > About patchwork, I think it may be an issue with patchwork. > > Eugen > > >> >> Thanks in advance, >> >> Tiaki Rice >> >> -----Original Message----- >> From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> >> Sent: Thursday, 7 May 2020 7:12 PM >> To: tiakirice at hotmail.com; u-boot at lists.denx.de >> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to >> sama5d2.dtsi >> >> On 07.05.2020 07:43, Tiaki Rice wrote: >>> This patch adds support for uart4 to the processor level device tree include file. >>> >>> >>> Signed-off-by: Tiaki Rice <tiakirice at hotmail.com> >>> Cc: Eugen Hristev <Eugen.Hristev at microchip.com> >>> --- >> >> Hi, >> >> Thanks for contributing ! >> >> I have an issue with this patch missing from patchwork. >> Anyone has any idea why that happened ? >> >> Eugen >> >>> arch/arm/dts/sama5d2.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi >>> index 5adc47b906..6fb2cb25f9 100644 >>> --- a/arch/arm/dts/sama5d2.dtsi >>> +++ b/arch/arm/dts/sama5d2.dtsi >>> @@ -746,6 +746,14 @@ >>> status = "disabled"; >>> }; >>> >>> +uart4: serial at fc00c000 { >>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>; >>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled"; >>> +}; >>> + >>> i2c1: i2c at fc028000 { >>> compatible = "atmel,sama5d2-i2c"; >>> reg = <0xfc028000 0x100>; >>> -- >>> 2.22.0.windows.1 >>> >> >
Eugen, Ah, I suspect the issue might be might be because I changed the subject inside the file but the did not change the filename. I shouldn't have done it that way anyway. Regarding windows vs linux, doing a diff between them showed no differences aside from the tag at the end describing the git version. I have amended the commit and attached both the windows git patch I originally submitted for reference (0001-dtsi...) and the new patch created under CentOS8 (0001-arm-dtsi...). If you can't see any problems, should I try emailing the patch to the list again? Regards, Tiaki -----Original Message----- From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> Sent: Thursday, 7 May 2020 9:55 PM To: tiakirice at hotmail.com Cc: u-boot at lists.denx.de Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi On 07.05.2020 14:32, Tiaki Rice wrote: > Eugen, > > Thanks for the speedy reply, I did not know about this script! I must have glossed over it in the uboot patch documentation page. > > The commit line is 82 characters which is longer than the preferred max of 75. Oops. Don't think this warning would be stopping the patch going through though... > Hi, For sure that won't be a problem with patchwork. however , it looks like your patch is windows-generated ? That might be an issue, I do not know. Can you send me your patch as attachment file ? Thanks > > Here is the output for the patch: > ----- > $ ./scripts/checkpatch.pl 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #7: > This patch adds support for uart4 to the processor level device tree include file. > > total: 0 errors, 1 warnings, 0 checks, 14 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch has style problems, please review. > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE > PREFER_ETHER_ADDR_COPY USLEEP_RANGE > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > ----- > > Regards, > > Tiaki Rice > > -----Original Message----- > From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> > Sent: Thursday, 7 May 2020 8:19 PM > To: tiakirice at hotmail.com > Cc: u-boot at lists.denx.de > Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to > sama5d2.dtsi > > On 07.05.2020 12:21, Tiaki Rice wrote: > >> Hello Eugen, >> >> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction. >> >> What I did: >> - Made the changes on master and locally commited them >> - Created a patch using 'git format-patch' and modified the patch file email body. >> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and >> Cc'd you >> >> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas? >> > > Hi Tiaki, > > From my perspective you did everything very well. The patch looks sent fine. I would only have one question, did you check your patch with the built-in perl script that automatically checks your patch for formatting ? > ./scripts/checkpatch.pl --strict <your patch file> > > About patchwork, I think it may be an issue with patchwork. > > Eugen > > >> >> Thanks in advance, >> >> Tiaki Rice >> >> -----Original Message----- >> From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> >> Sent: Thursday, 7 May 2020 7:12 PM >> To: tiakirice at hotmail.com; u-boot at lists.denx.de >> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to >> sama5d2.dtsi >> >> On 07.05.2020 07:43, Tiaki Rice wrote: >>> This patch adds support for uart4 to the processor level device tree include file. >>> >>> >>> Signed-off-by: Tiaki Rice <tiakirice at hotmail.com> >>> Cc: Eugen Hristev <Eugen.Hristev at microchip.com> >>> --- >> >> Hi, >> >> Thanks for contributing ! >> >> I have an issue with this patch missing from patchwork. >> Anyone has any idea why that happened ? >> >> Eugen >> >>> arch/arm/dts/sama5d2.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi >>> index 5adc47b906..6fb2cb25f9 100644 >>> --- a/arch/arm/dts/sama5d2.dtsi >>> +++ b/arch/arm/dts/sama5d2.dtsi >>> @@ -746,6 +746,14 @@ >>> status = "disabled"; >>> }; >>> >>> +uart4: serial at fc00c000 { >>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>; >>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled"; >>> +}; >>> + >>> i2c1: i2c at fc028000 { >>> compatible = "atmel,sama5d2-i2c"; >>> reg = <0xfc028000 0x100>; >>> -- >>> 2.22.0.windows.1 >>> >> > -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch Type: application/octet-stream Size: 1023 bytes Desc: 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200507/771b1f15/attachment.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-arm-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dts.patch Type: application/octet-stream Size: 1013 bytes Desc: 0001-arm-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dts.patch URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200507/771b1f15/attachment-0001.obj>
On 07.05.2020 17:23, Tiaki Rice wrote: > Eugen, > > Ah, I suspect the issue might be might be because I changed the subject inside the file but the did not change the filename. I shouldn't have done it that way anyway. Regarding windows vs linux, doing a diff between them showed no differences aside from the tag at the end describing the git version. > > I have amended the commit and attached both the windows git patch I originally submitted for reference (0001-dtsi...) and the new patch created under CentOS8 (0001-arm-dtsi...). If you can't see any problems, should I try emailing the patch to the list again? > > Ok, your patch looks good. I can see it now in patchwork. Maybe it was a patchwork glitch. I will modify the patch a little bit to comply with the shortlog rules: ARM must be in caps then dts, no need to put dtsi, and no need to mention sama5d2.dtsi again in shortlog (ARM: dts: sama5d2 means it's sama5d2.dtsi ) like: ARM: dts: sama5d2: add uart4 definition if you feel like doing that yourself, modify and send a v2 patch (git format-patch -v 2) and send it again with git send-email. Thanks again ! Eugen > Regards, Tiaki > > -----Original Message----- > From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> > Sent: Thursday, 7 May 2020 9:55 PM > To: tiakirice at hotmail.com > Cc: u-boot at lists.denx.de > Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi > > On 07.05.2020 14:32, Tiaki Rice wrote: >> Eugen, >> >> Thanks for the speedy reply, I did not know about this script! I must have glossed over it in the uboot patch documentation page. >> >> The commit line is 82 characters which is longer than the preferred max of 75. Oops. Don't think this warning would be stopping the patch going through though... >> > > Hi, > > For sure that won't be a problem with patchwork. > however , it looks like your patch is windows-generated ? That might be an issue, I do not know. Can you send me your patch as attachment file ? > > Thanks > >> >> Here is the output for the patch: >> ----- >> $ ./scripts/checkpatch.pl 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch >> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) >> #7: >> This patch adds support for uart4 to the processor level device tree include file. >> >> total: 0 errors, 1 warnings, 0 checks, 14 lines checked >> >> NOTE: For some of the reported defects, checkpatch may be able to >> mechanically convert to the typical style using --fix or --fix-inplace. >> >> 0001-dtsi-sama5d2-Add-uart4-definition-to-sama5d2.dtsi.patch has style problems, please review. >> >> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX >> MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE >> PREFER_ETHER_ADDR_COPY USLEEP_RANGE >> >> NOTE: If any of the errors are false positives, please report >> them to the maintainer, see CHECKPATCH in MAINTAINERS. >> ----- >> >> Regards, >> >> Tiaki Rice >> >> -----Original Message----- >> From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> >> Sent: Thursday, 7 May 2020 8:19 PM >> To: tiakirice at hotmail.com >> Cc: u-boot at lists.denx.de >> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to >> sama5d2.dtsi >> >> On 07.05.2020 12:21, Tiaki Rice wrote: >> >>> Hello Eugen, >>> >>> I'm new to this whole mailing list patchwork thingy so I suspect I didn't quite submit the patch correctly, maybe you can point me in the right direction. >>> >>> What I did: >>> - Made the changes on master and locally commited them >>> - Created a patch using 'git format-patch' and modified the patch file email body. >>> - Used 'git send-email' to send the patch to u-boot at lists.denx.de and >>> Cc'd you >>> >>> This opened my Outlook of which I checked to make sure the email was plain text and then sent it. Any ideas? >>> >> >> Hi Tiaki, >> >> From my perspective you did everything very well. The patch looks sent fine. I would only have one question, did you check your patch with the built-in perl script that automatically checks your patch for formatting ? >> ./scripts/checkpatch.pl --strict <your patch file> >> >> About patchwork, I think it may be an issue with patchwork. >> >> Eugen >> >> >>> >>> Thanks in advance, >>> >>> Tiaki Rice >>> >>> -----Original Message----- >>> From: Eugen.Hristev at microchip.com <Eugen.Hristev at microchip.com> >>> Sent: Thursday, 7 May 2020 7:12 PM >>> To: tiakirice at hotmail.com; u-boot at lists.denx.de >>> Subject: Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to >>> sama5d2.dtsi >>> >>> On 07.05.2020 07:43, Tiaki Rice wrote: >>>> This patch adds support for uart4 to the processor level device tree include file. >>>> >>>> >>>> Signed-off-by: Tiaki Rice <tiakirice at hotmail.com> >>>> Cc: Eugen Hristev <Eugen.Hristev at microchip.com> >>>> --- >>> >>> Hi, >>> >>> Thanks for contributing ! >>> >>> I have an issue with this patch missing from patchwork. >>> Anyone has any idea why that happened ? >>> >>> Eugen >>> >>>> arch/arm/dts/sama5d2.dtsi | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi >>>> index 5adc47b906..6fb2cb25f9 100644 >>>> --- a/arch/arm/dts/sama5d2.dtsi >>>> +++ b/arch/arm/dts/sama5d2.dtsi >>>> @@ -746,6 +746,14 @@ >>>> status = "disabled"; >>>> }; >>>> >>>> +uart4: serial at fc00c000 { >>>> +compatible = "atmel,at91sam9260-usart"; reg = <0xfc00c000 0x100>; >>>> +clocks = <&uart4_clk>; clock-names = "usart"; status = "disabled"; >>>> +}; >>>> + >>>> i2c1: i2c at fc028000 { >>>> compatible = "atmel,sama5d2-i2c"; >>>> reg = <0xfc028000 0x100>; >>>> -- >>>> 2.22.0.windows.1 >>>> >>> >> >
diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi index 5adc47b906..6fb2cb25f9 100644 --- a/arch/arm/dts/sama5d2.dtsi +++ b/arch/arm/dts/sama5d2.dtsi @@ -746,6 +746,14 @@ status = "disabled"; }; + uart4: serial at fc00c000 { + compatible = "atmel,at91sam9260-usart"; + reg = <0xfc00c000 0x100>; + clocks = <&uart4_clk>; + clock-names = "usart"; + status = "disabled"; + }; + i2c1: i2c at fc028000 { compatible = "atmel,sama5d2-i2c"; reg = <0xfc028000 0x100>;
This patch adds support for uart4 to the processor level device tree include file. Signed-off-by: Tiaki Rice <tiakirice at hotmail.com> Cc: Eugen Hristev <Eugen.Hristev at microchip.com> --- arch/arm/dts/sama5d2.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)