| Message ID | 20200503062356.8270-2-Zhiqiang.Hou@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net: tsec: Fix issues of DM driver | expand |
On Sun, 3 May 2020 at 09:28, Zhiqiang Hou <Zhiqiang.Hou at nxp.com> wrote: > > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com> > > Change the compatible string to "fsl,etsec2" for the Ethernet ports, > which is used in the current driver's match table. > > Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC ethernet controller") > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com> > --- Acked-by: Vladimir Oltean <vladimir.oltean at nxp.com> Although I am unclear how the G&D MPC8308 boards (arch/powerpc/dts/gdsys/mpc8308.dtsi) have ever probed their TSEC interfaces. Probably not based on DM, since the fsl,tsec compatible string has never been supported by the mainline tsec driver. > doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/device-tree-bindings/net/fsl-tsec-phy.txt b/doc/device-tree-bindings/net/fsl-tsec-phy.txt > index 59989e3b09..8e8574bc97 100644 > --- a/doc/device-tree-bindings/net/fsl-tsec-phy.txt > +++ b/doc/device-tree-bindings/net/fsl-tsec-phy.txt > @@ -2,7 +2,7 @@ > > Properties: > > - - compatible : Should be "fsl,tsec" > + - compatible : Should be "fsl,etsec2" > - reg : Offset and length of the register set for the device > - phy-handle : See ethernet.txt file in the same directory. > - phy-connection-type : See ethernet.txt file in the same directory. This > @@ -12,7 +12,7 @@ Properties: > > Example: > ethernet at 24000 { > - compatible = "fsl,tsec"; > + compatible = "fsl,etsec2"; > reg = <0x24000 0x1000>; > phy-handle = <&phy0>; > phy-connection-type = "sgmii"; > -- > 2.17.1 >
Hi Vladimir, Thanks a lot for your ack! > -----Original Message----- > From: Vladimir Oltean <olteanv at gmail.com> > Sent: 2020?5?3? 19:13 > To: Z.q. Hou <zhiqiang.hou at nxp.com> > Cc: u-boot <u-boot at lists.denx.de>; Joe Hershberger > <joe.hershberger at ni.com>; Bin Meng <bmeng.cn at gmail.com>; Priyanka > Jain <priyanka.jain at nxp.com>; mario.six at gdsys.cc > Subject: Re: [PATCH 1/3] doc: dt-bindings: tsec: Correct the Ethernet port > compatible string > > On Sun, 3 May 2020 at 09:28, Zhiqiang Hou <Zhiqiang.Hou at nxp.com> > wrote: > > > > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com> > > > > Change the compatible string to "fsl,etsec2" for the Ethernet ports, > > which is used in the current driver's match table. > > > > Fixes: 69a00875e3db ("doc: dt-bindings: Describe Freescale TSEC > > ethernet controller") > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com> > > --- > > Acked-by: Vladimir Oltean <vladimir.oltean at nxp.com> > > Although I am unclear how the G&D MPC8308 boards > (arch/powerpc/dts/gdsys/mpc8308.dtsi) have ever probed their TSEC > interfaces. Probably not based on DM, since the fsl,tsec compatible string > has never been supported by the mainline tsec driver. I agree with you, they seems using legacy driver. I'm working on the support of compatible "gianfar", the MPC8308 boards can shift to the DM driver then. Thanks, Zhiqiang > > > doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/doc/device-tree-bindings/net/fsl-tsec-phy.txt > > b/doc/device-tree-bindings/net/fsl-tsec-phy.txt > > index 59989e3b09..8e8574bc97 100644 > > --- a/doc/device-tree-bindings/net/fsl-tsec-phy.txt > > +++ b/doc/device-tree-bindings/net/fsl-tsec-phy.txt > > @@ -2,7 +2,7 @@ > > > > Properties: > > > > - - compatible : Should be "fsl,tsec" > > + - compatible : Should be "fsl,etsec2" > > - reg : Offset and length of the register set for the device > > - phy-handle : See ethernet.txt file in the same directory. > > - phy-connection-type : See ethernet.txt file in the same > > directory. This @@ -12,7 +12,7 @@ Properties: > > > > Example: > > ethernet at 24000 { > > - compatible = "fsl,tsec"; > > + compatible = "fsl,etsec2"; > > reg = <0x24000 0x1000>; > > phy-handle = <&phy0>; > > phy-connection-type = "sgmii"; > > -- > > 2.17.1 > >
diff --git a/doc/device-tree-bindings/net/fsl-tsec-phy.txt b/doc/device-tree-bindings/net/fsl-tsec-phy.txt index 59989e3b09..8e8574bc97 100644 --- a/doc/device-tree-bindings/net/fsl-tsec-phy.txt +++ b/doc/device-tree-bindings/net/fsl-tsec-phy.txt @@ -2,7 +2,7 @@ Properties: - - compatible : Should be "fsl,tsec" + - compatible : Should be "fsl,etsec2" - reg : Offset and length of the register set for the device - phy-handle : See ethernet.txt file in the same directory. - phy-connection-type : See ethernet.txt file in the same directory. This @@ -12,7 +12,7 @@ Properties: Example: ethernet at 24000 { - compatible = "fsl,tsec"; + compatible = "fsl,etsec2"; reg = <0x24000 0x1000>; phy-handle = <&phy0>; phy-connection-type = "sgmii";