diff mbox series

[v3,2/2] config: apalis-imx8: Enable FEC TXC delay

Message ID 20200311105259.29140-2-philippe.schenker@toradex.com
State Accepted
Commit 5e0ceb0bbdafd890e43b48a72f39a87b2f76fdb6
Headers show
Series [v3,1/2] net: fec: Add possibility to enable TXC delay | expand

Commit Message

Philippe Schenker March 11, 2020, 10:52 a.m. UTC
define FEC_ENET_ENABLE_TXC_DELAY to enable the delay on TXC line on
the MAC. This has to be done in order to meet RGMII specs.
According to RGMII specs the clock should get delayed so the edges of
the clock are preferrably in the middle of the edges of data-lines so
they can be sampled properly.
Our PHY expects the MAC to delay TXC line, as it is also written
in the spec. This patch makes sure the TXC delay on the FEC is enabled

Signed-off-by: Philippe Schenker <philippe.schenker at toradex.com>
Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov at toradex.com>

---

Changes in v3:
- Add Olek's revied-by tag

Changes in v2:
- Entered a 'why' description in patch 'config: apalis-imx8: Enable FEC
  TXC delay'

 include/configs/apalis-imx8.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Babic May 1, 2020, 4:31 p.m. UTC | #1
> define FEC_ENET_ENABLE_TXC_DELAY to enable the delay on TXC line on
> the MAC. This has to be done in order to meet RGMII specs.
> According to RGMII specs the clock should get delayed so the edges of
> the clock are preferrably in the middle of the edges of data-lines so
> they can be sampled properly.
> Our PHY expects the MAC to delay TXC line, as it is also written
> in the spec. This patch makes sure the TXC delay on the FEC is enabled
> Signed-off-by: Philippe Schenker <philippe.schenker at toradex.com>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov at toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index bea035c3e23..40037157339 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -24,6 +24,7 @@ 
 
 /* Networking */
 #define FEC_QUIRK_ENET_MAC
+#define FEC_ENET_ENABLE_TXC_DELAY
 
 #define CONFIG_TFTP_TSIZE