mbox series

[v2,0/3] ARC: IO: rework IO accessors

Message ID 20200330194445.5923-1-Eugeniy.Paltsev@synopsys.com
Headers show
Series ARC: IO: rework IO accessors | expand

Message

Eugeniy Paltsev March 30, 2020, 7:44 p.m. UTC
Fixing of DW SPI which was broken by
commit 07906b3dad15 ("ARC: Switch to generic accessors")
lead me to several fixes in ARC IO accessors code.

Eugeniy Paltsev (3):
  ARC: IO: add volatile to accessors
  ARC: IO: add compiler barriers to IO accessors
  ARC: IO: add MB for __raw_* memory accessors

 arch/arc/include/asm/io.h | 93 +++++++++++++++++++++++++--------------
 1 file changed, 60 insertions(+), 33 deletions(-)

Comments

Alexey Brodkin March 30, 2020, 9:30 p.m. UTC | #1
Hi Tom,

> -----Original Message-----
> From: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> Sent: Monday, March 30, 2020 10:45 PM
> To: uboot-snps-arc at synopsys.com; Alexey Brodkin <abrodkin at synopsys.com>
> Cc: u-boot at lists.denx.de; Eugeniy Paltsev <paltsev at synopsys.com>
> Subject: [PATCH v2 0/3] ARC: IO: rework IO accessors
> 
> Fixing of DW SPI which was broken by
> commit 07906b3dad15 ("ARC: Switch to generic accessors")
> lead me to several fixes in ARC IO accessors code.
> 
> Eugeniy Paltsev (3):
>   ARC: IO: add volatile to accessors
>   ARC: IO: add compiler barriers to IO accessors
>   ARC: IO: add MB for __raw_* memory accessors
> 
>  arch/arc/include/asm/io.h | 93 +++++++++++++++++++++++++--------------
>  1 file changed, 60 insertions(+), 33 deletions(-)

Just a heads-up: that's an important last-minute fix which we need to get
some peripherals working on our boards.

So given we're 6 days before release and this is as usual only
touching ARC code I'm going to pull this series in ASAP
and then send you my pull-request if you don't mind.

-Alexey
Tom Rini March 31, 2020, 2:23 p.m. UTC | #2
On Mon, Mar 30, 2020 at 09:30:37PM +0000, Alexey Brodkin wrote:
> Hi Tom,
> 
> > -----Original Message-----
> > From: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> > Sent: Monday, March 30, 2020 10:45 PM
> > To: uboot-snps-arc at synopsys.com; Alexey Brodkin <abrodkin at synopsys.com>
> > Cc: u-boot at lists.denx.de; Eugeniy Paltsev <paltsev at synopsys.com>
> > Subject: [PATCH v2 0/3] ARC: IO: rework IO accessors
> > 
> > Fixing of DW SPI which was broken by
> > commit 07906b3dad15 ("ARC: Switch to generic accessors")
> > lead me to several fixes in ARC IO accessors code.
> > 
> > Eugeniy Paltsev (3):
> >   ARC: IO: add volatile to accessors
> >   ARC: IO: add compiler barriers to IO accessors
> >   ARC: IO: add MB for __raw_* memory accessors
> > 
> >  arch/arc/include/asm/io.h | 93 +++++++++++++++++++++++++--------------
> >  1 file changed, 60 insertions(+), 33 deletions(-)
> 
> Just a heads-up: that's an important last-minute fix which we need to get
> some peripherals working on our boards.
> 
> So given we're 6 days before release and this is as usual only
> touching ARC code I'm going to pull this series in ASAP
> and then send you my pull-request if you don't mind.

That's fine, thanks for the heads-up!