Message ID | 20200319101251.7354-5-jagan@amarulasolutions.com |
---|---|
State | New |
Headers | show |
Series | [v2,1/5] rockchip: Separate the reset cause from display cpuinfo | expand |
On Thu, Mar 19, 2020 at 3:43 PM Jagan Teki <jagan at amarulasolutions.com> wrote: > > Custom board_early_init_f not only deal with simple gpio > configuration but also have a possibility to access clocks > to process any clock related operations like checking reset > cause state and etc. > > So, call it once the rockchip timer initialization done instead > of calling first place of board_init_f which doesn't have any > rockchip init code before. > > This specific concern was tested with checking reset reason > via board_early_init_f, which indeed require a clk probe. > > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com> > --- > Changes for v2: > - none > > arch/arm/mach-rockchip/spl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c > index 48ab0e60c6..4b4e756247 100644 > --- a/arch/arm/mach-rockchip/spl.c > +++ b/arch/arm/mach-rockchip/spl.c > @@ -120,8 +120,6 @@ void board_init_f(ulong dummy) > debug("\nspl:debug uart enabled in %s\n", __func__); > #endif > > - board_early_init_f(); > - > ret = spl_early_init(); > if (ret) { > printf("spl_early_init() failed: %d\n", ret); > @@ -135,6 +133,9 @@ void board_init_f(ulong dummy) > /* Init ARM arch timer in arch/arm/cpu/armv7/arch_timer.c */ > timer_init(); > #endif > + > + board_early_init_f(); > + > #if !defined(CONFIG_TPL) || defined(CONFIG_SPL_OS_BOOT) > debug("\nspl:init dram\n"); > ret = uclass_get_device(UCLASS_RAM, 0, &dev); > -- > 2.17.1 > Tested-by: Suniel Mahesh <sunil at amarulasolutions.com>
diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index 48ab0e60c6..4b4e756247 100644 --- a/arch/arm/mach-rockchip/spl.c +++ b/arch/arm/mach-rockchip/spl.c @@ -120,8 +120,6 @@ void board_init_f(ulong dummy) debug("\nspl:debug uart enabled in %s\n", __func__); #endif - board_early_init_f(); - ret = spl_early_init(); if (ret) { printf("spl_early_init() failed: %d\n", ret); @@ -135,6 +133,9 @@ void board_init_f(ulong dummy) /* Init ARM arch timer in arch/arm/cpu/armv7/arch_timer.c */ timer_init(); #endif + + board_early_init_f(); + #if !defined(CONFIG_TPL) || defined(CONFIG_SPL_OS_BOOT) debug("\nspl:init dram\n"); ret = uclass_get_device(UCLASS_RAM, 0, &dev);
Custom board_early_init_f not only deal with simple gpio configuration but also have a possibility to access clocks to process any clock related operations like checking reset cause state and etc. So, call it once the rockchip timer initialization done instead of calling first place of board_init_f which doesn't have any rockchip init code before. This specific concern was tested with checking reset reason via board_early_init_f, which indeed require a clk probe. Signed-off-by: Jagan Teki <jagan at amarulasolutions.com> --- Changes for v2: - none arch/arm/mach-rockchip/spl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)