Message ID | 20200224172454.13812-1-masahiroy@kernel.org |
---|---|
State | Accepted |
Commit | 77c4ba54c678d5c892e4b692640424dbfe649e30 |
Headers | show |
Series | debug_uart.h: make <debug_uart.h> self-contained | expand |
Hi Masahiro, On 2020/2/25 ??1:24, Masahiro Yamada wrote: > 'uint' is not a primitive type. You need to include <linux/types.h> > or otherwise change it to (unsigned int). > > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> Reviewed-by: Kever Yang <kever.yang at rock-chips.com> Thanks, - Kever > --- > > include/debug_uart.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/include/debug_uart.h b/include/debug_uart.h > index cd70ae1a04..4d1c58075c 100644 > --- a/include/debug_uart.h > +++ b/include/debug_uart.h > @@ -88,28 +88,28 @@ void printascii(const char *str); > * > * @value: Value to output > */ > -void printhex2(uint value); > +void printhex2(unsigned int value); > > /** > * printhex4() - Output a 4-digit hex value > * > * @value: Value to output > */ > -void printhex4(uint value); > +void printhex4(unsigned int value); > > /** > * printhex8() - Output a 8-digit hex value > * > * @value: Value to output > */ > -void printhex8(uint value); > +void printhex8(unsigned int value); > > /** > * printdec() - Output a decimalism value > * > * @value: Value to output > */ > -void printdec(uint value); > +void printdec(unsigned int value); > > #ifdef CONFIG_DEBUG_UART_ANNOUNCE > #define _DEBUG_UART_ANNOUNCE printascii("<debug_uart> "); > @@ -151,34 +151,34 @@ void printdec(uint value); > _printch(*str++); \ > } \ > \ > - static inline void printhex1(uint digit) \ > + static inline void printhex1(unsigned int digit) \ > { \ > digit &= 0xf; \ > _debug_uart_putc(digit > 9 ? digit - 10 + 'a' : digit + '0'); \ > } \ > \ > - static inline void printhex(uint value, int digits) \ > + static inline void printhex(unsigned int value, int digits) \ > { \ > while (digits-- > 0) \ > printhex1(value >> (4 * digits)); \ > } \ > \ > - void printhex2(uint value) \ > + void printhex2(unsigned int value) \ > { \ > printhex(value, 2); \ > } \ > \ > - void printhex4(uint value) \ > + void printhex4(unsigned int value) \ > { \ > printhex(value, 4); \ > } \ > \ > - void printhex8(uint value) \ > + void printhex8(unsigned int value) \ > { \ > printhex(value, 8); \ > } \ > \ > - void printdec(uint value) \ > + void printdec(unsigned int value) \ > { \ > if (value > 10) { \ > printdec(value / 10); \
On Tue, Feb 25, 2020 at 02:24:54AM +0900, Masahiro Yamada wrote: > 'uint' is not a primitive type. You need to include <linux/types.h> > or otherwise change it to (unsigned int). > > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> > Reviewed-by: Kever Yang <kever.yang at rock-chips.com> Applied to u-boot/next, thanks!
diff --git a/include/debug_uart.h b/include/debug_uart.h index cd70ae1a04..4d1c58075c 100644 --- a/include/debug_uart.h +++ b/include/debug_uart.h @@ -88,28 +88,28 @@ void printascii(const char *str); * * @value: Value to output */ -void printhex2(uint value); +void printhex2(unsigned int value); /** * printhex4() - Output a 4-digit hex value * * @value: Value to output */ -void printhex4(uint value); +void printhex4(unsigned int value); /** * printhex8() - Output a 8-digit hex value * * @value: Value to output */ -void printhex8(uint value); +void printhex8(unsigned int value); /** * printdec() - Output a decimalism value * * @value: Value to output */ -void printdec(uint value); +void printdec(unsigned int value); #ifdef CONFIG_DEBUG_UART_ANNOUNCE #define _DEBUG_UART_ANNOUNCE printascii("<debug_uart> "); @@ -151,34 +151,34 @@ void printdec(uint value); _printch(*str++); \ } \ \ - static inline void printhex1(uint digit) \ + static inline void printhex1(unsigned int digit) \ { \ digit &= 0xf; \ _debug_uart_putc(digit > 9 ? digit - 10 + 'a' : digit + '0'); \ } \ \ - static inline void printhex(uint value, int digits) \ + static inline void printhex(unsigned int value, int digits) \ { \ while (digits-- > 0) \ printhex1(value >> (4 * digits)); \ } \ \ - void printhex2(uint value) \ + void printhex2(unsigned int value) \ { \ printhex(value, 2); \ } \ \ - void printhex4(uint value) \ + void printhex4(unsigned int value) \ { \ printhex(value, 4); \ } \ \ - void printhex8(uint value) \ + void printhex8(unsigned int value) \ { \ printhex(value, 8); \ } \ \ - void printdec(uint value) \ + void printdec(unsigned int value) \ { \ if (value > 10) { \ printdec(value / 10); \
'uint' is not a primitive type. You need to include <linux/types.h> or otherwise change it to (unsigned int). Signed-off-by: Masahiro Yamada <masahiroy at kernel.org> --- include/debug_uart.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)