diff mbox series

[PATCHv2,4/8] mach-davinci: Hard-code the default SPL_LDSCRIPT path

Message ID 20200311221118.4579-4-trini@konsulko.com
State Accepted
Commit 2c59412a9f230d5a6020f72edcc2c6ac772ebbb8
Headers show
Series [PATCHv2,1/8] spl: Kconfig: Escape '$(ARCH)' in LDSCRIPT entries | expand

Commit Message

Tom Rini March 11, 2020, 10:11 p.m. UTC
As there is only one linker script to use in this case, rather than use
the BOARDDIR variable hard-code the path.

Cc: Lokesh Vutla <lokeshvutla at ti.com>
Suggested-by: Masahiro Yamada <masahiroy at kernel.org>
Signed-off-by: Tom Rini <trini at konsulko.com>
---
Changes in v2.
- New patch
---
 arch/arm/mach-davinci/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lokesh Vutla March 12, 2020, 3:41 a.m. UTC | #1
On 12/03/20 3:41 AM, Tom Rini wrote:
> As there is only one linker script to use in this case, rather than use
> the BOARDDIR variable hard-code the path.
> 
> Cc: Lokesh Vutla <lokeshvutla at ti.com>
> Suggested-by: Masahiro Yamada <masahiroy at kernel.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>

Reviewed-by: Lokesh Vutla <lokeshvutla at ti.com>

Thanks and regards,
Lokesh
Masahiro Yamada March 15, 2020, 11:11 a.m. UTC | #2
On Thu, Mar 12, 2020 at 7:12 AM Tom Rini <trini at konsulko.com> wrote:
>
> As there is only one linker script to use in this case, rather than use
> the BOARDDIR variable hard-code the path.
>
> Cc: Lokesh Vutla <lokeshvutla at ti.com>
> Suggested-by: Masahiro Yamada <masahiroy at kernel.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---


Reviewed-by: Masahiro Yamada <masahiroy at kernel.org>


> Changes in v2.
> - New patch
> ---
>  arch/arm/mach-davinci/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index 8a81c078811d..6eca8db6d5ff 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -135,6 +135,6 @@ source "board/davinci/da8xxevm/Kconfig"
>  source "board/lego/ev3/Kconfig"
>
>  config SPL_LDSCRIPT
> -       default "board/$(BOARDDIR)/u-boot-spl-da850evm.lds"
> +       default "board/davinci/da8xxevm/u-boot-spl-da850evm.lds"
>
>  endif
> --
> 2.17.1
>
Tom Rini March 17, 2020, 3:29 p.m. UTC | #3
On Wed, Mar 11, 2020 at 06:11:14PM -0400, Tom Rini wrote:

> As there is only one linker script to use in this case, rather than use
> the BOARDDIR variable hard-code the path.
> 
> Cc: Lokesh Vutla <lokeshvutla at ti.com>
> Suggested-by: Masahiro Yamada <masahiroy at kernel.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla at ti.com>
> Reviewed-by: Masahiro Yamada <masahiroy at kernel.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 8a81c078811d..6eca8db6d5ff 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -135,6 +135,6 @@  source "board/davinci/da8xxevm/Kconfig"
 source "board/lego/ev3/Kconfig"
 
 config SPL_LDSCRIPT
-	default "board/$(BOARDDIR)/u-boot-spl-da850evm.lds"
+	default "board/davinci/da8xxevm/u-boot-spl-da850evm.lds"
 
 endif