| Message ID | 20200216091118.3838-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 250b303de8c714b5b31d2fe7f25b7527e800c574 |
| Headers | show |
| Series | [1/1] stm32mp1: rng: remove superfluous assignment | expand |
On Sun, 16 Feb 2020 at 14:41, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote: > We should not assign a value that is overwritten before use. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > Acked-by: Sughosh Ganu <sughosh.ganu at linaro.org> > --- > drivers/rng/stm32mp1_rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rng/stm32mp1_rng.c b/drivers/rng/stm32mp1_rng.c > index dab3b995eb..e0f0a66c6e 100644 > --- a/drivers/rng/stm32mp1_rng.c > +++ b/drivers/rng/stm32mp1_rng.c > @@ -33,7 +33,7 @@ struct stm32_rng_platdata { > > static int stm32_rng_read(struct udevice *dev, void *data, size_t len) > { > - int retval = 0, i; > + int retval, i; > u32 sr, count, reg; > size_t increment; > struct stm32_rng_platdata *pdata = dev_get_platdata(dev); > -- > 2.25.0 > >
Hi, > From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Heinrich Schuchardt > Sent: dimanche 16 f?vrier 2020 10:11 > > We should not assign a value that is overwritten before use. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > --- > drivers/rng/stm32mp1_rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rng/stm32mp1_rng.c b/drivers/rng/stm32mp1_rng.c index > dab3b995eb..e0f0a66c6e 100644 > --- a/drivers/rng/stm32mp1_rng.c > +++ b/drivers/rng/stm32mp1_rng.c > @@ -33,7 +33,7 @@ struct stm32_rng_platdata { > > static int stm32_rng_read(struct udevice *dev, void *data, size_t len) { > - int retval = 0, i; > + int retval, i; > u32 sr, count, reg; > size_t increment; > struct stm32_rng_platdata *pdata = dev_get_platdata(dev); > -- > 2.25.0 Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com> Regards Patrick
Hi, > From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Heinrich Schuchardt > Sent: dimanche 16 f?vrier 2020 10:11 > > We should not assign a value that is overwritten before use. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > --- Applied to u-boot-stm32/master, thanks! Regards Patrick
diff --git a/drivers/rng/stm32mp1_rng.c b/drivers/rng/stm32mp1_rng.c index dab3b995eb..e0f0a66c6e 100644 --- a/drivers/rng/stm32mp1_rng.c +++ b/drivers/rng/stm32mp1_rng.c @@ -33,7 +33,7 @@ struct stm32_rng_platdata { static int stm32_rng_read(struct udevice *dev, void *data, size_t len) { - int retval = 0, i; + int retval, i; u32 sr, count, reg; size_t increment; struct stm32_rng_platdata *pdata = dev_get_platdata(dev);
We should not assign a value that is overwritten before use. Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> --- drivers/rng/stm32mp1_rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.0