| Message ID | 20200625041017.26204-3-walter.lozano@collabora.com |
|---|---|
| State | Accepted |
| Commit | ace16e88d97d64a1c999a690f46123cf73fafa7c |
| Headers | show |
| Series | improve OF_PLATDATA support | expand |
On Wed, 24 Jun 2020 at 22:10, Walter Lozano <walter.lozano at collabora.com> wrote: > > Add missing information about internal class members in order to make > the code easier to follow. > > Signed-off-by: Walter Lozano <walter.lozano at collabora.com> > --- > > tools/dtoc/dtb_platdata.py | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Simon Glass <sjg at chromium.org> BTW if there was a review tag from last version, please add it to your commit.
Hi Simon, On 25/6/20 22:42, Simon Glass wrote: > On Wed, 24 Jun 2020 at 22:10, Walter Lozano <walter.lozano at collabora.com> wrote: >> Add missing information about internal class members in order to make >> the code easier to follow. >> >> Signed-off-by: Walter Lozano <walter.lozano at collabora.com> >> --- >> >> tools/dtoc/dtb_platdata.py | 3 +++ >> 1 file changed, 3 insertions(+) >> > Reviewed-by: Simon Glass <sjg at chromium.org> > > BTW if there was a review tag from last version, please add it to your commit. Thanks for pointing that, I'll take you advice for those commit that doesn't change at all. Also thank you for all the time you spent reviewing this series and sharing suggestions. Regards, Walter
Hi Walter, On Fri, 26 Jun 2020 at 07:18, Walter Lozano <walter.lozano at collabora.com> wrote: > > Hi Simon, > > On 25/6/20 22:42, Simon Glass wrote: > > On Wed, 24 Jun 2020 at 22:10, Walter Lozano <walter.lozano at collabora.com> wrote: > >> Add missing information about internal class members in order to make > >> the code easier to follow. > >> > >> Signed-off-by: Walter Lozano <walter.lozano at collabora.com> > >> --- > >> > >> tools/dtoc/dtb_platdata.py | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > > Reviewed-by: Simon Glass <sjg at chromium.org> > > > > BTW if there was a review tag from last version, please add it to your commit. > > > Thanks for pointing that, I'll take you advice for those commit that > doesn't change at all. Also thank you for all the time you spent > reviewing this series and sharing suggestions. You're welcome. It's a great improvement to of-platdata! You can add it the tag unless you make a major change to a commit. Regards, Simon
diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index ecfe0624d1..bc0de426a9 100644 --- a/tools/dtoc/dtb_platdata.py +++ b/tools/dtoc/dtb_platdata.py @@ -140,6 +140,9 @@ class DtbPlatdata(object): _include_disabled: true to include nodes marked status = "disabled" _outfile: The current output file (sys.stdout or a real file) _lines: Stashed list of output lines for outputting in the future + _aliases: Dict that hold aliases for compatible strings + key: First compatible string declared in a node + value: List of additional compatible strings declared in a node """ def __init__(self, dtb_fname, include_disabled): self._fdt = None
Add missing information about internal class members in order to make the code easier to follow. Signed-off-by: Walter Lozano <walter.lozano at collabora.com> --- tools/dtoc/dtb_platdata.py | 3 +++ 1 file changed, 3 insertions(+)