Message ID | 20200619015150.27745-3-atish.patra@wdc.com |
---|---|
State | New |
Headers | show |
Series | Assorted fixes related to reserved memory | expand |
On Fri, Jun 19, 2020 at 9:52 AM Atish Patra <atish.patra at wdc.com> wrote: > > fdtdec_get_addr_size_no_parent is not an optimized version if parent > node is already available with the caller. > > Use fdtdec_get_addr_size_auto_parent to read the "reg" property > > Signed-off-by: Atish Patra <atish.patra at wdc.com> > --- > arch/riscv/lib/fdt_fixup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/lib/fdt_fixup.c b/arch/riscv/lib/fdt_fixup.c > index 91524d9a5ae9..00b84dccbef0 100644 > --- a/arch/riscv/lib/fdt_fixup.c > +++ b/arch/riscv/lib/fdt_fixup.c > @@ -44,7 +44,7 @@ int riscv_fdt_copy_resv_mem_node(const void *src, void *dst) > fdt_for_each_subnode(node, src, offset) { > name = fdt_get_name(src, node, NULL); > > - addr = fdtdec_get_addr_size_auto_noparent(src, node, > + addr = fdtdec_get_addr_size_auto_parent(src, offset, node, > "reg", 0, &size, > false); nits: please make above 2 lines indent to the ( > if (addr == FDT_ADDR_T_NONE) { > -- Reviewed-by: Bin Meng <bin.meng at windriver.com>
diff --git a/arch/riscv/lib/fdt_fixup.c b/arch/riscv/lib/fdt_fixup.c index 91524d9a5ae9..00b84dccbef0 100644 --- a/arch/riscv/lib/fdt_fixup.c +++ b/arch/riscv/lib/fdt_fixup.c @@ -44,7 +44,7 @@ int riscv_fdt_copy_resv_mem_node(const void *src, void *dst) fdt_for_each_subnode(node, src, offset) { name = fdt_get_name(src, node, NULL); - addr = fdtdec_get_addr_size_auto_noparent(src, node, + addr = fdtdec_get_addr_size_auto_parent(src, offset, node, "reg", 0, &size, false); if (addr == FDT_ADDR_T_NONE) {
fdtdec_get_addr_size_no_parent is not an optimized version if parent node is already available with the caller. Use fdtdec_get_addr_size_auto_parent to read the "reg" property Signed-off-by: Atish Patra <atish.patra at wdc.com> --- arch/riscv/lib/fdt_fixup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)