Message ID | 20200607120615.6428-2-kettenis@openbsd.org |
---|---|
State | Superseded |
Headers | show |
Series | [v3,1/2] rockchip: Enable PCIe/M.2 and NVMe on Firefly RK3399 | expand |
On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis <kettenis at openbsd.org> wrote: > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > ROCKPro64 board. > > Signed-off-by: Mark Kettenis <kettenis at openbsd.org> > Reviewed-by: Kever Yang <kever.yang at rock-chips.com> Reviewed-by: Peter Robinson <pbrobinson at gmail.com> It's generally considered good taste to cc: the maintainer, you can find out who that is with "./scripts/get_maintainer.pl configs/pinebook-pro-rk3399_defconfig" Peter > --- > configs/rockpro64-rk3399_defconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig > index 8c4b2f35c1..23eacddf12 100644 > --- a/configs/rockpro64-rk3399_defconfig > +++ b/configs/rockpro64-rk3399_defconfig > @@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y > CONFIG_CMD_GPT=y > CONFIG_CMD_MMC=y > CONFIG_CMD_USB=y > +CONFIG_CMD_PCI=y > # CONFIG_CMD_SETEXPR is not set > CONFIG_CMD_TIME=y > CONFIG_SPL_OF_CONTROL=y > @@ -39,10 +40,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y > CONFIG_DM_ETH=y > CONFIG_ETH_DESIGNWARE=y > CONFIG_GMAC_ROCKCHIP=y > +CONFIG_NVME=y > +CONFIG_PCI=y > CONFIG_PMIC_RK8XX=y > CONFIG_REGULATOR_PWM=y > CONFIG_REGULATOR_RK8XX=y > CONFIG_PWM_ROCKCHIP=y > +CONFIG_DM_RESET=y > CONFIG_RAM_RK3399_LPDDR4=y > CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART_SHIFT=2 > -- > 2.27.0 >
On Sun, Jun 7, 2020 at 2:47 PM Peter Robinson <pbrobinson at gmail.com> wrote: > > On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis <kettenis at openbsd.org> wrote: > > > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > ROCKPro64 board. > > > > Signed-off-by: Mark Kettenis <kettenis at openbsd.org> > > Reviewed-by: Kever Yang <kever.yang at rock-chips.com> > Reviewed-by: Peter Robinson <pbrobinson at gmail.com> > > It's generally considered good taste to cc: the maintainer, you can > find out who that is with "./scripts/get_maintainer.pl > configs/pinebook-pro-rk3399_defconfig" Oh and that comment was meant against the Pinebook pro, I think someone else already sent patches for the RockPro64 to do this > Peter > > > --- > > configs/rockpro64-rk3399_defconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig > > index 8c4b2f35c1..23eacddf12 100644 > > --- a/configs/rockpro64-rk3399_defconfig > > +++ b/configs/rockpro64-rk3399_defconfig > > @@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y > > CONFIG_CMD_GPT=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_USB=y > > +CONFIG_CMD_PCI=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_CMD_TIME=y > > CONFIG_SPL_OF_CONTROL=y > > @@ -39,10 +40,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y > > CONFIG_DM_ETH=y > > CONFIG_ETH_DESIGNWARE=y > > CONFIG_GMAC_ROCKCHIP=y > > +CONFIG_NVME=y > > +CONFIG_PCI=y > > CONFIG_PMIC_RK8XX=y > > CONFIG_REGULATOR_PWM=y > > CONFIG_REGULATOR_RK8XX=y > > CONFIG_PWM_ROCKCHIP=y > > +CONFIG_DM_RESET=y > > CONFIG_RAM_RK3399_LPDDR4=y > > CONFIG_BAUDRATE=1500000 > > CONFIG_DEBUG_UART_SHIFT=2 > > -- > > 2.27.0 > >
On Sun, Jun 07, 2020 at 02:57:00PM +0100, Peter Robinson wrote: > On Sun, Jun 7, 2020 at 2:47 PM Peter Robinson <pbrobinson at gmail.com> wrote: > > > > On Sun, Jun 7, 2020 at 1:07 PM Mark Kettenis <kettenis at openbsd.org> wrote: > > > > > > Enable CONFIG_PCI and CONFIG_NVME and related configs for the > > > ROCKPro64 board. > > > > > > Signed-off-by: Mark Kettenis <kettenis at openbsd.org> > > > Reviewed-by: Kever Yang <kever.yang at rock-chips.com> > > Reviewed-by: Peter Robinson <pbrobinson at gmail.com> > > > > It's generally considered good taste to cc: the maintainer, you can > > find out who that is with "./scripts/get_maintainer.pl > > configs/pinebook-pro-rk3399_defconfig" > > Oh and that comment was meant against the Pinebook pro, I think > someone else already sent patches for the RockPro64 to do this Heh. I just took the same list of people that was CCed here. I trusted Mark's mail-sending-skills to already CC the people that are likely to respond to diffs. ;) Maybe next time I'll remember how the script is called.
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 8c4b2f35c1..23eacddf12 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -19,6 +19,7 @@ CONFIG_CMD_BOOTZ=y CONFIG_CMD_GPT=y CONFIG_CMD_MMC=y CONFIG_CMD_USB=y +CONFIG_CMD_PCI=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y CONFIG_SPL_OF_CONTROL=y @@ -39,10 +40,13 @@ CONFIG_SPI_FLASH_GIGADEVICE=y CONFIG_DM_ETH=y CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y +CONFIG_NVME=y +CONFIG_PCI=y CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +CONFIG_DM_RESET=y CONFIG_RAM_RK3399_LPDDR4=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2