| Message ID | 20200129201543.4533-3-offougajoris@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] warp7: fix pmic probe | expand |
Hi Joris, On Wed, Jan 29, 2020 at 5:16 PM Joris Offouga <offougajoris at gmail.com> wrote: > Please always provide a commit log. > Signed-off-by: Joris Offouga <offougajoris at gmail.com> > --- > arch/arm/dts/imx7s-warp-u-boot.dtsi | 10 ++++++++++ > arch/arm/dts/imx7s-warp.dts | 9 --------- > 2 files changed, 10 insertions(+), 9 deletions(-) > create mode 100644 arch/arm/dts/imx7s-warp-u-boot.dtsi > > diff --git a/arch/arm/dts/imx7s-warp-u-boot.dtsi b/arch/arm/dts/imx7s-warp-u-boot.dtsi > new file mode 100644 > index 0000000000..65da3a0d23 > --- /dev/null > +++ b/arch/arm/dts/imx7s-warp-u-boot.dtsi > @@ -0,0 +1,10 @@ > +/ { > + aliases { > + mmc0 = &usdhc3; > + usb0 = &usbotg1; > + }; > + > + chosen { > + stdoutpath = &uart1; This should be stdout-path instead. Actually I think it is better to have the Linux upstream dts to have the stdout-path entry. Care to send a patch for that? Thanks
Le 29/01/2020 à 21:22, Fabio Estevam a écrit : > Hi Joris, > > On Wed, Jan 29, 2020 at 5:16 PM Joris Offouga <offougajoris at gmail.com> wrote: > Please always provide a commit log. > >> Signed-off-by: Joris Offouga <offougajoris at gmail.com> >> --- >> arch/arm/dts/imx7s-warp-u-boot.dtsi | 10 ++++++++++ >> arch/arm/dts/imx7s-warp.dts | 9 --------- >> 2 files changed, 10 insertions(+), 9 deletions(-) >> create mode 100644 arch/arm/dts/imx7s-warp-u-boot.dtsi >> >> diff --git a/arch/arm/dts/imx7s-warp-u-boot.dtsi b/arch/arm/dts/imx7s-warp-u-boot.dtsi >> new file mode 100644 >> index 0000000000..65da3a0d23 >> --- /dev/null >> +++ b/arch/arm/dts/imx7s-warp-u-boot.dtsi >> @@ -0,0 +1,10 @@ >> +/ { >> + aliases { >> + mmc0 = &usdhc3; >> + usb0 = &usbotg1; >> + }; >> + >> + chosen { >> + stdoutpath = &uart1; > This should be stdout-path instead. indeed, i send v2 > > Actually I think it is better to have the Linux upstream dts to have > the stdout-path entry. > > Care to send a patch for that? of course i would Best regards, Joris > > Thanks
diff --git a/arch/arm/dts/imx7s-warp-u-boot.dtsi b/arch/arm/dts/imx7s-warp-u-boot.dtsi new file mode 100644 index 0000000000..65da3a0d23 --- /dev/null +++ b/arch/arm/dts/imx7s-warp-u-boot.dtsi @@ -0,0 +1,10 @@ +/ { + aliases { + mmc0 = &usdhc3; + usb0 = &usbotg1; + }; + + chosen { + stdoutpath = &uart1; + }; +}; diff --git a/arch/arm/dts/imx7s-warp.dts b/arch/arm/dts/imx7s-warp.dts index db5ef67eb1..f7ba2c0a24 100644 --- a/arch/arm/dts/imx7s-warp.dts +++ b/arch/arm/dts/imx7s-warp.dts @@ -17,15 +17,6 @@ reg = <0x80000000 0x20000000>; }; - aliases { - mmc0 = &usdhc3; - usb0 = &usbotg1; - }; - - chosen { - stdout-path = &uart1; - }; - gpio-keys { compatible = "gpio-keys"; pinctrl-0 = <&pinctrl_gpio>;
Signed-off-by: Joris Offouga <offougajoris at gmail.com> --- arch/arm/dts/imx7s-warp-u-boot.dtsi | 10 ++++++++++ arch/arm/dts/imx7s-warp.dts | 9 --------- 2 files changed, 10 insertions(+), 9 deletions(-) create mode 100644 arch/arm/dts/imx7s-warp-u-boot.dtsi