mbox series

[0/4] Add ethernet support for MT7622

Message ID 20200121113200.24259-1-Mark-MC.Lee@mediatek.com
Headers show
Series Add ethernet support for MT7622 | expand

Message

MarkLee Jan. 21, 2020, 11:31 a.m. UTC
This patch series adds and enable ethernet support for MT7622, including
	1. add sgmii mode support in mediatek eth driver
	2. add mt7622 support in mediatek eth driver
	3. add ethernet and sgmii dts node for mt7622
	4. enable mt7622 ethernet support in defconfig


MarkLee (4):
  eth: mtk-eth: add sgmii mode support in mediatek eth driver
  eth: mtk-eth: add mt7622 support in mediatek eth driver
  arm: dts: mediatek: add ethernet and sgmii dts node for mt7622
  configs: mediatek: enable mt7622 ethernet support

 arch/arm/dts/mt7622-rfb.dts  | 13 ++++++++++
 arch/arm/dts/mt7622.dtsi     | 45 +++++++++++++++++++++++++++++++++
 configs/mt7622_rfb_defconfig |  4 +++
 drivers/net/mtk_eth.c        | 49 +++++++++++++++++++++++++++++++++++-
 drivers/net/mtk_eth.h        | 15 +++++++++++
 5 files changed, 125 insertions(+), 1 deletion(-)

Comments

Frank Wunderlich Jan. 21, 2020, 12:53 p.m. UTC | #1
Hi Mark,

does it depend on another patch(set)?

i got unsupported switch, because in eth-driver [1] there is a check only for mt7530 (else print this error) and in dts [2], mediatek,switch is set to mt7531 (which is right, but trigger the error).

i found no patch adding check for mt7531 (or change this check) in patchwork

[1] https://github.com/frank-w/u-boot/blob/aed9e2af65651d036d742b30f8b4ce2d5f4d215a/drivers/net/mtk_eth.c#L1162
[2] https://github.com/frank-w/u-boot/blob/29464fe9546c83ad34fdcc395f6e45a9a8538631/arch/arm/dts/mt7622-rfb.dts#L186

regards Frank
MarkLee Jan. 22, 2020, 8:43 a.m. UTC | #2
On Tue, 2020-01-21 at 13:53 +0100, Frank Wunderlich wrote:
> Hi Mark,
> 
> does it depend on another patch(set)?
> 
> i got unsupported switch, because in eth-driver [1] there is a check only for mt7530 (else print this error) and in dts [2], mediatek,switch is set to mt7531 (which is right, but trigger the error).
> 
> i found no patch adding check for mt7531 (or change this check) in patchwork
> 
> [1] https://github.com/frank-w/u-boot/blob/aed9e2af65651d036d742b30f8b4ce2d5f4d215a/drivers/net/mtk_eth.c#L1162
> [2] https://github.com/frank-w/u-boot/blob/29464fe9546c83ad34fdcc395f6e45a9a8538631/arch/arm/dts/mt7622-rfb.dts#L186
> 
> regards Frank

Hi Frank :
  This patches set just focus on adding mt7622 into mtk eth MAC driver
with sgmii support, and yes for some mt7622 product(bpi-r64..etc) that
has a internal switch(mt7531) still need patches to support mt7531 to
make networking function work fully. 
  
  We do have plan to send a separate patches for mt7531 switch once this
mt7622 eth patch set accepted by uBoot. Thanks to you put a big
spotlight on mt7622 development, we will do it asap.
  
Mark
Frank Wunderlich Jan. 26, 2020, 11:53 a.m. UTC | #3
Hi

> Gesendet: Mittwoch, 22. Januar 2020 um 09:43 Uhr
> Von: "mtk15127" <Mark-MC.Lee at mediatek.com>

>   This patches set just focus on adding mt7622 into mtk eth MAC driver
> with sgmii support, and yes for some mt7622 product(bpi-r64..etc) that
> has a internal switch(mt7531) still need patches to support mt7531 to
> make networking function work fully.

i wondered about changes in ref-board dts. does it contain also mt7531 as switch?
imho we need an extra dts for bpi-r64 because ram is different (1G instead of 256M) and
for future changes which are only for r64.

> We do have plan to send a separate patches for mt7531 switch once this
> mt7622 eth patch set accepted by uBoot.

@tom is this Patchset ok or does it need any changes? any way to merge it in actual merge-window,
so mark can work on switch-part?

@Mark, is there any pre-release of switch-driver that i can try before you post to mailinglist?

regards Frank