| Message ID | 20200107181754.99662-1-swarren@wwwdotorg.org |
|---|---|
| State | New |
| Headers | show |
| Series | tegra: fdt: Add tegra186-u-boot.dtsi | expand |
Hi Stephen, On Tue, 7 Jan 2020 at 11:18, Stephen Warren <swarren at wwwdotorg.org> wrote: > > From: Stephen Warren <swarren at nvidia.com> > > All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate > Tegra210's copy of this file for Tegra186. This ensures that a /binman node > exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0 ("binman: Add a > library to access binman entries") this appears to be required. I haven't > really investigated why all this is necessary or how it works, but simply > observed the boot failure listed below, bisected it, noticed the > inconsistency in DT files, and found that fixing it resolved the boot > issue. If CONFIG_BINMAN is enabled, binman_init() is called and expects to find a /binman node. > > U-Boot 2020.01-rc4-00256-g3c10dc95bdd0 (Jan 07 2020 - 10:25:00 -0700) > > SoC: tegra186 > Model: NVIDIA P2771-0000-500 > Board: NVIDIA P2771-0000 > DRAM: 7.8 GiB > initcall sequence 00000000fffb7858 failed at call 00000000800955a8 (err=-22) > ### ERROR ### Please RESET the board ### > > Fixes: 3c10dc95bdd0 ("binman: Add a library to access binman entries") > Fixes: f2faffecb016 ("binman: tegra: Convert to use binman") > Signed-off-by: Stephen Warren <swarren at nvidia.com> > --- > arch/arm/dts/tegra186-u-boot.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 arch/arm/dts/tegra186-u-boot.dtsi Reviewed-by: Simon Glass <sjg at chromium.org>
On 1/7/20 11:17 AM, Stephen Warren wrote: > From: Stephen Warren <swarren at nvidia.com> > > All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate > Tegra210's copy of this file for Tegra186. This ensures that a /binman node > exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0 ("binman: Add a > library to access binman entries") this appears to be required. I haven't > really investigated why all this is necessary or how it works, but simply > observed the boot failure listed below, bisected it, noticed the > inconsistency in DT files, and found that fixing it resolved the boot > issue. > > U-Boot 2020.01-rc4-00256-g3c10dc95bdd0 (Jan 07 2020 - 10:25:00 -0700) > > SoC: tegra186 > Model: NVIDIA P2771-0000-500 > Board: NVIDIA P2771-0000 > DRAM: 7.8 GiB > initcall sequence 00000000fffb7858 failed at call 00000000800955a8 (err=-22) > ### ERROR ### Please RESET the board ### > > Fixes: 3c10dc95bdd0 ("binman: Add a library to access binman entries") > Fixes: f2faffecb016 ("binman: tegra: Convert to use binman") > Signed-off-by: Stephen Warren <swarren at nvidia.com> Can we please apply this? All Tegra186 systems (i.e. Jetson TX2) can't boot without this patch. Thank.s
I'll apply it and try to get a PR out today, sorry for the delay. -----Original Message----- From: Stephen Warren <swarren at wwwdotorg.org> Sent: Tuesday, January 14, 2020 9:59 AM To: Tom Rini <trini at konsulko.com>; Simon Glass <sjg at chromium.org> Cc: u-boot at lists.denx.de; Stephen Warren <swarren at nvidia.com>; Tom Warren <TWarren at nvidia.com> Subject: Re: [PATCH] tegra: fdt: Add tegra186-u-boot.dtsi External email: Use caution opening links or attachments On 1/7/20 11:17 AM, Stephen Warren wrote: > From: Stephen Warren <swarren at nvidia.com> > > All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate > Tegra210's copy of this file for Tegra186. This ensures that a /binman > node exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0 > ("binman: Add a library to access binman entries") this appears to be > required. I haven't really investigated why all this is necessary or > how it works, but simply observed the boot failure listed below, > bisected it, noticed the inconsistency in DT files, and found that > fixing it resolved the boot issue. > > U-Boot 2020.01-rc4-00256-g3c10dc95bdd0 (Jan 07 2020 - 10:25:00 > -0700) > > SoC: tegra186 > Model: NVIDIA P2771-0000-500 > Board: NVIDIA P2771-0000 > DRAM: 7.8 GiB > initcall sequence 00000000fffb7858 failed at call 00000000800955a8 (err=-22) > ### ERROR ### Please RESET the board ### > > Fixes: 3c10dc95bdd0 ("binman: Add a library to access binman entries") > Fixes: f2faffecb016 ("binman: tegra: Convert to use binman") > Signed-off-by: Stephen Warren <swarren at nvidia.com> Can we please apply this? All Tegra186 systems (i.e. Jetson TX2) can't boot without this patch. Thank.s ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------
diff --git a/arch/arm/dts/tegra186-u-boot.dtsi b/arch/arm/dts/tegra186-u-boot.dtsi new file mode 100644 index 000000000000..7c1197255284 --- /dev/null +++ b/arch/arm/dts/tegra186-u-boot.dtsi @@ -0,0 +1,3 @@ +#include <config.h> + +#include "tegra-u-boot.dtsi"