diff mbox series

[1/2] net: tftp: Add help for CONFIG_TFTP_BLOCKSIZE

Message ID 20200422141755.1.I8b005c35223011e3c07122ccbf558bf8d27b6aab@changeid
State Accepted
Commit 421de7fec831902fb9b88651446cc80ae4045d45
Headers show
Series [1/2] net: tftp: Add help for CONFIG_TFTP_BLOCKSIZE | expand

Commit Message

Patrick Delaunay April 22, 2020, 12:18 p.m. UTC
Add help message for the CONFIG_TFTP_BLOCKSIZE default value,
as explain in tftp.c before migration in commit b618b3707633
("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig")

Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
---

 net/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Tom Rini April 28, 2020, 1:54 p.m. UTC | #1
On Wed, Apr 22, 2020 at 02:18:25PM +0200, Patrick Delaunay wrote:

> Add help message for the CONFIG_TFTP_BLOCKSIZE default value,
> as explain in tftp.c before migration in commit b618b3707633
> ("net: Convert CONFIG_TFTP_BLOCKSIZE to Kconfig")
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/net/Kconfig b/net/Kconfig
index 96bbce1778..ac6d0cf8a6 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -44,5 +44,9 @@  config TFTP_BLOCKSIZE
 	default 1468
 	help
 	  Default TFTP block size.
+	  The MTU is typically 1500 for ethernet, so a TFTP block of
+	  1468 (MTU minus eth.hdrs) provides a good throughput with
+	  almost-MTU block sizes.
+	  You can also activate CONFIG_IP_DEFRAG to set a larger block.
 
 endif   # if NET