diff mbox series

[v2,1/4] imxrt1050-evk: README: fix dd command destination

Message ID 20200427151107.101075-2-giulio.benetti@benettiengineering.com
State New
Headers show
Series Various i.MXRT bug/typo fixes | expand

Commit Message

Giulio Benetti April 27, 2020, 3:11 p.m. UTC
Make "of=" the same for the 2 commands since we're writing to the same
sd-card.

Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
---
 board/freescale/imxrt1050-evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam April 27, 2020, 3:34 p.m. UTC | #1
Hi Giulio,

On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
<giulio.benetti at benettiengineering.com> wrote:
>
> Make "of=" the same for the 2 commands since we're writing to the same
> sd-card.
>
> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
> ---
>  board/freescale/imxrt1050-evk/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README
> index f7e2894025..55b6a0877a 100644
> --- a/board/freescale/imxrt1050-evk/README
> +++ b/board/freescale/imxrt1050-evk/README
> @@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img.
>
>  - Flash the SPL image into the micro SD card:
>
> -sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
> +sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync

I usually prefer to write /dev/sdX instead because someone may follow
the instructions as is and inadvertently kill their hard disk or
another device that may appear at /dev/sdb.
Giulio Benetti April 27, 2020, 3:45 p.m. UTC | #2
On 4/27/20 5:34 PM, Fabio Estevam wrote:
> Hi Giulio,
> 
> On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti
> <giulio.benetti at benettiengineering.com> wrote:
>>
>> Make "of=" the same for the 2 commands since we're writing to the same
>> sd-card.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>>   board/freescale/imxrt1050-evk/README | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README
>> index f7e2894025..55b6a0877a 100644
>> --- a/board/freescale/imxrt1050-evk/README
>> +++ b/board/freescale/imxrt1050-evk/README
>> @@ -11,7 +11,7 @@ This will generate the SPL image called SPL and the u-boot.img.
>>
>>   - Flash the SPL image into the micro SD card:
>>
>> -sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
>> +sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync
> 
> I usually prefer to write /dev/sdX instead because someone may follow
> the instructions as is and inadvertently kill their hard disk or
> another device that may appear at /dev/sdb.

Oh, that's right.

I send V3 with that corrected.

Thank you
diff mbox series

Patch

diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-evk/README
index f7e2894025..55b6a0877a 100644
--- a/board/freescale/imxrt1050-evk/README
+++ b/board/freescale/imxrt1050-evk/README
@@ -11,7 +11,7 @@  This will generate the SPL image called SPL and the u-boot.img.
 
 - Flash the SPL image into the micro SD card:
 
-sudo dd if=SPL of=/dev/mmcblk0 bs=1k seek=1; sync
+sudo dd if=SPL of=/dev/sdb bs=1k seek=1; sync
 
 - Flash the u-boot.img image into the micro SD card: