diff mbox series

[4/6] x86: cbfs: Drop unwanted declaration

Message ID 20200405172230.4.I9cbd1af1c7a30c06301650e4eb40641b236bbb7d@changeid
State Superseded
Headers show
Series x86: efi: Add a 64-bit coreboot payload | expand

Commit Message

Simon Glass April 5, 2020, 11:22 p.m. UTC 
The intention here is add a forward declaration, not actually declare a
variable. Fix it.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 include/cbfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng April 23, 2020, 9:19 a.m. UTC | #1 
On Mon, Apr 6, 2020 at 7:22 AM Simon Glass <sjg at chromium.org> wrote:
>
> The intention here is add a forward declaration, not actually declare a
> variable. Fix it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  include/cbfs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Bin Meng April 23, 2020, 9:32 a.m. UTC | #2 
On Thu, Apr 23, 2020 at 5:19 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Mon, Apr 6, 2020 at 7:22 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > The intention here is add a forward declaration, not actually declare a
> > variable. Fix it.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  include/cbfs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

This patch is irrelevant to 64-bit coreboot payload support.

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/include/cbfs.h b/include/cbfs.h
index f3bc8ca24af..d915f9426d8 100644
--- a/include/cbfs.h
+++ b/include/cbfs.h
@@ -135,7 +135,7 @@  void file_cbfs_get_next(const struct cbfs_cachenode **file);
  */
 const struct cbfs_cachenode *file_cbfs_find(const char *name);
 
-struct cbfs_priv *priv;
+struct cbfs_priv;
 
 /**
  * cbfs_find_file() - Find a file in a given CBFS