| Message ID | 20200414104002.rwm7ekt7pjkuk56z@pali |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Tom, On 14/04/20 4:10 PM, Pali Roh?r wrote: > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: >> This patch contains a script which automatically download and compile all >> needed tools to build a simple MTD images for booting Maemo kernel image by >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 >> machine provided by qemu-linaro project. >> >> It can be used to check that U-Boot for Nokia N900 is not broken and can be >> successfully booted in emulator. >> >> Script is registered in to .travis.yml so it would be automatically run on >> Travi CI service. >> >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > Tom Rini, in past you have asked me for N900 Travis test. So could you > please review this patch (including fixup at the bottom)? Can you ack this patch? Thanks and regards, Lokesh
Hi, On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > Tom, > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > >> This patch contains a script which automatically download and compile all > >> needed tools to build a simple MTD images for booting Maemo kernel image by > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > >> machine provided by qemu-linaro project. > >> > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > >> successfully booted in emulator. > >> > >> Script is registered in to .travis.yml so it would be automatically run on > >> Travi CI service. > >> > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > please review this patch (including fixup at the bottom)? > > Can you ack this patch? Please use a pytest for this (test/py). We don't use shell scripts anymore. Regards, Simon
On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > Hi, > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > Tom, > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > >> This patch contains a script which automatically download and compile all > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > >> machine provided by qemu-linaro project. > > >> > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > >> successfully booted in emulator. > > >> > > >> Script is registered in to .travis.yml so it would be automatically run on > > >> Travi CI service. > > >> > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > please review this patch (including fixup at the bottom)? > > > > Can you ack this patch? > > Please use a pytest for this (test/py). We don't use shell scripts anymore. Well, this is where it's tricky and I've been debating with myself on how to move forward here. Part of the problem here is that much like a Pi, we could emulate this board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, there's not a lot of these devices around to test with. It's not a big deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab has a Pi and other labs could add one fairly easy. But adding an N900 to a lab is hard. Looking over the script to do it, there's a lot of other stuff required too, for it all to work. Looking over the script again, there's enough stuff going on that I wouldn't want it done in a persistent image/container. The only changes I would ask for I guess are that it should be put in .travis.yml in the same areas other non-pytest tests, and put in similar stanzas in .azure-ci.yml and .gitlab-ci.yml.
Hi, On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > Hi, > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > Tom, > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > >> This patch contains a script which automatically download and compile all > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > >> machine provided by qemu-linaro project. > > > >> > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > >> successfully booted in emulator. > > > >> > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > >> Travi CI service. > > > >> > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > please review this patch (including fixup at the bottom)? > > > > > > Can you ack this patch? > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > Well, this is where it's tricky and I've been debating with myself on > how to move forward here. > > Part of the problem here is that much like a Pi, we could emulate this > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > there's not a lot of these devices around to test with. It's not a big > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > has a Pi and other labs could add one fairly easy. But adding an N900 > to a lab is hard. > > Looking over the script to do it, there's a lot of other stuff required > too, for it all to work. Looking over the script again, there's enough > stuff going on that I wouldn't want it done in a persistent > image/container. > > The only changes I would ask for I guess are that it should be put in > .travis.yml in the same areas other non-pytest tests, and put in similar > stanzas in .azure-ci.yml and .gitlab-ci.yml. For the existing stuff we use some sort of qemu that is built into the image, so far as I understand it. Is that right? Could we do something similar here? I actually don't like that though, since there is so much setup needed to run things locally (without docker). Also, what is to stop me running this script on my machine? Regards, Simon
On Tue, Apr 21, 2020 at 02:37:45PM -0600, Simon Glass wrote: > Hi, > > On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > > > Tom, > > > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > > >> This patch contains a script which automatically download and compile all > > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > > >> machine provided by qemu-linaro project. > > > > >> > > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > > >> successfully booted in emulator. > > > > >> > > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > > >> Travi CI service. > > > > >> > > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > > please review this patch (including fixup at the bottom)? > > > > > > > > Can you ack this patch? > > > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > > > Well, this is where it's tricky and I've been debating with myself on > > how to move forward here. > > > > Part of the problem here is that much like a Pi, we could emulate this > > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > > there's not a lot of these devices around to test with. It's not a big > > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > > has a Pi and other labs could add one fairly easy. But adding an N900 > > to a lab is hard. > > > > Looking over the script to do it, there's a lot of other stuff required > > too, for it all to work. Looking over the script again, there's enough > > stuff going on that I wouldn't want it done in a persistent > > image/container. > > > > The only changes I would ask for I guess are that it should be put in > > .travis.yml in the same areas other non-pytest tests, and put in similar > > stanzas in .azure-ci.yml and .gitlab-ci.yml. > > For the existing stuff we use some sort of qemu that is built into the > image, so far as I understand it. Is that right? Right for GitLab/Azure, for Travis we checkout/build/install. > Could we do something similar here? I actually don't like that though, > since there is so much setup needed to run things locally (without > docker). That's what the script does. The problem is that we need a specific (seemingly dead-end, but I'd like to be told I'm wrong!) old commit. So we can't replace the QEMU we use for everyone with one that also supports N900. > Also, what is to stop me running this script on my machine? Nothing. And it does a good job of keeping all of the specific versions of stuff it needs local to itself.
Hi Tom, On Tue, 21 Apr 2020 at 14:46, Tom Rini <trini at konsulko.com> wrote: > > On Tue, Apr 21, 2020 at 02:37:45PM -0600, Simon Glass wrote: > > Hi, > > > > On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > > > > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > > > Hi, > > > > > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > > > > > Tom, > > > > > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > > > >> This patch contains a script which automatically download and compile all > > > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > > > >> machine provided by qemu-linaro project. > > > > > >> > > > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > > > >> successfully booted in emulator. > > > > > >> > > > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > > > >> Travi CI service. > > > > > >> > > > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > > > please review this patch (including fixup at the bottom)? > > > > > > > > > > Can you ack this patch? > > > > > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > > > > > Well, this is where it's tricky and I've been debating with myself on > > > how to move forward here. > > > > > > Part of the problem here is that much like a Pi, we could emulate this > > > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > > > there's not a lot of these devices around to test with. It's not a big > > > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > > > has a Pi and other labs could add one fairly easy. But adding an N900 > > > to a lab is hard. > > > > > > Looking over the script to do it, there's a lot of other stuff required > > > too, for it all to work. Looking over the script again, there's enough > > > stuff going on that I wouldn't want it done in a persistent > > > image/container. > > > > > > The only changes I would ask for I guess are that it should be put in > > > .travis.yml in the same areas other non-pytest tests, and put in similar > > > stanzas in .azure-ci.yml and .gitlab-ci.yml. > > > > For the existing stuff we use some sort of qemu that is built into the > > image, so far as I understand it. Is that right? > > Right for GitLab/Azure, for Travis we checkout/build/install. > > > Could we do something similar here? I actually don't like that though, > > since there is so much setup needed to run things locally (without > > docker). > > That's what the script does. The problem is that we need a specific > (seemingly dead-end, but I'd like to be told I'm wrong!) old commit. So > we can't replace the QEMU we use for everyone with one that also > supports N900. OK I see. > > > Also, what is to stop me running this script on my machine? > > Nothing. And it does a good job of keeping all of the specific versions > of stuff it needs local to itself. OK, so you don't think we should add this as a pytest? Regards, Simon
On Tue, Apr 21, 2020 at 02:49:05PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 21 Apr 2020 at 14:46, Tom Rini <trini at konsulko.com> wrote: > > > > On Tue, Apr 21, 2020 at 02:37:45PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > > > > > > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > > > > Hi, > > > > > > > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > > > > > > > Tom, > > > > > > > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > > > > >> This patch contains a script which automatically download and compile all > > > > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > > > > >> machine provided by qemu-linaro project. > > > > > > >> > > > > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > > > > >> successfully booted in emulator. > > > > > > >> > > > > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > > > > >> Travi CI service. > > > > > > >> > > > > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > > > > please review this patch (including fixup at the bottom)? > > > > > > > > > > > > Can you ack this patch? > > > > > > > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > > > > > > > Well, this is where it's tricky and I've been debating with myself on > > > > how to move forward here. > > > > > > > > Part of the problem here is that much like a Pi, we could emulate this > > > > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > > > > there's not a lot of these devices around to test with. It's not a big > > > > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > > > > has a Pi and other labs could add one fairly easy. But adding an N900 > > > > to a lab is hard. > > > > > > > > Looking over the script to do it, there's a lot of other stuff required > > > > too, for it all to work. Looking over the script again, there's enough > > > > stuff going on that I wouldn't want it done in a persistent > > > > image/container. > > > > > > > > The only changes I would ask for I guess are that it should be put in > > > > .travis.yml in the same areas other non-pytest tests, and put in similar > > > > stanzas in .azure-ci.yml and .gitlab-ci.yml. > > > > > > For the existing stuff we use some sort of qemu that is built into the > > > image, so far as I understand it. Is that right? > > > > Right for GitLab/Azure, for Travis we checkout/build/install. > > > > > Could we do something similar here? I actually don't like that though, > > > since there is so much setup needed to run things locally (without > > > docker). > > > > That's what the script does. The problem is that we need a specific > > (seemingly dead-end, but I'd like to be told I'm wrong!) old commit. So > > we can't replace the QEMU we use for everyone with one that also > > supports N900. > > OK I see. > > > > > > Also, what is to stop me running this script on my machine? > > > > Nothing. And it does a good job of keeping all of the specific versions > > of stuff it needs local to itself. > > OK, so you don't think we should add this as a pytest? No, I don't think wrapping this as a pytest would be valuable. Re-doing the FS tests is a step towards being able to run them on at least emulated HW too.
On Tuesday 21 April 2020 14:37:45 Simon Glass wrote: > Hi, > > On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > > > Tom, > > > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > > >> This patch contains a script which automatically download and compile all > > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > > >> machine provided by qemu-linaro project. > > > > >> > > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > > >> successfully booted in emulator. > > > > >> > > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > > >> Travi CI service. > > > > >> > > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > > please review this patch (including fixup at the bottom)? > > > > > > > > Can you ack this patch? > > > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > > > Well, this is where it's tricky and I've been debating with myself on > > how to move forward here. > > > > Part of the problem here is that much like a Pi, we could emulate this > > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > > there's not a lot of these devices around to test with. It's not a big > > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > > has a Pi and other labs could add one fairly easy. But adding an N900 > > to a lab is hard. > > > > Looking over the script to do it, there's a lot of other stuff required > > too, for it all to work. Looking over the script again, there's enough > > stuff going on that I wouldn't want it done in a persistent > > image/container. > > > > The only changes I would ask for I guess are that it should be put in > > .travis.yml in the same areas other non-pytest tests, and put in similar > > stanzas in .azure-ci.yml and .gitlab-ci.yml. > > For the existing stuff we use some sort of qemu that is built into the > image, so far as I understand it. Is that right? > > Could we do something similar here? I actually don't like that though, > since there is so much setup needed to run things locally (without > docker). That script run u-boot in n900 qemu machine and test that u-boot can correctly boot Maemo kernel (from RAM, eMMC and OneNAND) with simple rootfs. So it is full u-boot test for n900. And basically simulates whole bootloader process for Maemo. In this case I'm sure that everything is fine and I can replace new u-boot binary without introducing any regressions. It downloads all needed stuff to construct images and filesystems. > Also, what is to stop me running this script on my machine? In script is "sudo mknod rootfs/dev/console c 5 1" call as in rootfs is needed /dev/console character device. Otherwise everything is called under normal user and all stuff is put into current directory. And because on travis we can use 'sudo' I chosen this solution. Alternative way to avoid usage of sudo, is to run whole script under "fakeroot" utility. It use LD_PRELOAD with own library to fake mknod and stat functions, so process can mknod (in memory) character device and then mkfs.ubifs which reads (via stat) all files can properly put character devices into rootfs image -- without any root privilege escalation. So if you want to run it on your machine, you needs be aware of that sudo call. Or if you want I can change script to use fakeroot utility (e.g Debian is using it for building any DEB package) and then you can run it safely under "nobody" user locally on your machine (if you do not like that sudo call). > Regards, > Simon
On Tuesday 21 April 2020 16:46:36 Tom Rini wrote: > That's what the script does. The problem is that we need a specific > (seemingly dead-end, but I'd like to be told I'm wrong!) old commit. Not only specific commit, but specific fork! This is Linaro fork of qemu (with support for OMAP3) which Linaro never upstreamed and fork is now dead :-( > So we can't replace the QEMU we use for everyone with one that also > supports N900. You really need that specific version of qemu to run it. Upstream qemu has no support for N900 nor for OMAP3 HW. Plus it needs proprietary Nokia's first stage bootloader (which starts u-boot) with proprietary userspace tool which put this first stage bootloader and configuration for it into MTD image. In MTD there is one special partition with configuration data for this first stage bootloader and that proprietary tool fill it. Tool and first stage bootloader is under license which allows non-commercial redistribution Why we need that first stage bootloader? Because on real N900 HW it is signed and therefore cannot be replaced. Qemu version of that first stage bootloader is obviously not signed.
On Tuesday 21 April 2020 16:51:23 Tom Rini wrote: > On Tue, Apr 21, 2020 at 02:49:05PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 21 Apr 2020 at 14:46, Tom Rini <trini at konsulko.com> wrote: > > > > > > On Tue, Apr 21, 2020 at 02:37:45PM -0600, Simon Glass wrote: > > > > Hi, > > > > > > > > On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > > > > > > > > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > > > > > Hi, > > > > > > > > > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > > > > > > > > > Tom, > > > > > > > > > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > > > > > >> This patch contains a script which automatically download and compile all > > > > > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > > > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > > > > > >> machine provided by qemu-linaro project. > > > > > > > >> > > > > > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > > > > > >> successfully booted in emulator. > > > > > > > >> > > > > > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > > > > > >> Travi CI service. > > > > > > > >> > > > > > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > > > > > please review this patch (including fixup at the bottom)? > > > > > > > > > > > > > > Can you ack this patch? > > > > > > > > > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > > > > > > > > > Well, this is where it's tricky and I've been debating with myself on > > > > > how to move forward here. > > > > > > > > > > Part of the problem here is that much like a Pi, we could emulate this > > > > > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > > > > > there's not a lot of these devices around to test with. It's not a big > > > > > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > > > > > has a Pi and other labs could add one fairly easy. But adding an N900 > > > > > to a lab is hard. > > > > > > > > > > Looking over the script to do it, there's a lot of other stuff required > > > > > too, for it all to work. Looking over the script again, there's enough > > > > > stuff going on that I wouldn't want it done in a persistent > > > > > image/container. > > > > > > > > > > The only changes I would ask for I guess are that it should be put in > > > > > .travis.yml in the same areas other non-pytest tests, and put in similar > > > > > stanzas in .azure-ci.yml and .gitlab-ci.yml. > > > > > > > > For the existing stuff we use some sort of qemu that is built into the > > > > image, so far as I understand it. Is that right? > > > > > > Right for GitLab/Azure, for Travis we checkout/build/install. > > > > > > > Could we do something similar here? I actually don't like that though, > > > > since there is so much setup needed to run things locally (without > > > > docker). > > > > > > That's what the script does. The problem is that we need a specific > > > (seemingly dead-end, but I'd like to be told I'm wrong!) old commit. So > > > we can't replace the QEMU we use for everyone with one that also > > > supports N900. > > > > OK I see. > > > > > > > > > Also, what is to stop me running this script on my machine? > > > > > > Nothing. And it does a good job of keeping all of the specific versions > > > of stuff it needs local to itself. > > > > OK, so you don't think we should add this as a pytest? > > No, I don't think wrapping this as a pytest would be valuable. Re-doing > the FS tests is a step towards being able to run them on at least > emulated HW too. Ok, so is something needed to do with this patch?
On Tue, Apr 21, 2020 at 11:34:02PM +0200, Pali Roh?r wrote: > On Tuesday 21 April 2020 16:51:23 Tom Rini wrote: > > On Tue, Apr 21, 2020 at 02:49:05PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 21 Apr 2020 at 14:46, Tom Rini <trini at konsulko.com> wrote: > > > > > > > > On Tue, Apr 21, 2020 at 02:37:45PM -0600, Simon Glass wrote: > > > > > Hi, > > > > > > > > > > On Tue, 21 Apr 2020 at 14:12, Tom Rini <trini at konsulko.com> wrote: > > > > > > > > > > > > On Tue, Apr 21, 2020 at 11:36:37AM -0600, Simon Glass wrote: > > > > > > > Hi, > > > > > > > > > > > > > > On Tue, 21 Apr 2020 at 08:56, Lokesh Vutla <lokeshvutla at ti.com> wrote: > > > > > > > > > > > > > > > > Tom, > > > > > > > > > > > > > > > > On 14/04/20 4:10 PM, Pali Roh?r wrote: > > > > > > > > > On Wednesday 01 April 2020 00:35:18 Pali Roh?r wrote: > > > > > > > > >> This patch contains a script which automatically download and compile all > > > > > > > > >> needed tools to build a simple MTD images for booting Maemo kernel image by > > > > > > > > >> U-Boot from RAM, eMMC and OneNAND. MTD images are then run in virtual n900 > > > > > > > > >> machine provided by qemu-linaro project. > > > > > > > > >> > > > > > > > > >> It can be used to check that U-Boot for Nokia N900 is not broken and can be > > > > > > > > >> successfully booted in emulator. > > > > > > > > >> > > > > > > > > >> Script is registered in to .travis.yml so it would be automatically run on > > > > > > > > >> Travi CI service. > > > > > > > > >> > > > > > > > > >> Signed-off-by: Pali Roh?r <pali at kernel.org> > > > > > > > > > > > > > > > > > > Tom Rini, in past you have asked me for N900 Travis test. So could you > > > > > > > > > please review this patch (including fixup at the bottom)? > > > > > > > > > > > > > > > > Can you ack this patch? > > > > > > > > > > > > > > Please use a pytest for this (test/py). We don't use shell scripts anymore. > > > > > > > > > > > > Well, this is where it's tricky and I've been debating with myself on > > > > > > how to move forward here. > > > > > > > > > > > > Part of the problem here is that much like a Pi, we could emulate this > > > > > > board in QEMU but would need not-upstream-QEMU to do it. But unlike Pi, > > > > > > there's not a lot of these devices around to test with. It's not a big > > > > > > deal that Pi isn't tested by CI via QEMU, my lab as a Pi, Simon's lab > > > > > > has a Pi and other labs could add one fairly easy. But adding an N900 > > > > > > to a lab is hard. > > > > > > > > > > > > Looking over the script to do it, there's a lot of other stuff required > > > > > > too, for it all to work. Looking over the script again, there's enough > > > > > > stuff going on that I wouldn't want it done in a persistent > > > > > > image/container. > > > > > > > > > > > > The only changes I would ask for I guess are that it should be put in > > > > > > .travis.yml in the same areas other non-pytest tests, and put in similar > > > > > > stanzas in .azure-ci.yml and .gitlab-ci.yml. > > > > > > > > > > For the existing stuff we use some sort of qemu that is built into the > > > > > image, so far as I understand it. Is that right? > > > > > > > > Right for GitLab/Azure, for Travis we checkout/build/install. > > > > > > > > > Could we do something similar here? I actually don't like that though, > > > > > since there is so much setup needed to run things locally (without > > > > > docker). > > > > > > > > That's what the script does. The problem is that we need a specific > > > > (seemingly dead-end, but I'd like to be told I'm wrong!) old commit. So > > > > we can't replace the QEMU we use for everyone with one that also > > > > supports N900. > > > > > > OK I see. > > > > > > > > > > > > Also, what is to stop me running this script on my machine? > > > > > > > > Nothing. And it does a good job of keeping all of the specific versions > > > > of stuff it needs local to itself. > > > > > > OK, so you don't think we should add this as a pytest? > > > > No, I don't think wrapping this as a pytest would be valuable. Re-doing > > the FS tests is a step towards being able to run them on at least > > emulated HW too. > > Ok, so is something needed to do with this patch? Yes, re-order where the .travis.yml hunk is and add a similar part to .gitlab-ci.yml and .azure-ci.yml.
On Tuesday 21 April 2020 19:24:57 Tom Rini wrote: > On Tue, Apr 21, 2020 at 11:34:02PM +0200, Pali Roh?r wrote: > > Ok, so is something needed to do with this patch? > > Yes, re-order where the .travis.yml hunk is and add a similar part to > .gitlab-ci.yml and .azure-ci.yml. Hello Tom! I have looked at .travis.yml again, but I do not understand what do you mean by re-order. I really have no idea where you want to move that rx51_test.sh hunk. Could you describe it?
On Thu, Apr 23, 2020 at 09:34:26AM +0200, Pali Roh?r wrote: > On Tuesday 21 April 2020 19:24:57 Tom Rini wrote: > > On Tue, Apr 21, 2020 at 11:34:02PM +0200, Pali Roh?r wrote: > > > Ok, so is something needed to do with this patch? > > > > Yes, re-order where the .travis.yml hunk is and add a similar part to > > .gitlab-ci.yml and .azure-ci.yml. > > Hello Tom! I have looked at .travis.yml again, but I do not understand > what do you mean by re-order. I really have no idea where you want to > move that rx51_test.sh hunk. Could you describe it? This should go around where we check tools-only/envtools. Thanks!
On Thursday 23 April 2020 08:24:05 Tom Rini wrote: > On Thu, Apr 23, 2020 at 09:34:26AM +0200, Pali Roh?r wrote: > > On Tuesday 21 April 2020 19:24:57 Tom Rini wrote: > > > On Tue, Apr 21, 2020 at 11:34:02PM +0200, Pali Roh?r wrote: > > > > Ok, so is something needed to do with this patch? > > > > > > Yes, re-order where the .travis.yml hunk is and add a similar part to > > > .gitlab-ci.yml and .azure-ci.yml. > > > > Hello Tom! I have looked at .travis.yml again, but I do not understand > > what do you mean by re-order. I really have no idea where you want to > > move that rx51_test.sh hunk. Could you describe it? > > This should go around where we check tools-only/envtools. Thanks! Thank you, now I figured out. I will send V2 of this one patch.
diff --git a/.travis.yml b/.travis.yml index d96811473cb..cb556e85282 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,6 +42,7 @@ addons: - graphviz - mtools - mtd-utils + - gcc-arm-linux-gnueabi install: # Clone uboot-test-hooks diff --git a/test/rx51_test.sh b/test/rx51_test.sh index 43ecc07c08a..12dc1f28f0c 100755 --- a/test/rx51_test.sh +++ b/test/rx51_test.sh @@ -2,6 +2,10 @@ # SPDX-License-Identifier: GPL-2.0+ # (C) 2020 Pali Roh?r <pali at kernel.org> +make nokia_rx51_config +make -j4 u-boot.bin ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- +test -f mkimage || ln -s tools/mkimage . + # This test script depends on external tools: # wget git truncate tar dpkg dd mcopy (from mtools) mkfs.ubifs (from mtd-utils) ubinize (from mtd-utils)