diff mbox series

[v2,08/28] buildman: Use yellow consistently for warning lines

Message ID 20200409150840.v2.8.Ifbcc1c7085c9545bd1533d4b0685145aacd5a7f0@changeid
State Accepted
Commit 5627bd9d96bea76a51474286eb97b4bb47914c83
Headers show
Series buildman: Improve summary output | expand

Commit Message

Simon Glass April 9, 2020, 9:08 p.m. UTC 
At present warnings are shown in yellow in the summary (-s) but magenta in
the detail listing (-e). Use yellow in both.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v2: None

 tools/buildman/builder.py | 2 +-
 tools/buildman/test.py    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Simon Glass April 17, 2020, 11:29 p.m. UTC | #1 
At present warnings are shown in yellow in the summary (-s) but magenta in
the detail listing (-e). Use yellow in both.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v2: None

 tools/buildman/builder.py | 2 +-
 tools/buildman/test.py    | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Applied to u-boot-dm, thanks!
diff mbox series

Patch

diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index 621147696ed..01d8bf46e45 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -1279,7 +1279,7 @@  class Builder:
             _OutputErrLines(better_err, colour=self.col.GREEN)
             _OutputErrLines(worse_err, colour=self.col.RED)
             _OutputErrLines(better_warn, colour=self.col.CYAN)
-            _OutputErrLines(worse_warn, colour=self.col.MAGENTA)
+            _OutputErrLines(worse_warn, colour=self.col.YELLOW)
 
         if show_sizes:
             self.PrintSizeSummary(board_selected, board_dict, show_detail,
diff --git a/tools/buildman/test.py b/tools/buildman/test.py
index b1435b45c03..c494a158be6 100644
--- a/tools/buildman/test.py
+++ b/tools/buildman/test.py
@@ -264,7 +264,7 @@  class TestBuild(unittest.TestCase):
 
         self.assertEqual(line.text,
                          add_line_prefix('w+', boards1234, errors[0]))
-        self.assertEqual(line.colour, col.MAGENTA)
+        self.assertEqual(line.colour, col.YELLOW)
 
         # Third commit: Still fails
         self.assertEqual(next(lines).text, '03: %s' % commits[2][1])
@@ -299,7 +299,7 @@  class TestBuild(unittest.TestCase):
 
         line = next(lines)
         self.assertEqual(line.text, add_line_prefix('w+', boards34, errors[2]))
-        self.assertEqual(line.colour, col.MAGENTA)
+        self.assertEqual(line.colour, col.YELLOW)
 
         # Fifth commit
         self.assertEqual(next(lines).text, '05: %s' % commits[4][1])
@@ -353,7 +353,7 @@  class TestBuild(unittest.TestCase):
         expect = '\n'.join(expect)
         line = next(lines)
         self.assertEqual(line.text, add_line_prefix('w+', boards4, expect))
-        self.assertEqual(line.colour, col.MAGENTA)
+        self.assertEqual(line.colour, col.YELLOW)
 
     def testOutput(self):
         """Test basic builder operation and output