[v3,00/19] i.MXRT1050 add LCDIF support

This patchset add support for LCDIF on i.MXRT1050 evk. This requires
PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd
has inverted PIXCLOCK from dts.

With this patchset applied we temporary loose DCache support until it will
get implemented, since a function in mxsfb.c is needed for setting cache
behaviour. Anyway this way Lcd will show the console same way as serial
does.

Also I've moved private sunxi_ctfb_mode_to_display_timing() to videomodes
since I need it for mxfsb.c too, then having a unified function to convert
from ctfb_mode to display_timing.

Changes:
V1->V2:
* moved hard-coded LCDIF's parent clock from clk-imxrt1050.c to imxrt1050-evk.dts
* reworded some commit log
V2->V3:
* added comment to describe what is a ctfb in videomodes

Giulio Benetti (19):
  clk: imx: pllv3: add enable_bit
  clk: imx: clk-imxrt1050: fix typo in clock name "video:"
  clk: imx: clk-imxrt1050: setup PLL5 for video in non-SPL
  clk: imx: clk-imxrt1050: add set_parent() callback
  videomodes: add helper function to convert from ctfb to display_timing
  sunxi: display: use common video_ctfb_mode_to_display_timing()
  video: mxsfb: add support for DM CLK
  video: mxsfb: add support for i.MXRT
  video: mxsfb: refactor for using display_timings
  video: mxsfb: enable setting HSYNC negative polarity
  video: mxsfb: enable setting VSYNC negative polarity
  video: mxsfb: enable setting PIXDATA on negative edge
  video: mxsfb: enable setting ENABLE negative polarity
  imxrt1050_evk: add 16bpp video support if video layer enabled
  ARM: dts: i.mxrt1050: add lcdif node
  ARM: dts: imxrt1050: allow this dtsi file to be compiled in Linux
  arch: arm: dts: imxrt1050-evk: add lcdif node
  configs: imxrt1050-evk: enable video support/console
  configs: imxrt1050-evk: temporary disable DCACHE

 arch/arm/dts/imxrt1050-evk.dts             | 60 ++++++++++++++
 arch/arm/dts/imxrt1050.dtsi                | 14 +++-
 arch/arm/include/asm/arch-imxrt/imx-regs.h |  6 ++
 arch/arm/include/asm/mach-imx/regs-lcdif.h |  6 +-
 configs/imxrt1050-evk_defconfig            |  6 ++
 drivers/clk/imx/clk-imxrt1050.c            | 30 ++++++-
 drivers/clk/imx/clk-pllv3.c                |  9 +++
 drivers/video/mxsfb.c                      | 94 ++++++++++++++--------
 drivers/video/sunxi/sunxi_display.c        | 33 +-------
 drivers/video/videomodes.c                 | 29 +++++++
 drivers/video/videomodes.h                 | 11 +++
 include/configs/imxrt1050-evk.h            | 15 ++++
 12 files changed, 242 insertions(+), 71 deletions(-)

Kindly ping

Hi Giulio,

On Wed, Apr 8, 2020 at 12:10 PM Giulio Benetti
<giulio.benetti at benettiengineering.com> wrote:
>
> This patchset add support for LCDIF on i.MXRT1050 evk. This requires
> PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd
> has inverted PIXCLOCK from dts.
>
> With this patchset applied we temporary loose DCache support until it will
> get implemented, since a function in mxsfb.c is needed for setting cache
> behaviour. Anyway this way Lcd will show the console same way as serial
> does.
>
> Also I've moved private sunxi_ctfb_mode_to_display_timing() to videomodes
> since I need it for mxfsb.c too, then having a unified function to convert
> from ctfb_mode to display_timing.

Nice work!

This series looks good to me:

Reviewed-by: Fabio Estevam <festevam at gmail.com>

Hi Fabio,

On 4/16/20 3:26 AM, Fabio Estevam wrote:
> Hi Giulio,
> 
> On Wed, Apr 8, 2020 at 12:10 PM Giulio Benetti
> <giulio.benetti at benettiengineering.com> wrote:
>>
>> This patchset add support for LCDIF on i.MXRT1050 evk. This requires
>> PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd
>> has inverted PIXCLOCK from dts.
>>
>> With this patchset applied we temporary loose DCache support until it will
>> get implemented, since a function in mxsfb.c is needed for setting cache
>> behaviour. Anyway this way Lcd will show the console same way as serial
>> does.
>>
>> Also I've moved private sunxi_ctfb_mode_to_display_timing() to videomodes
>> since I need it for mxfsb.c too, then having a unified function to convert
>> from ctfb_mode to display_timing.
> 
> Nice work!
> 
> This series looks good to me:
> 
> Reviewed-by: Fabio Estevam <festevam at gmail.com>

Thank you for reviewing
Best regards