diff mbox series

[v2,1/1] drivers: usb: host: Add BRCM xHCI driver

Message ID 20200407062958.20807-1-rayagonda.kokatanur@broadcom.com
State Superseded
Headers show
Series [v2,1/1] drivers: usb: host: Add BRCM xHCI driver | expand

Commit Message

Rayagonda Kokatanur April 7, 2020, 6:29 a.m. UTC
Base driver for Broadcom xHCI controllers

Signed-off-by: Bharat Kumar Reddy Gooty <bharat.gooty at broadcom.com>
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
Signed-off-by: Vladimir Olovyannikov <vladimir.olovyannikov at broadcom.com>
---
Changes from v1:
 -Address review comments from Marek Vasut,
  Use comman macro name for read and write register,
  Rename the macro names.

 drivers/usb/host/Kconfig     |   8 +++
 drivers/usb/host/Makefile    |   1 +
 drivers/usb/host/xhci-brcm.c | 101 +++++++++++++++++++++++++++++++++++
 3 files changed, 110 insertions(+)
 create mode 100644 drivers/usb/host/xhci-brcm.c

Comments

Marek Vasut April 7, 2020, 9:03 a.m. UTC | #1
On 4/7/20 8:29 AM, Rayagonda Kokatanur wrote:
[...]
> +static int xhci_brcm_probe(struct udevice *dev)
> +{
> +	struct xhci_hccr *hcd;
> +	struct xhci_hcor *hcor;
> +	struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
> +	uintptr_t hc_base;
> +	int len, ret = 0;

Reverse xmas tree please.

[...]

> +static int xhci_brcm_deregister(struct udevice *dev)
> +{
> +	struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
> +	uintptr_t hc_base;
> +
> +	hc_base = (uintptr_t)dev_read_addr(dev);

You should cache the hc_base in driver private data instead of always
reading it out of the DT.

The rest looks good, thanks.
Rayagonda Kokatanur April 8, 2020, 3:36 a.m. UTC | #2
On Tue, Apr 7, 2020 at 2:39 PM Marek Vasut <marex at denx.de> wrote:
>
> On 4/7/20 8:29 AM, Rayagonda Kokatanur wrote:
> [...]
> > +static int xhci_brcm_probe(struct udevice *dev)
> > +{
> > +     struct xhci_hccr *hcd;
> > +     struct xhci_hcor *hcor;
> > +     struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
> > +     uintptr_t hc_base;
> > +     int len, ret = 0;
>
> Reverse xmas tree please.
>
> [...]
>
> > +static int xhci_brcm_deregister(struct udevice *dev)
> > +{
> > +     struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
> > +     uintptr_t hc_base;
> > +
> > +     hc_base = (uintptr_t)dev_read_addr(dev);
>
> You should cache the hc_base in driver private data instead of always
> reading it out of the DT.
>
> The rest looks good, thanks.

Will fix both review comments, thank you.
diff mbox series

Patch

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 0987ff25b1..94ac969058 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -88,6 +88,14 @@  config USB_XHCI_FSL
 	depends on !SPL_NO_USB
 	help
 	  Enables support for the on-chip xHCI controller on NXP Layerscape SoCs.
+
+config USB_XHCI_BRCM
+	bool "Broadcom USB3 Host XHCI controller"
+	depends on DM_USB
+	help
+	  USB controller based on the Broadcom USB3 IP Core.
+	  Supports USB2/3 functionality.
+
 endif # USB_XHCI_HCD
 
 config USB_EHCI_HCD
diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
index 7feeff679c..b62f346094 100644
--- a/drivers/usb/host/Makefile
+++ b/drivers/usb/host/Makefile
@@ -44,6 +44,7 @@  obj-$(CONFIG_USB_EHCI_RMOBILE) += ehci-rmobile.o
 obj-$(CONFIG_USB_EHCI_ZYNQ) += ehci-zynq.o
 
 # xhci
+obj-$(CONFIG_USB_XHCI_BRCM) += xhci-brcm.o
 obj-$(CONFIG_USB_XHCI_HCD) += xhci.o xhci-mem.o xhci-ring.o
 obj-$(CONFIG_USB_XHCI_DWC3) += xhci-dwc3.o
 obj-$(CONFIG_USB_XHCI_DWC3_OF_SIMPLE) += dwc3-of-simple.o
diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
new file mode 100644
index 0000000000..836493476e
--- /dev/null
+++ b/drivers/usb/host/xhci-brcm.c
@@ -0,0 +1,101 @@ 
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Broadcom.
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <fdtdec.h>
+#include <usb.h>
+#include <asm/io.h>
+#include <usb/xhci.h>
+
+#define DRD2U3H_XHC_REGS_AXIWRA	0xC08
+#define DRD2U3H_XHC_REGS_AXIRDA	0xC0C
+
+#define USBAXI_CACHE		0xF
+#define USBAXI_PROT		0x8
+#define USBAXI_SA_MASK		0x1FF
+#define USBAXI_UA_MASK		(0x1FF << 16)
+#define USBAXI_SA_VAL		((USBAXI_CACHE << 4) | USBAXI_PROT)
+#define USBAXI_UA_VAL		(USBAXI_SA_VAL << 16)
+#define USBAXI_SA_UA_MASK	(USBAXI_UA_MASK | USBAXI_SA_MASK)
+#define USBAXI_SA_UA_VAL	(USBAXI_UA_VAL | USBAXI_SA_VAL)
+
+struct brcm_xhci_platdata {
+	unsigned int arcache;
+	unsigned int awcache;
+};
+
+static int xhci_brcm_probe(struct udevice *dev)
+{
+	struct xhci_hccr *hcd;
+	struct xhci_hcor *hcor;
+	struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
+	uintptr_t hc_base;
+	int len, ret = 0;
+
+	if (!plat) {
+		dev_err(dev, "Can't get xHCI Plat data\n");
+		return -ENOMEM;
+	}
+
+	hcd = dev_read_addr_ptr(dev);
+	if (!hcd) {
+		dev_err(dev, "Can't get the xHCI register base address\n");
+		return -ENXIO;
+	}
+
+	hc_base = (uintptr_t)hcd;
+	len = HC_LENGTH(xhci_readl(&hcd->cr_capbase));
+	hcor = (struct xhci_hcor *)(hc_base + len);
+
+	/* Save the default values of AXI read and write attributes */
+	plat->awcache = readl(hc_base + DRD2U3H_XHC_REGS_AXIWRA);
+	plat->arcache = readl(hc_base + DRD2U3H_XHC_REGS_AXIRDA);
+
+	/* Enable AXI write attributes */
+	clrsetbits_le32(hc_base + DRD2U3H_XHC_REGS_AXIWRA,
+			USBAXI_SA_UA_MASK, USBAXI_SA_UA_VAL);
+
+	/* Enable AXI read attributes */
+	clrsetbits_le32(hc_base + DRD2U3H_XHC_REGS_AXIRDA,
+			USBAXI_SA_UA_MASK, USBAXI_SA_UA_VAL);
+
+	ret = xhci_register(dev, hcd, hcor);
+	if (ret)
+		dev_err(dev, "Failed to register xHCI\n");
+
+	return ret;
+}
+
+static int xhci_brcm_deregister(struct udevice *dev)
+{
+	struct brcm_xhci_platdata *plat = dev_get_platdata(dev);
+	uintptr_t hc_base;
+
+	hc_base = (uintptr_t)dev_read_addr(dev);
+
+	/* Restore the default values for AXI read and write attributes */
+	writel(plat->awcache, hc_base + DRD2U3H_XHC_REGS_AXIWRA);
+	writel(plat->arcache, hc_base + DRD2U3H_XHC_REGS_AXIRDA);
+
+	return xhci_deregister(dev);
+}
+
+static const struct udevice_id xhci_brcm_ids[] = {
+	{ .compatible = "brcm,generic-xhci" },
+	{ }
+};
+
+U_BOOT_DRIVER(usb_xhci) = {
+	.name				= "xhci_brcm",
+	.id				= UCLASS_USB,
+	.probe				= xhci_brcm_probe,
+	.remove				= xhci_brcm_deregister,
+	.ops				= &xhci_usb_ops,
+	.of_match			= xhci_brcm_ids,
+	.platdata_auto_alloc_size	= sizeof(struct brcm_xhci_platdata),
+	.priv_auto_alloc_size		= sizeof(struct xhci_ctrl),
+	.flags				= DM_FLAG_ALLOC_PRIV_DMA,
+};