diff mbox series

[2/2] ide: remove duplicate defines form include/ata.h

Message ID 20200227172801.3126-3-xypron.glpk@gmx.de
State Accepted
Commit 04571bec56a53c846f072fb3bc7543586f10ee93
Headers show
Series block: ide: remove duplicate defines form include/ata.h | expand

Commit Message

Heinrich Schuchardt Feb. 27, 2020, 5:28 p.m. UTC 
ATA commands are already defined in include/libata.h. There is no need to
duplicate them in include/ata.h.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 include/ata.h | 34 ----------------------------------
 1 file changed, 34 deletions(-)

--
2.25.0

Comments

Simon Glass Feb. 27, 2020, 11:40 p.m. UTC | #1 
On Thu, 27 Feb 2020 at 09:28, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> ATA commands are already defined in include/libata.h. There is no need to
> duplicate them in include/ata.h.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  include/ata.h | 34 ----------------------------------
>  1 file changed, 34 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>
Tom Rini April 21, 2020, 12:26 p.m. UTC | #2 
On Thu, Feb 27, 2020 at 06:28:01PM +0100, Heinrich Schuchardt wrote:

> ATA commands are already defined in include/libata.h. There is no need to
> duplicate them in include/ata.h.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/ata.h b/include/ata.h
index 3f4e4a0234..e35d91941d 100644
--- a/include/ata.h
+++ b/include/ata.h
@@ -70,43 +70,9 @@ 
 #endif /* ATA_DEVICE */
 #define ATA_LBA		0xE0

-/*
- * ATA Commands (only mandatory commands listed here)
- */
-#define ATA_CMD_READ	0x20	/* Read Sectors (with retries)	*/
-#define ATA_CMD_READN	0x21	/* Read Sectors ( no  retries)	*/
-#define ATA_CMD_WRITE	0x30	/* Write Sectores (with retries)*/
-#define ATA_CMD_WRITEN	0x31	/* Write Sectors  ( no  retries)*/
-#define ATA_CMD_VRFY	0x40	/* Read Verify  (with retries)	*/
-#define ATA_CMD_VRFYN	0x41	/* Read verify  ( no  retries)	*/
-#define ATA_CMD_SEEK	0x70	/* Seek				*/
-#define ATA_CMD_DIAG	0x90	/* Execute Device Diagnostic	*/
-#define ATA_CMD_INIT	0x91	/* Initialize Device Parameters	*/
-#define ATA_CMD_RD_MULT	0xC4	/* Read Multiple		*/
-#define ATA_CMD_WR_MULT	0xC5	/* Write Multiple		*/
-#define ATA_CMD_SETMULT	0xC6	/* Set Multiple Mode		*/
-#define ATA_CMD_RD_DMA	0xC8	/* Read DMA (with retries)	*/
-#define ATA_CMD_RD_DMAN	0xC9	/* Read DMS ( no  retries)	*/
-#define ATA_CMD_WR_DMA	0xCA	/* Write DMA (with retries)	*/
-#define ATA_CMD_WR_DMAN	0xCB	/* Write DMA ( no  retires)	*/
-#define ATA_CMD_IDENT	0xEC	/* Identify Device		*/
-#define ATA_CMD_SETF	0xEF	/* Set Features			*/
-#define ATA_CMD_CHK_PWR	0xE5	/* Check Power Mode		*/
-
-#define ATA_CMD_READ_EXT 0x24	/* Read Sectors (with retries)	with 48bit addressing */
-#define ATA_CMD_WRITE_EXT	0x34	/* Write Sectores (with retries) with 48bit addressing */
-#define ATA_CMD_VRFY_EXT	0x42	/* Read Verify	(with retries)	with 48bit addressing */
-
-#define ATA_CMD_FLUSH 0xE7 /* Flush drive cache */
-#define ATA_CMD_FLUSH_EXT 0xEA /* Flush drive cache, with 48bit addressing */
-
 /*
  * ATAPI Commands
  */
-#define ATAPI_CMD_IDENT 0xA1 /* Identify AT Atachment Packed Interface Device */
-#define ATAPI_CMD_PACKET 0xA0 /* Packed Command */
-
-
 #define ATAPI_CMD_INQUIRY 0x12
 #define ATAPI_CMD_REQ_SENSE 0x03
 #define ATAPI_CMD_READ_CAP 0x25