mbox series

[V4,0/7] Tegra XUSB charger detect support

Message ID 1593166742-23592-1-git-send-email-nkristam@nvidia.com
Headers show
Series Tegra XUSB charger detect support | expand

Message

Nagarjuna Kristam June 26, 2020, 10:18 a.m. UTC
This patch series adds charger detect support on XUSB hardware used in
Tegra210 and Tegra186 SoCs.

This patchset is composed with :
 - dt bindings of XUSB Pad Controller
 - Tegra XUSB device mode driver to add vbus_draw support 
 - Tegra PHY driver for charger detect support

Tests done:
 - Connect USB cable from ubuntu host to micro-B port of DUT to detect
   SDP_TYPE charger
 - Connect USB cable from external powered USB hub(which inturn connects
   to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger.
 - Connect USB cable from USB charger to micro-B port of DUT to detect
   DCP_TYPE charger.
DUT: Jetson-tx1, Jetson tx2.

V4:
 - Added ACKed-by details for PHY driver.
 - Used BIT macro instead of (1 << index) usage as suggested by Chunfeng Yun.
V3:
 - Added ACKed-by details for PHY driver and DT changes.
 - Functions and its arguments are aligned.
 - Tabs are used for alignment of MACRO's
 - For vbus_draw USDC callback, usb_phy set_power error is propogated.
 - Fixed various comments given by thierry.
V2:
 - Added ACKed-by details for DT patches.
 - All patches rebased.

Nagarjuna Kristam (7):
  dt-bindings: phy: tegra-xusb: Add charger-detect property
  phy: tegra: xusb: Add support for UTMI pad power control
  phy: tegra: xusb: Add USB2 pad power control support for Tegra210
  phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection
  phy: tegra: xusb: Add support for charger detect
  phy: tegra: xusb: Enable charger detect for Tegra186
  phy: tegra: xusb: Enable charger detect for Tegra210

 .../bindings/phy/nvidia,tegra124-xusb-padctl.txt   |   4 +
 drivers/phy/tegra/Makefile                         |   2 +-
 drivers/phy/tegra/cd.c                             | 283 +++++++++++++++++++++
 drivers/phy/tegra/xusb-tegra186.c                  |  92 +++++--
 drivers/phy/tegra/xusb-tegra210.c                  | 223 +++++++++++-----
 drivers/phy/tegra/xusb.c                           |  80 ++++++
 drivers/phy/tegra/xusb.h                           |  22 ++
 7 files changed, 621 insertions(+), 85 deletions(-)
 create mode 100644 drivers/phy/tegra/cd.c

Comments

Thierry Reding July 16, 2020, 12:48 p.m. UTC | #1
On Fri, Jun 26, 2020 at 03:48:55PM +0530, Nagarjuna Kristam wrote:
> This patch series adds charger detect support on XUSB hardware used in

> Tegra210 and Tegra186 SoCs.

> 

> This patchset is composed with :

>  - dt bindings of XUSB Pad Controller

>  - Tegra XUSB device mode driver to add vbus_draw support 

>  - Tegra PHY driver for charger detect support

> 

> Tests done:

>  - Connect USB cable from ubuntu host to micro-B port of DUT to detect

>    SDP_TYPE charger

>  - Connect USB cable from external powered USB hub(which inturn connects

>    to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger.

>  - Connect USB cable from USB charger to micro-B port of DUT to detect

>    DCP_TYPE charger.

> DUT: Jetson-tx1, Jetson tx2.

> 

> V4:

>  - Added ACKed-by details for PHY driver.

>  - Used BIT macro instead of (1 << index) usage as suggested by Chunfeng Yun.

> V3:

>  - Added ACKed-by details for PHY driver and DT changes.

>  - Functions and its arguments are aligned.

>  - Tabs are used for alignment of MACRO's

>  - For vbus_draw USDC callback, usb_phy set_power error is propogated.

>  - Fixed various comments given by thierry.

> V2:

>  - Added ACKed-by details for DT patches.

>  - All patches rebased.

> 

> Nagarjuna Kristam (7):

>   dt-bindings: phy: tegra-xusb: Add charger-detect property

>   phy: tegra: xusb: Add support for UTMI pad power control

>   phy: tegra: xusb: Add USB2 pad power control support for Tegra210

>   phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection

>   phy: tegra: xusb: Add support for charger detect

>   phy: tegra: xusb: Enable charger detect for Tegra186

>   phy: tegra: xusb: Enable charger detect for Tegra210

> 

>  .../bindings/phy/nvidia,tegra124-xusb-padctl.txt   |   4 +

>  drivers/phy/tegra/Makefile                         |   2 +-

>  drivers/phy/tegra/cd.c                             | 283 +++++++++++++++++++++

>  drivers/phy/tegra/xusb-tegra186.c                  |  92 +++++--

>  drivers/phy/tegra/xusb-tegra210.c                  | 223 +++++++++++-----

>  drivers/phy/tegra/xusb.c                           |  80 ++++++

>  drivers/phy/tegra/xusb.h                           |  22 ++

>  7 files changed, 621 insertions(+), 85 deletions(-)

>  create mode 100644 drivers/phy/tegra/cd.c


Hi Kishon, Vinod,

did you have any further comments on this series or is it good to go
into v5.9?

Thanks,
Thierry
Vinod Koul July 17, 2020, 6:43 a.m. UTC | #2
On 16-07-20, 14:48, Thierry Reding wrote:

> Hi Kishon, Vinod,

> 

> did you have any further comments on this series or is it good to go

> into v5.9?


I dont have this series in my inbox, can you please rebase and resend

-- 
~Vinod