| Message ID | 20200715150632.409077-10-lee.jones@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Rid W=1 warnings in SPI | expand |
On 15. 07. 20 17:06, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' > drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' > drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' > > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: Sureshkumar Relli <nagasure@xilinx.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/spi/spi-zynq-qspi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c > index bbf3d90561f54..5d8a5ee62fa23 100644 > --- a/drivers/spi/spi-zynq-qspi.c > +++ b/drivers/spi/spi-zynq-qspi.c > @@ -119,6 +119,7 @@ > > /** > * struct zynq_qspi - Defines qspi driver instance > + * @dev: Pointer to the this device's information > * @regs: Virtual address of the QSPI controller registers > * @refclk: Pointer to the peripheral clock > * @pclk: Pointer to the APB clock > @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) > /** > * zynq_qspi_config_op - Configure QSPI controller for specified transfer > * @xqspi: Pointer to the zynq_qspi structure > - * @qspi: Pointer to the spi_device structure > + * @spi: Pointer to the spi_device structure > * > * Sets the operational mode of QSPI controller for the next QSPI transfer and > * sets the requested clock frequency. > Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency.
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Michal Simek <michal.simek@xilinx.com> Cc: Sureshkumar Relli <nagasure@xilinx.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1