| Message ID | 20200713144930.1034632-1-lee.jones@linaro.org |
|---|---|
| Headers | show |
| Series | Rid W=1 warnings in Pinctrl | expand |
Am Montag, 13. Juli 2020, 16:49:12 CEST schrieb Lee Jones: > Kerneldoc struct titles must be followed by whitespace. Also attributes > need to be in the format '@.*: ' else the checker gets confused. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data ' > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > index 9bd0a3de101dd..5e24838a582f5 100644 > --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > @@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = { > } > > /** > - * struct s3c24xx_eint_data: EINT common data > + * struct s3c24xx_eint_data - EINT common data > * @drvdata: pin controller driver data > * @domains: IRQ domains of particular EINT interrupts > * @parents: mapped parent irqs in the main interrupt controller > @@ -92,10 +92,10 @@ struct s3c24xx_eint_data { > }; > > /** > - * struct s3c24xx_eint_domain_data: per irq-domain data > + * struct s3c24xx_eint_domain_data - per irq-domain data > * @bank: pin bank related to the domain > * @eint_data: common data > - * eint0_3_parent_only: live eints 0-3 only in the main intc > + * @eint0_3_parent_only: live eints 0-3 only in the main intc > */ > struct s3c24xx_eint_domain_data { > struct samsung_pin_bank *bank; >
On Mon, Jul 13, 2020 at 4:49 PM Lee Jones <lee.jones@linaro.org> wrote:
> pinctrl: pinctrl-single: Fix struct/function documentation blocks
This patch didn't apply to v5.8-rc1 so I applied that one separately
after merging in all the other patches from a branch.
Seems to work! So all applied.
Also THANKS for doing this!!
Yours,
Linus Walleij
On Mon, Jul 13, 2020 at 03:49:12PM +0100, Lee Jones wrote: > Kerneldoc struct titles must be followed by whitespace. Also attributes > need to be in the format '@.*: ' else the checker gets confused. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data ' > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++--- Thanks, applied. Best regards, Krzysztof
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. After these patches are applied, the build system no longer complains about any W=0 nor W=1 level warnings in drivers/pinctrl. Hurrah! Lee Jones (25): pinctrl: actions: pinctrl-owl: Supply missing 'struct owl_pinctrl' attribute descriptions pinctrl: sirf: pinctrl-atlas7: Fix a bunch of documentation misdemeanours pinctrl: bcm: pinctrl-bcm281xx: Demote obvious misuse of kerneldoc to standard comment blocks pinctrl: bcm: pinctrl-iproc-gpio: Rename incorrectly documented function param pinctrl: qcom: pinctrl-msm: Complete 'struct msm_pinctrl' documentation pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues pinctrl: qcom: pinctrl-msm8976: Remove unused variable 'nav_tsync_groups' pinctrl: mediatek: pinctrl-mtk-common-v2: Mark 'mtk_default_register_base_names' as __maybe_unused pinctrl: core: Fix a bunch of kerneldoc issues pinctrl: pinmux: Add some missing parameter descriptions pinctrl: devicetree: Add one new attribute description and rename another two pinctrl: pinconf-generic: Add function parameter description 'pctldev' pinctrl: pinctrl-at91-pio4: PM related attribute descriptions arch: arm: mach-at91: pm: Move prototypes to mutually included header pinctrl: pinctrl-at91: Demote non-kerneldoc header and complete another pinctrl: pinctrl-bm1880: Rename ill documented struct attribute entries pinctrl: pinctrl-rockchip: Fix a bunch of kerneldoc misdemeanours pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others pinctrl: pinctrl-single: Fix struct/function documentation blocks pinctrl: tegra: pinctrl-tegra194: Do not initialise field twice pinctrl: meson: pinctrl-meson-a1: Remove unused const variable 'i2c_slave_groups' pinctrl: mvebu: pinctrl-armada-37xx: Update documentation block for 'struct armada_37xx_pin_group' pinctrl: pinctrl-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI arch/arm/mach-at91/pm.c | 17 +++++-------- drivers/pinctrl/actions/pinctrl-owl.c | 4 ++++ drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 6 ++--- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +- drivers/pinctrl/core.c | 12 +++++----- drivers/pinctrl/devicetree.c | 5 ++-- .../pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 +- drivers/pinctrl/meson/pinctrl-meson-a1.c | 5 ---- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 +++--- drivers/pinctrl/pinconf-generic.c | 3 ++- drivers/pinctrl/pinctrl-amd.c | 2 ++ drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ drivers/pinctrl/pinctrl-at91.c | 7 +++++- drivers/pinctrl/pinctrl-bm1880.c | 4 ++-- drivers/pinctrl/pinctrl-rockchip.c | 22 +++++++++-------- drivers/pinctrl/pinctrl-rza1.c | 24 +++++++++---------- drivers/pinctrl/pinctrl-single.c | 13 +++++++--- drivers/pinctrl/pinmux.c | 5 +++- drivers/pinctrl/qcom/pinctrl-msm.c | 6 ++++- drivers/pinctrl/qcom/pinctrl-msm8976.c | 3 --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 ++--- drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 ++--- drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++-- drivers/pinctrl/sirf/pinctrl-atlas7.c | 21 +++++++--------- drivers/pinctrl/tegra/pinctrl-tegra194.c | 1 - include/linux/platform_data/atmel.h | 5 ++++ 26 files changed, 107 insertions(+), 87 deletions(-) -- 2.25.1