diff mbox series

[01/25] pinctrl: actions: pinctrl-owl: Supply missing 'struct owl_pinctrl' attribute descriptions

Message ID 20200713144930.1034632-2-lee.jones@linaro.org
State Accepted
Commit 80fa3300b7e5d738365698052d999ea71bb24723
Headers show
Series Rid W=1 warnings in Pinctrl | expand

Commit Message

Lee Jones July 13, 2020, 2:49 p.m. UTC 
Fixes the following W=1 kernel build warning(s):

 drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'clk' not described in 'owl_pinctrl'
 drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq_chip' not described in 'owl_pinctrl'
 drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'num_irq' not described in 'owl_pinctrl'
 drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq' not described in 'owl_pinctrl'

Cc: "Andreas Färber" <afaerber@suse.de>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: David Liu <liuwei@actions-semi.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/pinctrl/actions/pinctrl-owl.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.25.1

Comments

Manivannan Sadhasivam July 14, 2020, 5:18 p.m. UTC | #1 
On Mon, Jul 13, 2020 at 03:49:06PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'clk' not described in 'owl_pinctrl'

>  drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq_chip' not described in 'owl_pinctrl'

>  drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'num_irq' not described in 'owl_pinctrl'

>  drivers/pinctrl/actions/pinctrl-owl.c:52: warning: Function parameter or member 'irq' not described in 'owl_pinctrl'

> 

> Cc: "Andreas Färber" <afaerber@suse.de>

> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> Cc: David Liu <liuwei@actions-semi.com>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Thanks,
Mani

> ---

>  drivers/pinctrl/actions/pinctrl-owl.c | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c

> index 5a0c8e87aa7cd..7efdfb4f3e9ba 100644

> --- a/drivers/pinctrl/actions/pinctrl-owl.c

> +++ b/drivers/pinctrl/actions/pinctrl-owl.c

> @@ -35,8 +35,12 @@

>   * @pctrldev: pinctrl handle

>   * @chip: gpio chip

>   * @lock: spinlock to protect registers

> + * @clk: clock control

>   * @soc: reference to soc_data

>   * @base: pinctrl register base address

> + * @irq_chip: IRQ chip information

> + * @num_irq: number of possible interrupts

> + * @irq: interrupt numbers

>   */

>  struct owl_pinctrl {

>  	struct device *dev;

> -- 

> 2.25.1

>
diff mbox series

Patch

diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c
index 5a0c8e87aa7cd..7efdfb4f3e9ba 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.c
+++ b/drivers/pinctrl/actions/pinctrl-owl.c
@@ -35,8 +35,12 @@ 
  * @pctrldev: pinctrl handle
  * @chip: gpio chip
  * @lock: spinlock to protect registers
+ * @clk: clock control
  * @soc: reference to soc_data
  * @base: pinctrl register base address
+ * @irq_chip: IRQ chip information
+ * @num_irq: number of possible interrupts
+ * @irq: interrupt numbers
  */
 struct owl_pinctrl {
 	struct device *dev;