| Message ID | 20200622185919.2131-2-dmurphy@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Multicolor Framework v29 | expand |
Hi! > Add DT bindings for the LEDs multicolor class framework. > Add multicolor ID to the color ID list for device tree bindings. Rob, can we get some reviews here? It would be good to move this forward. Best regards, Pavel > CC: Rob Herring <robh@kernel.org> > Acked-by: Pavel Machek <pavel@ucw.cz> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../bindings/leds/leds-class-multicolor.yaml | 37 +++++++++++++++++++ > include/dt-bindings/leds/common.h | 3 +- > 2 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > new file mode 100644 > index 000000000000..b55e1f1308a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-class-multicolor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common properties for the multicolor LED class. > + > +maintainers: > + - Dan Murphy <dmurphy@ti.com> > + > +description: | > + Bindings for multi color LEDs show how to describe current outputs of > + either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV > + etc.) or standalone LEDs, to achieve logically grouped multi-color LED > + modules. This is achieved by adding multi-led nodes layer to the > + monochrome LED bindings. > + The nodes and properties defined in this document are unique to the multicolor > + LED class. Common LED nodes and properties are inherited from the common.txt > + within this documentation directory. > + > +patternProperties: > + "^multi-led@([0-9a-f])$": > + type: object > + description: Represents the LEDs that are to be grouped. > + properties: > + color: > + const: 8 # LED_COLOR_ID_MULTI > + description: | > + For multicolor LED support this property should be defined as > + LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h. > + > + $ref: "common.yaml#" > + > + required: > + - color > +... > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index 0ce7dfc00dcb..a463ce6a8794 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -30,7 +30,8 @@ > #define LED_COLOR_ID_VIOLET 5 > #define LED_COLOR_ID_YELLOW 6 > #define LED_COLOR_ID_IR 7 > -#define LED_COLOR_ID_MAX 8 > +#define LED_COLOR_ID_MULTI 8 > +#define LED_COLOR_ID_MAX 9 > > /* Standard LED functions */ > /* Keyboard LEDs, usually it would be input4::capslock etc. */ > -- -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Mon, 22 Jun 2020 13:59:04 -0500, Dan Murphy wrote: > Add DT bindings for the LEDs multicolor class framework. > Add multicolor ID to the color ID list for device tree bindings. > > CC: Rob Herring <robh@kernel.org> > Acked-by: Pavel Machek <pavel@ucw.cz> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../bindings/leds/leds-class-multicolor.yaml | 37 +++++++++++++++++++ > include/dt-bindings/leds/common.h | 3 +- > 2 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu 2020-07-09 13:24:21, Rob Herring wrote: > On Mon, 22 Jun 2020 13:59:04 -0500, Dan Murphy wrote: > > Add DT bindings for the LEDs multicolor class framework. > > Add multicolor ID to the color ID list for device tree bindings. > > > > CC: Rob Herring <robh@kernel.org> > > Acked-by: Pavel Machek <pavel@ucw.cz> > > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > --- > > .../bindings/leds/leds-class-multicolor.yaml | 37 +++++++++++++++++++ > > include/dt-bindings/leds/common.h | 3 +- > > 2 files changed, 39 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > > > Reviewed-by: Rob Herring <robh@kernel.org> Thank you for the review! Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml new file mode 100644 index 000000000000..b55e1f1308a4 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-class-multicolor.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Common properties for the multicolor LED class. + +maintainers: + - Dan Murphy <dmurphy@ti.com> + +description: | + Bindings for multi color LEDs show how to describe current outputs of + either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV + etc.) or standalone LEDs, to achieve logically grouped multi-color LED + modules. This is achieved by adding multi-led nodes layer to the + monochrome LED bindings. + The nodes and properties defined in this document are unique to the multicolor + LED class. Common LED nodes and properties are inherited from the common.txt + within this documentation directory. + +patternProperties: + "^multi-led@([0-9a-f])$": + type: object + description: Represents the LEDs that are to be grouped. + properties: + color: + const: 8 # LED_COLOR_ID_MULTI + description: | + For multicolor LED support this property should be defined as + LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h. + + $ref: "common.yaml#" + + required: + - color +... diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index 0ce7dfc00dcb..a463ce6a8794 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -30,7 +30,8 @@ #define LED_COLOR_ID_VIOLET 5 #define LED_COLOR_ID_YELLOW 6 #define LED_COLOR_ID_IR 7 -#define LED_COLOR_ID_MAX 8 +#define LED_COLOR_ID_MULTI 8 +#define LED_COLOR_ID_MAX 9 /* Standard LED functions */ /* Keyboard LEDs, usually it would be input4::capslock etc. */